Changeset 184868 in webkit for trunk/Source/JavaScriptCore

Timestamp:

May 26, 2015, 12:47:56 PM (10 years ago)

Author:

Yusuke Suzuki

Message:

Inline @Array / @Object callsites
​https://bugs.webkit.org/show_bug.cgi?id=145382

Reviewed by Geoffrey Garen.

As the same to Array/Object callsite inlining, @Array/@Object also
should be inlined in bytecode level.
While new @Object style is not encouraged in the builtins,
@Array(len) is already used at least in Array.from code.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::expectedFunctionForIdentifier):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• bytecompiler/BytecodeGenerator.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-05-26  Yusuke Suzuki  <[email protected]>
+
+        Inline @Array / @Object callsites
+        https://bugs.webkit.org/show_bug.cgi?id=145382
+
+        Reviewed by Geoffrey Garen.
+
+        As the same to Array/Object callsite inlining, @Array/@Object also
+        should be inlined in bytecode level.
+        While `new @Object` style is not encouraged in the builtins,
+        `@Array(len)` is already used at least in Array.from code.
+
+        * bytecompiler/BytecodeGenerator.cpp:
+        (JSC::BytecodeGenerator::expectedFunctionForIdentifier):
+
 2015-05-26  Andreas Kling  <[email protected]>
 

trunk/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp

@@ -1845 +1845 @@
 ExpectedFunction BytecodeGenerator::expectedFunctionForIdentifier(const Identifier& identifier)
 {
-    if (identifier == m_vm->propertyNames->Object)
+    if (identifier == m_vm->propertyNames->Object || identifier == m_vm->propertyNames->ObjectPrivateName)
         return ExpectObjectConstructor;
-    if (identifier == m_vm->propertyNames->Array)
+    if (identifier == m_vm->propertyNames->Array || identifier == m_vm->propertyNames->ArrayPrivateName)
         return ExpectArrayConstructor;
     return NoExpectedFunction;