Changeset 184871 in webkit for trunk/Source/JavaScriptCore/tests

Timestamp:

May 26, 2015, 2:17:22 PM (10 years ago)

Author:

Yusuke Suzuki

Message:

Reflect nits for r184863
​https://bugs.webkit.org/show_bug.cgi?id=145107

Reviewed by Darin Adler.

1. Added the copyright line.
2. Added an optional argument (/*, end */). To do so, fixed generate-js-builtins.
3. Dropped the unnecessary variable thisValue.
4. Fix the type error messages. This is also found in StringIterator.prototype.js.
5. Added tests for 0 arguments.

• builtins/Array.prototype.js:

(copyWithin):

• builtins/StringIterator.prototype.js:

(next):

• generate-js-builtins:
• tests/stress/array-copywithin.js:
• tests/stress/string-iterators.js:

Location:

trunk/Source/JavaScriptCore/tests/stress

Files:

• array-copywithin.js (modified) (2 diffs)
• string-iterators.js (modified) (1 diff)

trunk/Source/JavaScriptCore/tests/stress/array-copywithin.js

@@ -35 +35 @@
 shouldBe(Array.prototype.hasOwnProperty('copyWithin'), true);
 shouldBe(JSON.stringify(Object.getOwnPropertyDescriptor(Array.prototype, 'copyWithin')), '{"writable":true,"enumerable":false,"configurable":true}');
+
+// 0 arguments. (it is equivalent to copyWithin(0))
+shouldBeArray([1, 2, 3, 4, 5].copyWithin(), [1, 2, 3, 4, 5]);
+shouldBeArray([].copyWithin(), []);
 
 // 1 arguments.
@@ -235 +239 @@
 shouldThrow(function () {
     Array.prototype.copyWithin.call(undefined);
-}, 'TypeError: Array.copyWithin requires that |this| be not null or undefined');
+}, 'TypeError: Array.copyWithin requires that |this| not be null or undefined');
 
 shouldThrow(function () {
     Array.prototype.copyWithin.call(null);
-}, 'TypeError: Array.copyWithin requires that |this| be not null or undefined');
+}, 'TypeError: Array.copyWithin requires that |this| not be null or undefined');
 
 

trunk/Source/JavaScriptCore/tests/stress/string-iterators.js

@@ -183 +183 @@
     var message = 'TypeError: %StringIteratorPrototype%.next requires that |this| be a String Iterator instance';
     if (primitive == null)
-        message = 'TypeError: %StringIteratorPrototype%.next requires that |this| be not null or undefined'
+        message = 'TypeError: %StringIteratorPrototype%.next requires that |this| not be null or undefined'
     if (String(didThrow) !== message)
         throw "Error: bad error thrown: " + didThrow;