Changeset 187279 in webkit for trunk/Source/JavaScriptCore/API

Timestamp:

Jul 23, 2015, 5:55:10 PM (10 years ago)

Author:

[email protected]

Message:

Remove compile and runtime flags for promises.
​https://bugs.webkit.org/show_bug.cgi?id=147244

Reviewed by Yusuke Suzuki.

.:

• Source/cmake/OptionsMac.cmake:
• Source/cmake/OptionsWindows.cmake:
• Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

• API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject<Parent>::JSCallbackObject):

• API/JSContextRef.cpp:

(JSGlobalContextCreateInGroup):

• Configurations/FeatureDefines.xcconfig:
• inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::getInternalProperties):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::create):
(JSC::JSGlobalObject::syntaxErrorConstructor):
(JSC::JSGlobalObject::typeErrorConstructor):
(JSC::JSGlobalObject::URIErrorConstructor):
(JSC::JSGlobalObject::promiseConstructor):
(JSC::JSGlobalObject::nullGetterFunction):
(JSC::JSGlobalObject::nullSetterFunction):
(JSC::JSGlobalObject::applyFunction):
(JSC::JSGlobalObject::definePropertyFunction):
(JSC::JSGlobalObject::arrayProtoValuesFunction):
(JSC::JSGlobalObject::initializePromiseFunction):
(JSC::JSGlobalObject::newPromiseDeferredFunction):
(JSC::JSGlobalObject::throwTypeErrorGetterSetter):
(JSC::JSGlobalObject::regExpPrototype):
(JSC::JSGlobalObject::errorPrototype):
(JSC::JSGlobalObject::iteratorPrototype):
(JSC::JSGlobalObject::promisePrototype):
(JSC::JSGlobalObject::debuggerScopeStructure):
(JSC::JSGlobalObject::withScopeStructure):
(JSC::JSGlobalObject::iteratorResultStructure):
(JSC::JSGlobalObject::iteratorResultStructureOffset):
(JSC::JSGlobalObject::regExpMatchesArrayStructure):
(JSC::JSGlobalObject::promiseStructure):

• runtime/JSPromise.cpp:

(JSC::JSPromise::result):

• runtime/JSPromise.h:
• runtime/JSPromiseConstructor.cpp:

(JSC::constructPromise):

• runtime/JSPromiseConstructor.h:
• runtime/JSPromiseDeferred.cpp:

(JSC::JSPromiseDeferred::visitChildren):

• runtime/JSPromiseDeferred.h:
• runtime/JSPromisePrototype.cpp:

(JSC::JSPromisePrototype::getOwnPropertySlot):

• runtime/JSPromisePrototype.h:
• runtime/RuntimeFlags.h:
• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:
• bindings/js/JSDOMPromise.cpp:

(WebCore::rejectPromiseWithExceptionIfAny):

• bindings/js/JSDOMPromise.h:

Source/WebKit/mac:

• Configurations/FeatureDefines.xcconfig:
• WebView/WebPreferencesPrivate.h:

Source/WebKit/win:

• Interfaces/IWebPreferencesPrivate.idl:

Source/WebKit2:

• Configurations/FeatureDefines.xcconfig:
• UIProcess/API/C/WKPreferencesRefPrivate.h:
• UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Source/WTF:

• wtf/FeatureDefines.h:

Location:

trunk/Source/JavaScriptCore/API

Files:

• JSCallbackObjectFunctions.h (modified) (1 diff)
• JSContextRef.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/API/JSCallbackObjectFunctions.h

@@ -63 +63 @@
 }
 
-extern const GlobalObjectMethodTable javaScriptCoreAPIGlobalObjectMethodTable;
-
 // Global object constructor.
 // FIXME: Move this into a separate JSGlobalCallbackObject class derived from this one.
 template <class Parent>
 JSCallbackObject<Parent>::JSCallbackObject(VM& vm, JSClassRef jsClass, Structure* structure)
-    : Parent(vm, structure, &javaScriptCoreAPIGlobalObjectMethodTable)
+    : Parent(vm, structure)
     , m_callbackObjectData(std::make_unique<JSCallbackObjectData>(nullptr, jsClass))
 {

trunk/Source/JavaScriptCore/API/JSContextRef.cpp

@@ -36 +36 @@
 #include "JSObject.h"
 #include "JSCInlines.h"
-#include "RuntimeFlags.h"
 #include "SourceProvider.h"
 #include "StackVisitor.h"
@@ -59 +58 @@
 
 using namespace JSC;
-
-const GlobalObjectMethodTable JSC::javaScriptCoreAPIGlobalObjectMethodTable = { &JSGlobalObject::allowsAccessFrom, &JSGlobalObject::supportsProfiling, &JSGlobalObject::supportsRichSourceInfo, &JSGlobalObject::shouldInterruptScript, &JSGlobalObject::javaScriptRuntimeFlags, nullptr, &JSGlobalObject::shouldInterruptScriptBeforeTimeout };
 
 // From the API's perspective, a context group remains alive iff
@@ -155 +152 @@
 
     if (!globalObjectClass) {
-        JSGlobalObject* globalObject = JSGlobalObject::create(*vm, JSGlobalObject::createStructure(*vm, jsNull()), &javaScriptCoreAPIGlobalObjectMethodTable);
+        JSGlobalObject* globalObject = JSGlobalObject::create(*vm, JSGlobalObject::createStructure(*vm, jsNull()));
 #if ENABLE(REMOTE_INSPECTOR)
         if (JSRemoteInspectorGetInspectionEnabledByDefault())