Changeset 19059 in webkit for trunk/JavaScriptCore/JavaScriptCore.xcodeproj

Timestamp:

Jan 23, 2007, 2:23:09 PM (18 years ago)

Author:

ggaren

Message:

Reviewed by Maciej Stachowiak.

Fixed <rdar://problem/4885131> Move CFString function declarations from
JSStringRef.h to JSStringRefCF.h

Also removed remaining API FIXMEs and changed them into Radars.

• API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): Added Radar numbers for UTF8 conversion.

• API/JSContextRef.cpp: (JSGlobalContextCreate): Replaced FIXME for NULL JSContextRef with Radar number.

• API/JSObjectRef.h: Removed FIXME, which is unprofessional in a public header.

• API/JSStringRef.cpp: Moved CF related implementations to JSStringRefCF.cpp. (JSStringCreateWithUTF8CString): Replaced FIXME with Radar number.
• API/JSStringRef.h: Moved CF related declarations to JSStringRefCF.h. Added #include of JSStringRefCF.h as a stopgap until clients start #including it as needed by themselves.

• API/JSStringRefCF.cpp: Added. (JSStringCreateWithCFString): (JSStringCopyCFString): Replaced JSChar cast with UniChar cast, which is more appropriate for a CF call.
• API/JSStringRefCF.h: Added.
• JavaScriptCore.xcodeproj/project.pbxproj:

File:

• trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj (modified) (5 diffs)

trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

@@ -54 +54 @@
                 1440FCE30A51E46B0005F061 /* JSClassRef.h in Headers */ = {isa = PBXBuildFile; fileRef = 1440FCE10A51E46B0005F061 /* JSClassRef.h */; };
                 1440FCE40A51E46B0005F061 /* JSClassRef.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1440FCE20A51E46B0005F061 /* JSClassRef.cpp */; };
+                146AAB2B0B66A84900E55F16 /* JSStringRefCF.h in Headers */ = {isa = PBXBuildFile; fileRef = 146AAB2A0B66A84900E55F16 /* JSStringRefCF.h */; };
+                146AAB380B66A94400E55F16 /* JSStringRefCF.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 146AAB370B66A94400E55F16 /* JSStringRefCF.cpp */; };
                 14760864099C633800437128 /* JSImmediate.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 14760863099C633800437128 /* JSImmediate.cpp */; };
                 1482B6EB0A4300B300517CFC /* JSValueRef.h in Headers */ = {isa = PBXBuildFile; fileRef = 1482B6EA0A4300B300517CFC /* JSValueRef.h */; settings = {ATTRIBUTES = (Public, ); }; };
@@ -437 +439 @@
                 1440FCE10A51E46B0005F061 /* JSClassRef.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSClassRef.h; sourceTree = "<group>"; };
                 1440FCE20A51E46B0005F061 /* JSClassRef.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSClassRef.cpp; sourceTree = "<group>"; };
+                146AAB2A0B66A84900E55F16 /* JSStringRefCF.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = JSStringRefCF.h; sourceTree = "<group>"; };
+                146AAB370B66A94400E55F16 /* JSStringRefCF.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = JSStringRefCF.cpp; sourceTree = "<group>"; };
                 14760863099C633800437128 /* JSImmediate.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSImmediate.cpp; sourceTree = "<group>"; };
                 1482B6EA0A4300B300517CFC /* JSValueRef.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSValueRef.h; sourceTree = "<group>"; };
@@ -785 +789 @@
                                 1482B74C0A43032800517CFC /* JSStringRef.cpp */,
                                 1482B74B0A43032800517CFC /* JSStringRef.h */,
+                                146AAB2A0B66A84900E55F16 /* JSStringRefCF.h */,
+                                146AAB370B66A94400E55F16 /* JSStringRefCF.cpp */,
                                 14BD5A2B0A3E91F600BAF59C /* JSValueRef.cpp */,
                                 1482B6EA0A4300B300517CFC /* JSValueRef.h */,
@@ -1214 +1220 @@
                                 D212022B0AD4310D00ED79B6 /* DateMath.h in Headers */,
                                 E11D51760B2E798D0056C188 /* StringExtras.h in Headers */,
+                                146AAB2B0B66A84900E55F16 /* JSStringRefCF.h in Headers */,
                         );
                         runOnlyForDeploymentPostprocessing = 0;
@@ -1511 +1518 @@
                                 65C7A1730A8EAACB00FA37EA /* JSWrapperObject.cpp in Sources */,
                                 D212022A0AD4310D00ED79B6 /* DateMath.cpp in Sources */,
+                                146AAB380B66A94400E55F16 /* JSStringRefCF.cpp in Sources */,
                         );
                         runOnlyForDeploymentPostprocessing = 0;