Changeset 192202 in webkit for trunk/Source/JavaScriptCore/builtins/GlobalObject.js

Timestamp:

Nov 9, 2015, 11:21:23 PM (10 years ago)

Author:

[email protected]

Message:

Built-in generator should check that there are no duplicate in JS built-in internal functions
​https://bugs.webkit.org/show_bug.cgi?id=151018

Reviewed by Brian Burg.

Added @internal to corresponding JS built-in files.
Added check in built-in generator so that clashing names result in an error.

• Scripts/builtins/builtins_generate_combined_header.py:

(generate_section_for_code_name_macro):

• Scripts/builtins/builtins_model.py:

(BuiltinsCollection.all_internal_functions):

• builtins/GlobalObject.js:
• builtins/Operations.Promise.js:
• Scripts/tests/builtins/expected/JavaScriptCore-InternalClashingNames-Combined.js-error: Added.
• Scripts/tests/builtins/expected/JavaScriptCore-InternalClashingNames-Combined.js-result: Added.

File:

• trunk/Source/JavaScriptCore/builtins/GlobalObject.js (modified) (1 diff)

trunk/Source/JavaScriptCore/builtins/GlobalObject.js

@@ -23 +23 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
+
+// @internal
 
 function toInteger(target)