Changeset 194470 in webkit for trunk/Source/JavaScriptCore/replay

Timestamp:

Dec 31, 2015, 2:49:09 PM (9 years ago)

Author:

[email protected]

Message:

Fix warnings uncovered by migrating to WTF_MOVE
​https://bugs.webkit.org/show_bug.cgi?id=152601

Reviewed by Daniel Bates.

Source/JavaScriptCore:

• create_regex_tables: Moving a return value prevented copy elision.
• ftl/FTLUnwindInfo.cpp:

(JSC::FTL::parseUnwindInfo): Ditto.

• replay/EncodedValue.h: Ditto.

Source/WebCore:

• Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::createSession): Moving a return value prevented copy elision.

Source/WebKit2:

• UIProcess/API/APIUIClient.h:

(API::UIClient::actionsForElement): Moving a return value passed to the function by value is redundant, since it
will be implicitly moved in this case.

• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::actionsForElement): Ditto.

Tools:

Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
self-move, even if doing so would trigger a warning.

• TestWebKitAPI/Tests/WTF/NakedPtr.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WTF/RefPtr.cpp:

(TestWebKitAPI::TEST):

File:

• trunk/Source/JavaScriptCore/replay/EncodedValue.h (modified) (1 diff)

trunk/Source/JavaScriptCore/replay/EncodedValue.h

@@ -115 +115 @@
             encodedVector.append<T>(value);
 
-        return WTF::move(encodedVector);
+        return encodedVector;
     }