Changeset 205093 in webkit


Ignore:
Timestamp:
Aug 27, 2016, 5:40:24 PM (9 years ago)
Author:
[email protected]
Message:

Add final keyword to final classes and overriden methods in WebCore/css
​https://bugs.webkit.org/show_bug.cgi?id=161182

Patch by Rawinder Singh <​[email protected]> on 2016-08-27
Reviewed by Darin Adler.

  • Mark classes in the WebCore/css directory final as appropriate.
  • Update WebCore/css classes so that overriden methods in final classes are marked final.
  • css/CSSAnimationTriggerScrollValue.h:
  • css/CSSAspectRatioValue.h:
  • css/CSSBasicShapes.h:
  • css/CSSBorderImageSliceValue.h:
  • css/CSSCalculationValue.cpp:

(WebCore::determineCategory):

  • css/CSSCalculationValue.h:
  • css/CSSCanvasValue.h:
  • css/CSSCharsetRule.h:
  • css/CSSComputedStyleDeclaration.h:
  • css/CSSContentDistributionValue.h:
  • css/CSSCrossfadeValue.h:
  • css/CSSCursorImageValue.h:
  • css/CSSCustomPropertyValue.h:
  • css/CSSFilterImageValue.h:
  • css/CSSFontFaceLoadEvent.h:
  • css/CSSFontFaceSrcValue.h:
  • css/CSSFontFeatureValue.h:
  • css/CSSFontSelector.h:
  • css/CSSFontValue.h:
  • css/CSSFunctionValue.h:
  • css/CSSGradientValue.h:
  • css/CSSGridAutoRepeatValue.h:
  • css/CSSGridLineNamesValue.h:
  • css/CSSGridTemplateAreasValue.h:
  • css/CSSImageSetValue.h:
  • css/CSSImageValue.h:
  • css/CSSInheritedValue.h:
  • css/CSSInitialValue.h:
  • css/CSSKeyframeRule.h:
  • css/CSSKeyframesRule.h:
  • css/CSSLineBoxContainValue.h:
  • css/CSSNamedImageValue.h:
  • css/CSSPrimitiveValue.h:
  • css/CSSReflectValue.h:
  • css/CSSRevertValue.h:
  • css/CSSRuleList.h:
  • css/CSSSegmentedFontFace.h:
  • css/CSSShadowValue.h:
  • css/CSSStyleSheet.cpp:
  • css/CSSStyleSheet.h:
  • css/CSSSupportsRule.h:
  • css/CSSTimingFunctionValue.h:
  • css/CSSUnicodeRangeValue.h:
  • css/CSSUnknownRule.h:
  • css/CSSUnsetValue.h:
  • css/CSSValue.cpp:
  • css/CSSVariableDependentValue.h:
  • css/CSSVariableValue.h:
  • css/Counter.h:
  • css/DOMCSSNamespace.h:
  • css/DashboardRegion.h:
  • css/LengthRepeat.h:
  • css/MediaList.h:
  • css/MediaQueryList.h:
  • css/MediaQueryMatcher.h:
  • css/Pair.h:
  • css/PropertySetCSSStyleDeclaration.h:
  • css/RGBColor.h:
  • css/Rect.h:
  • css/StyleMedia.h:
  • css/StyleProperties.h:
  • css/StyleRule.h:
  • css/StyleRuleImport.h:
  • css/StyleSheetContents.h:
  • css/StyleSheetList.h:
  • css/ViewportStyleResolver.h:
  • css/WebKitCSSFilterValue.h:
  • css/WebKitCSSRegionRule.h:
  • css/WebKitCSSTransformValue.h:
  • css/WebKitCSSViewportRule.h:
Location:
trunk/Source/WebCore
Files:
71 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r205092 r205093  
     12016-08-27  Rawinder Singh  <[email protected]>
     2
     3        Add final keyword to final classes and overriden methods in WebCore/css
     4        https://bugs.webkit.org/show_bug.cgi?id=161182
     5
     6        Reviewed by Darin Adler.
     7
     8        - Mark classes in the WebCore/css directory final as appropriate.
     9        - Update WebCore/css classes so that overriden methods in final classes are marked final.
     10
     11        * css/CSSAnimationTriggerScrollValue.h:
     12        * css/CSSAspectRatioValue.h:
     13        * css/CSSBasicShapes.h:
     14        * css/CSSBorderImageSliceValue.h:
     15        * css/CSSCalculationValue.cpp:
     16        (WebCore::determineCategory):
     17        * css/CSSCalculationValue.h:
     18        * css/CSSCanvasValue.h:
     19        * css/CSSCharsetRule.h:
     20        * css/CSSComputedStyleDeclaration.h:
     21        * css/CSSContentDistributionValue.h:
     22        * css/CSSCrossfadeValue.h:
     23        * css/CSSCursorImageValue.h:
     24        * css/CSSCustomPropertyValue.h:
     25        * css/CSSFilterImageValue.h:
     26        * css/CSSFontFaceLoadEvent.h:
     27        * css/CSSFontFaceSrcValue.h:
     28        * css/CSSFontFeatureValue.h:
     29        * css/CSSFontSelector.h:
     30        * css/CSSFontValue.h:
     31        * css/CSSFunctionValue.h:
     32        * css/CSSGradientValue.h:
     33        * css/CSSGridAutoRepeatValue.h:
     34        * css/CSSGridLineNamesValue.h:
     35        * css/CSSGridTemplateAreasValue.h:
     36        * css/CSSImageSetValue.h:
     37        * css/CSSImageValue.h:
     38        * css/CSSInheritedValue.h:
     39        * css/CSSInitialValue.h:
     40        * css/CSSKeyframeRule.h:
     41        * css/CSSKeyframesRule.h:
     42        * css/CSSLineBoxContainValue.h:
     43        * css/CSSNamedImageValue.h:
     44        * css/CSSPrimitiveValue.h:
     45        * css/CSSReflectValue.h:
     46        * css/CSSRevertValue.h:
     47        * css/CSSRuleList.h:
     48        * css/CSSSegmentedFontFace.h:
     49        * css/CSSShadowValue.h:
     50        * css/CSSStyleSheet.cpp:
     51        * css/CSSStyleSheet.h:
     52        * css/CSSSupportsRule.h:
     53        * css/CSSTimingFunctionValue.h:
     54        * css/CSSUnicodeRangeValue.h:
     55        * css/CSSUnknownRule.h:
     56        * css/CSSUnsetValue.h:
     57        * css/CSSValue.cpp:
     58        * css/CSSVariableDependentValue.h:
     59        * css/CSSVariableValue.h:
     60        * css/Counter.h:
     61        * css/DOMCSSNamespace.h:
     62        * css/DashboardRegion.h:
     63        * css/LengthRepeat.h:
     64        * css/MediaList.h:
     65        * css/MediaQueryList.h:
     66        * css/MediaQueryMatcher.h:
     67        * css/Pair.h:
     68        * css/PropertySetCSSStyleDeclaration.h:
     69        * css/RGBColor.h:
     70        * css/Rect.h:
     71        * css/StyleMedia.h:
     72        * css/StyleProperties.h:
     73        * css/StyleRule.h:
     74        * css/StyleRuleImport.h:
     75        * css/StyleSheetContents.h:
     76        * css/StyleSheetList.h:
     77        * css/ViewportStyleResolver.h:
     78        * css/WebKitCSSFilterValue.h:
     79        * css/WebKitCSSRegionRule.h:
     80        * css/WebKitCSSTransformValue.h:
     81        * css/WebKitCSSViewportRule.h:
     82
    1832016-08-27  Simon Fraser  <[email protected]>
    284

  • trunk/Source/WebCore/css/CSSAnimationTriggerScrollValue.h

    r201223 r205093  
    3232namespace WebCore {
    3333
    34 class CSSAnimationTriggerScrollValue : public CSSValue {
     34class CSSAnimationTriggerScrollValue final : public CSSValue {
    3535public:
    3636    static Ref<CSSAnimationTriggerScrollValue> create(Ref<CSSValue>&& startValue, RefPtr<CSSValue>&& endValue = nullptr)

  • trunk/Source/WebCore/css/CSSAspectRatioValue.h

    r201113 r205093  
    3333namespace WebCore {
    3434
    35 class CSSAspectRatioValue : public CSSValue {
     35class CSSAspectRatioValue final : public CSSValue {
    3636public:
    3737    static Ref<CSSAspectRatioValue> create(float numeratorValue, float denominatorValue)

  • trunk/Source/WebCore/css/CSSBasicShapes.h

    r201303 r205093  
    113113    CSSBasicShapeInset() { }
    114114
    115     Type type() const override { return CSSBasicShapeInsetType; }
    116     String cssText() const override;
    117     bool equals(const CSSBasicShape&) const override;
     115    Type type() const final { return CSSBasicShapeInsetType; }
     116    String cssText() const final;
     117    bool equals(const CSSBasicShape&) const final;
    118118
    119119    RefPtr<CSSPrimitiveValue> m_top;
    … …  
    143143    CSSBasicShapeCircle() { }
    144144
    145     Type type() const override { return CSSBasicShapeCircleType; }
    146     String cssText() const override;
    147     bool equals(const CSSBasicShape&) const override;
     145    Type type() const final { return CSSBasicShapeCircleType; }
     146    String cssText() const final;
     147    bool equals(const CSSBasicShape&) const final;
    148148
    149149    RefPtr<CSSPrimitiveValue> m_centerX;
    … …  
    169169    CSSBasicShapeEllipse() { }
    170170
    171     Type type() const override { return CSSBasicShapeEllipseType; }
    172     String cssText() const override;
    173     bool equals(const CSSBasicShape&) const override;
     171    Type type() const final { return CSSBasicShapeEllipseType; }
     172    String cssText() const final;
     173    bool equals(const CSSBasicShape&) const final;
    174174
    175175    RefPtr<CSSPrimitiveValue> m_centerX;
    … …  
    200200    }
    201201
    202     Type type() const override { return CSSBasicShapePolygonType; }
    203     String cssText() const override;
    204     bool equals(const CSSBasicShape&) const override;
     202    Type type() const final { return CSSBasicShapePolygonType; }
     203    String cssText() const final;
     204    bool equals(const CSSBasicShape&) const final;
    205205
    206206    Vector<Ref<CSSPrimitiveValue>> m_values;
    … …  
    226226    CSSBasicShapePath(std::unique_ptr<SVGPathByteStream>&&);
    227227
    228     Type type() const override { return CSSBasicShapePathType; }
    229     String cssText() const override;
    230     bool equals(const CSSBasicShape&) const override;
     228    Type type() const final { return CSSBasicShapePathType; }
     229    String cssText() const final;
     230    bool equals(const CSSBasicShape&) const final;
    231231
    232232    std::unique_ptr<SVGPathByteStream> m_byteStream;

  • trunk/Source/WebCore/css/CSSBorderImageSliceValue.h

    r201113 r205093  
    3333class Rect;
    3434
    35 class CSSBorderImageSliceValue : public CSSValue {
     35class CSSBorderImageSliceValue final : public CSSValue {
    3636public:
    3737    static Ref<CSSBorderImageSliceValue> create(RefPtr<CSSPrimitiveValue>&& slices, bool fill)

  • trunk/Source/WebCore/css/CSSCalculationValue.cpp

    r201318 r205093  
    214214
    215215private:
    216     bool isZero() const override
     216    bool isZero() const final
    217217    {
    218218        return !m_value->getDoubleValue();
    219219    }
    220220
    221     String customCSSText() const override
     221    String customCSSText() const final
    222222    {
    223223        return m_value->cssText();
    224224    }
    225225
    226     std::unique_ptr<CalcExpressionNode> createCalcExpression(const CSSToLengthConversionData& conversionData) const override
     226    std::unique_ptr<CalcExpressionNode> createCalcExpression(const CSSToLengthConversionData& conversionData) const final
    227227    {
    228228        switch (category()) {
    … …  
    248248    }
    249249
    250     double doubleValue() const override
     250    double doubleValue() const final
    251251    {
    252252        if (hasDoubleValue(primitiveType()))
    … …  
    256256    }
    257257
    258     double computeLengthPx(const CSSToLengthConversionData& conversionData) const override
     258    double computeLengthPx(const CSSToLengthConversionData& conversionData) const final
    259259    {
    260260        switch (category()) {
    … …  
    277277    }
    278278
    279     bool equals(const CSSCalcExpressionNode& other) const override
     279    bool equals(const CSSCalcExpressionNode& other) const final
    280280    {
    281281        if (type() != other.type())
    … …  
    285285    }
    286286
    287     Type type() const override { return CssCalcPrimitiveValue; }
    288     CSSPrimitiveValue::UnitTypes primitiveType() const override
     287    Type type() const final { return CssCalcPrimitiveValue; }
     288    CSSPrimitiveValue::UnitTypes primitiveType() const final
    289289    {
    290290        return CSSPrimitiveValue::UnitTypes(m_value->primitiveType());
    … …  
    421421
    422422private:
    423     bool isZero() const override
     423    bool isZero() const final
    424424    {
    425425        return !doubleValue();
    426426    }
    427427
    428     std::unique_ptr<CalcExpressionNode> createCalcExpression(const CSSToLengthConversionData& conversionData) const override
     428    std::unique_ptr<CalcExpressionNode> createCalcExpression(const CSSToLengthConversionData& conversionData) const final
    429429    {
    430430        std::unique_ptr<CalcExpressionNode> left(m_leftSide->createCalcExpression(conversionData));
    … …  
    437437    }
    438438
    439     double doubleValue() const override
     439    double doubleValue() const final
    440440    {
    441441        return evaluate(m_leftSide->doubleValue(), m_rightSide->doubleValue());
    442442    }
    443443
    444     double computeLengthPx(const CSSToLengthConversionData& conversionData) const override
     444    double computeLengthPx(const CSSToLengthConversionData& conversionData) const final
    445445    {
    446446        const double leftValue = m_leftSide->computeLengthPx(conversionData);
    … …  
    463463    }
    464464
    465     String customCSSText() const override
     465    String customCSSText() const final
    466466    {
    467467        return buildCssText(m_leftSide->customCSSText(), m_rightSide->customCSSText(), m_operator);
    468468    }
    469469
    470     bool equals(const CSSCalcExpressionNode& exp) const override
     470    bool equals(const CSSCalcExpressionNode& exp) const final
    471471    {
    472472        if (type() != exp.type())
    … …  
    479479    }
    480480
    481     Type type() const override { return CssCalcBinaryOperation; }
    482 
    483     CSSPrimitiveValue::UnitTypes primitiveType() const override
     481    Type type() const final { return CssCalcBinaryOperation; }
     482
     483    CSSPrimitiveValue::UnitTypes primitiveType() const final
    484484    {
    485485        switch (category()) {

  • trunk/Source/WebCore/css/CSSCalculationValue.h

    r201113 r205093  
    8686};
    8787
    88 class CSSCalcValue : public CSSValue {
     88class CSSCalcValue final : public CSSValue {
    8989public:
    9090    static RefPtr<CSSCalcValue> create(CSSParserString name, CSSParserValueList& arguments, CalculationPermittedValueRange);

  • trunk/Source/WebCore/css/CSSCanvasValue.h

    r201113 r205093  
    3434class HTMLCanvasElement;
    3535
    36 class CSSCanvasValue : public CSSImageGeneratorValue {
     36class CSSCanvasValue final : public CSSImageGeneratorValue {
    3737public:
    3838    static Ref<CSSCanvasValue> create(const String& name) { return adoptRef(*new CSSCanvasValue(name)); }
    … …  
    7272
    7373    private:
    74         void canvasChanged(HTMLCanvasElement& canvas, const FloatRect& changedRect) override
     74        void canvasChanged(HTMLCanvasElement& canvas, const FloatRect& changedRect) final
    7575        {
    7676            m_ownerValue.canvasChanged(canvas, changedRect);
    7777        }
    78         void canvasResized(HTMLCanvasElement& canvas) override
     78        void canvasResized(HTMLCanvasElement& canvas) final
    7979        {
    8080            m_ownerValue.canvasResized(canvas);
    8181        }
    82         void canvasDestroyed(HTMLCanvasElement& canvas) override
     82        void canvasDestroyed(HTMLCanvasElement& canvas) final
    8383        {
    8484            m_ownerValue.canvasDestroyed(canvas);

  • trunk/Source/WebCore/css/CSSCharsetRule.h

    r197563 r205093  
    3636    virtual ~CSSCharsetRule() { }
    3737
    38     String cssText() const override;
    39     void reattach(StyleRuleBase&) override { }
     38    String cssText() const final;
     39    void reattach(StyleRuleBase&) final { }
    4040
    4141    const String& encoding() const { return m_encoding; }
    … …  
    4343
    4444private:
    45     CSSRule::Type type() const override { return CHARSET_RULE; }
     45    CSSRule::Type type() const final { return CHARSET_RULE; }
    4646
    4747    CSSCharsetRule(CSSStyleSheet* parent, const String& encoding);

  • trunk/Source/WebCore/css/CSSComputedStyleDeclaration.h

    r203623 r205093  
    9595    virtual ~CSSComputedStyleDeclaration();
    9696
    97     WEBCORE_EXPORT void ref() override;
    98     WEBCORE_EXPORT void deref() override;
     97    WEBCORE_EXPORT void ref() final;
     98    WEBCORE_EXPORT void deref() final;
    9999
    100100    String getPropertyValue(CSSPropertyID) const;
    … …  
    104104
    105105    // CSSOM functions. Don't make these public.
    106     CSSRule* parentRule() const override;
    107     unsigned length() const override;
    108     String item(unsigned index) const override;
    109     RefPtr<CSSValue> getPropertyCSSValue(const String& propertyName) override;
    110     String getPropertyValue(const String& propertyName) override;
    111     String getPropertyPriority(const String& propertyName) override;
    112     String getPropertyShorthand(const String& propertyName) override;
    113     bool isPropertyImplicit(const String& propertyName) override;
    114     void setProperty(const String& propertyName, const String& value, const String& priority, ExceptionCode&) override;
    115     String removeProperty(const String& propertyName, ExceptionCode&) override;
    116     String cssText() const override;
    117     void setCssText(const String&, ExceptionCode&) override;
    118     RefPtr<CSSValue> getPropertyCSSValueInternal(CSSPropertyID) override;
    119     String getPropertyValueInternal(CSSPropertyID) override;
    120     bool setPropertyInternal(CSSPropertyID, const String& value, bool important, ExceptionCode&) override;
    121     Ref<MutableStyleProperties> copyProperties() const override;
     106    CSSRule* parentRule() const final;
     107    unsigned length() const final;
     108    String item(unsigned index) const final;
     109    RefPtr<CSSValue> getPropertyCSSValue(const String& propertyName) final;
     110    String getPropertyValue(const String& propertyName) final;
     111    String getPropertyPriority(const String& propertyName) final;
     112    String getPropertyShorthand(const String& propertyName) final;
     113    bool isPropertyImplicit(const String& propertyName) final;
     114    void setProperty(const String& propertyName, const String& value, const String& priority, ExceptionCode&) final;
     115    String removeProperty(const String& propertyName, ExceptionCode&) final;
     116    String cssText() const final;
     117    void setCssText(const String&, ExceptionCode&) final;
     118    RefPtr<CSSValue> getPropertyCSSValueInternal(CSSPropertyID) final;
     119    String getPropertyValueInternal(CSSPropertyID) final;
     120    bool setPropertyInternal(CSSPropertyID, const String& value, bool important, ExceptionCode&) final;
     121    Ref<MutableStyleProperties> copyProperties() const final;
    122122
    123123    RefPtr<CSSValue> getPropertyCSSValue(CSSPropertyID, EUpdateLayout = UpdateLayout) const;

  • trunk/Source/WebCore/css/CSSContentDistributionValue.h

    r188619 r205093  
    3333namespace WebCore {
    3434
    35 class CSSContentDistributionValue : public CSSValue {
     35class CSSContentDistributionValue final : public CSSValue {
    3636public:
    3737    static Ref<CSSContentDistributionValue> create(CSSValueID distribution, CSSValueID position, CSSValueID overflow)

  • trunk/Source/WebCore/css/CSSCrossfadeValue.h

    r201290 r205093  
    4141class Document;
    4242
    43 class CSSCrossfadeValue : public CSSImageGeneratorValue {
     43class CSSCrossfadeValue final : public CSSImageGeneratorValue {
    4444    friend class CrossfadeSubimageObserverProxy;
    4545public:
    … …  
    9191
    9292        virtual ~CrossfadeSubimageObserverProxy() { }
    93         void imageChanged(CachedImage*, const IntRect* = nullptr) override;
     93        void imageChanged(CachedImage*, const IntRect* = nullptr) final;
    9494        void setReady(bool ready) { m_ready = ready; }
    9595    private:

  • trunk/Source/WebCore/css/CSSCursorImageValue.h

    r202656 r205093  
    3333class SVGElement;
    3434
    35 class CSSCursorImageValue : public CSSValue {
     35class CSSCursorImageValue final : public CSSValue {
    3636public:
    3737    static Ref<CSSCursorImageValue> create(Ref<CSSValue>&& imageValue, bool hasHotSpot, const IntPoint& hotSpot)

  • trunk/Source/WebCore/css/CSSCustomPropertyValue.h

    r201290 r205093  
    3333namespace WebCore {
    3434
    35 class CSSCustomPropertyValue : public CSSValue {
     35class CSSCustomPropertyValue final : public CSSValue {
    3636public:
    3737    static Ref<CSSCustomPropertyValue> create(const AtomicString& name, Ref<CSSValue>&& value)

  • trunk/Source/WebCore/css/CSSFilterImageValue.h

    r201290 r205093  
    4444class StyleResolver;
    4545
    46 class CSSFilterImageValue : public CSSImageGeneratorValue {
     46class CSSFilterImageValue final : public CSSImageGeneratorValue {
    4747    friend class FilterSubimageObserverProxy;
    4848public:
    … …  
    9898
    9999        virtual ~FilterSubimageObserverProxy() { }
    100         void imageChanged(CachedImage*, const IntRect* = nullptr) override;
     100        void imageChanged(CachedImage*, const IntRect* = nullptr) final;
    101101        void setReady(bool ready) { m_ready = ready; }
    102102    private:

  • trunk/Source/WebCore/css/CSSFontFaceLoadEvent.h

    r201113 r205093  
    7575    DOMError* error() const { return m_error.get(); }
    7676
    77     EventInterface eventInterface() const override;
     77    EventInterface eventInterface() const final;
    7878
    7979private:

  • trunk/Source/WebCore/css/CSSFontFaceSrcValue.h

    r204466 r205093  
    3737class SVGFontFaceElement;
    3838
    39 class CSSFontFaceSrcValue : public CSSValue {
     39class CSSFontFaceSrcValue final : public CSSValue {
    4040public:
    4141    static Ref<CSSFontFaceSrcValue> create(const String& resource)

  • trunk/Source/WebCore/css/CSSFontFeatureValue.h

    r194496 r205093  
    3232namespace WebCore {
    3333
    34 class CSSFontFeatureValue : public CSSValue {
     34class CSSFontFeatureValue final : public CSSValue {
    3535public:
    3636    static Ref<CSSFontFeatureValue> create(FontFeatureTag&& tag, int value)

  • trunk/Source/WebCore/css/CSSFontSelector.h

    r204466 r205093  
    5757    virtual ~CSSFontSelector();
    5858   
    59     unsigned version() const override { return m_version; }
    60     unsigned uniqueId() const override { return m_uniqueId; }
     59    unsigned version() const final { return m_version; }
     60    unsigned uniqueId() const final { return m_uniqueId; }
    6161
    62     FontRanges fontRangesForFamily(const FontDescription&, const AtomicString&) override;
    63     size_t fallbackFontCount() override;
    64     RefPtr<Font> fallbackFontAt(const FontDescription&, size_t) override;
     62    FontRanges fontRangesForFamily(const FontDescription&, const AtomicString&) final;
     63    size_t fallbackFontCount() final;
     64    RefPtr<Font> fallbackFontAt(const FontDescription&, size_t) final;
    6565
    6666    void clearDocument();
    … …  
    7171
    7272    void fontLoaded();
    73     void fontCacheInvalidated() override;
     73    void fontCacheInvalidated() final;
    7474
    7575    bool isEmpty() const;
    7676
    77     void registerForInvalidationCallbacks(FontSelectorClient&) override;
    78     void unregisterForInvalidationCallbacks(FontSelectorClient&) override;
     77    void registerForInvalidationCallbacks(FontSelectorClient&) final;
     78    void unregisterForInvalidationCallbacks(FontSelectorClient&) final;
    7979
    8080    Document* document() const { return m_document; }
    … …  
    8989    void dispatchInvalidationCallbacks();
    9090
    91     void fontModified() override;
     91    void fontModified() final;
    9292
    9393    void beginLoadTimerFired();

  • trunk/Source/WebCore/css/CSSFontValue.h

    r201113 r205093  
    2929class CSSValueList;
    3030
    31 class CSSFontValue : public CSSValue {
     31class CSSFontValue final : public CSSValue {
    3232public:
    3333    static Ref<CSSFontValue> create()

  • trunk/Source/WebCore/css/CSSFunctionValue.h

    r201290 r205093  
    3434struct CSSParserValue;
    3535
    36 class CSSFunctionValue : public CSSValue {
     36class CSSFunctionValue final : public CSSValue {
    3737public:
    3838    static Ref<CSSFunctionValue> create(CSSParserFunction* function)

  • trunk/Source/WebCore/css/CSSGradientValue.h

    r202656 r205093  
    131131};
    132132
    133 class CSSLinearGradientValue : public CSSGradientValue {
     133class CSSLinearGradientValue final : public CSSGradientValue {
    134134public:
    135135
    … …  
    168168};
    169169
    170 class CSSRadialGradientValue : public CSSGradientValue {
     170class CSSRadialGradientValue final : public CSSGradientValue {
    171171public:
    172172    static Ref<CSSRadialGradientValue> create(CSSGradientRepeat repeat, CSSGradientType gradientType = CSSRadialGradient)

  • trunk/Source/WebCore/css/CSSGridAutoRepeatValue.h

    r199343 r205093  
    5050// future. That's why we're using a list, it's prepared for future changes and it also
    5151// allows us to keep the parsing algorithm almost intact.
    52 class CSSGridAutoRepeatValue : public CSSValueList {
     52class CSSGridAutoRepeatValue final : public CSSValueList {
    5353public:
    5454    static Ref<CSSGridAutoRepeatValue> create(CSSValueID id)

  • trunk/Source/WebCore/css/CSSGridLineNamesValue.h

    r204466 r205093  
    3737namespace WebCore {
    3838
    39 class CSSGridLineNamesValue : public CSSValueList {
     39class CSSGridLineNamesValue final : public CSSValueList {
    4040public:
    4141    static Ref<CSSGridLineNamesValue> create()

  • trunk/Source/WebCore/css/CSSGridTemplateAreasValue.h

    r199551 r205093  
    4040namespace WebCore {
    4141
    42 class CSSGridTemplateAreasValue : public CSSValue {
     42class CSSGridTemplateAreasValue final : public CSSValue {
    4343public:
    4444    static Ref<CSSGridTemplateAreasValue> create(const NamedGridAreaMap& gridAreaMap, size_t rowCount, size_t columnCount)

  • trunk/Source/WebCore/css/CSSImageSetValue.h

    r204566 r205093  
    3737struct ResourceLoaderOptions;
    3838
    39 class CSSImageSetValue : public CSSValueList {
     39class CSSImageSetValue final : public CSSValueList {
    4040public:
    4141

  • trunk/Source/WebCore/css/CSSImageValue.h

    r201290 r205093  
    3434struct ResourceLoaderOptions;
    3535
    36 class CSSImageValue : public CSSValue {
     36class CSSImageValue final : public CSSValue {
    3737public:
    3838    static Ref<CSSImageValue> create(const String& url) { return adoptRef(*new CSSImageValue(url)); }

  • trunk/Source/WebCore/css/CSSInheritedValue.h

    r194851 r205093  
    2727namespace WebCore {
    2828
    29 class CSSInheritedValue : public CSSValue {
     29class CSSInheritedValue final : public CSSValue {
    3030public:
    3131    String customCSSText() const;

  • trunk/Source/WebCore/css/CSSInitialValue.h

    r194851 r205093  
    2727namespace WebCore {
    2828
    29 class CSSInitialValue : public CSSValue {
     29class CSSInitialValue final : public CSSValue {
    3030public:
    3131    static Ref<CSSInitialValue> createExplicit()

  • trunk/Source/WebCore/css/CSSKeyframeRule.h

    r201818 r205093  
    3737class CSSKeyframesRule;
    3838
    39 class StyleKeyframe : public RefCounted<StyleKeyframe> {
     39class StyleKeyframe final : public RefCounted<StyleKeyframe> {
    4040    WTF_MAKE_FAST_ALLOCATED;
    4141public:
    … …  
    7373    virtual ~CSSKeyframeRule();
    7474
    75     String cssText() const override { return m_keyframe->cssText(); }
    76     void reattach(StyleRuleBase&) override;
     75    String cssText() const final { return m_keyframe->cssText(); }
     76    void reattach(StyleRuleBase&) final;
    7777
    7878    String keyText() const { return m_keyframe->keyText(); }
    … …  
    8484    CSSKeyframeRule(StyleKeyframe&, CSSKeyframesRule* parent);
    8585
    86     CSSRule::Type type() const override { return KEYFRAME_RULE; }
     86    CSSRule::Type type() const final { return KEYFRAME_RULE; }
    8787
    8888    Ref<StyleKeyframe> m_keyframe;

  • trunk/Source/WebCore/css/CSSKeyframesRule.h

    r203753 r205093  
    3939class CSSKeyframeRule;
    4040
    41 class StyleRuleKeyframes : public StyleRuleBase {
     41class StyleRuleKeyframes final : public StyleRuleBase {
    4242public:
    4343    static Ref<StyleRuleKeyframes> create() { return adoptRef(*new StyleRuleKeyframes()); }
    … …  
    7272    virtual ~CSSKeyframesRule();
    7373
    74     CSSRule::Type type() const override { return KEYFRAMES_RULE; }
    75     String cssText() const override;
    76     void reattach(StyleRuleBase&) override;
     74    CSSRule::Type type() const final { return KEYFRAMES_RULE; }
     75    String cssText() const final;
     76    void reattach(StyleRuleBase&) final;
    7777
    7878    String name() const { return m_keyframesRule->name(); }

  • trunk/Source/WebCore/css/CSSLineBoxContainValue.h

    r204466 r205093  
    3939
    4040// Used for text-CSSLineBoxContain and box-CSSLineBoxContain
    41 class CSSLineBoxContainValue : public CSSValue {
     41class CSSLineBoxContainValue final : public CSSValue {
    4242public:
    4343    static Ref<CSSLineBoxContainValue> create(LineBoxContain value)

  • trunk/Source/WebCore/css/CSSNamedImageValue.h

    r200626 r205093  
    3535class Document;
    3636
    37 class CSSNamedImageValue : public CSSImageGeneratorValue {
     37class CSSNamedImageValue final : public CSSImageGeneratorValue {
    3838public:
    3939    static Ref<CSSNamedImageValue> create(const String& name)

  • trunk/Source/WebCore/css/CSSPrimitiveValue.h

    r204717 r205093  
    7878}
    7979
    80 class CSSPrimitiveValue : public CSSValue {
     80class CSSPrimitiveValue final : public CSSValue {
    8181public:
    8282    enum UnitTypes {

  • trunk/Source/WebCore/css/CSSReflectValue.h

    r201318 r205093  
    3434class CSSPrimitiveValue;
    3535
    36 class CSSReflectValue : public CSSValue {
     36class CSSReflectValue final : public CSSValue {
    3737public:
    3838    static Ref<CSSReflectValue> create(Ref<CSSPrimitiveValue>&& direction, Ref<CSSPrimitiveValue>&& offset, RefPtr<CSSValue>&& mask)

  • trunk/Source/WebCore/css/CSSRevertValue.h

    r194851 r205093  
    3232namespace WebCore {
    3333
    34 class CSSRevertValue : public CSSValue {
     34class CSSRevertValue final : public CSSValue {
    3535public:
    3636    String customCSSText() const;

  • trunk/Source/WebCore/css/CSSRuleList.h

    r204466 r205093  
    5151    static Ref<StaticCSSRuleList> create() { return adoptRef(*new StaticCSSRuleList); }
    5252
    53     void ref() override { ++m_refCount; }
    54     void deref() override;
     53    void ref() final { ++m_refCount; }
     54    void deref() final;
    5555
    5656    Vector<RefPtr<CSSRule>>& rules() { return m_rules; }
    5757   
    58     CSSStyleSheet* styleSheet() const override { return nullptr; }
     58    CSSStyleSheet* styleSheet() const final { return nullptr; }
    5959
    6060private:   
    … …  
    6262    ~StaticCSSRuleList();
    6363
    64     unsigned length() const override { return m_rules.size(); }
    65     CSSRule* item(unsigned index) const override { return index < m_rules.size() ? m_rules[index].get() : nullptr; }
     64    unsigned length() const final { return m_rules.size(); }
     65    CSSRule* item(unsigned index) const final { return index < m_rules.size() ? m_rules[index].get() : nullptr; }
    6666
    6767    Vector<RefPtr<CSSRule>> m_rules;
    … …  
    7878    }
    7979   
    80     void ref() override { m_rule.ref(); }
    81     void deref() override { m_rule.deref(); }
     80    void ref() final { m_rule.ref(); }
     81    void deref() final { m_rule.deref(); }
    8282
    8383private:
    84     unsigned length() const override { return m_rule.length(); }
    85     CSSRule* item(unsigned index) const override { return m_rule.item(index); }
    86     CSSStyleSheet* styleSheet() const override { return m_rule.parentStyleSheet(); }
     84    unsigned length() const final { return m_rule.length(); }
     85    CSSRule* item(unsigned index) const final { return m_rule.item(index); }
     86    CSSStyleSheet* styleSheet() const final { return m_rule.parentStyleSheet(); }
    8787   
    8888    Rule& m_rule;

  • trunk/Source/WebCore/css/CSSSegmentedFontFace.h

    r201570 r205093  
    5555
    5656    // CSSFontFace::Client needs to be able to be held in a RefPtr.
    57     void ref() override { RefCounted<CSSSegmentedFontFace>::ref(); }
    58     void deref() override { RefCounted<CSSSegmentedFontFace>::deref(); }
     57    void ref() final { RefCounted<CSSSegmentedFontFace>::ref(); }
     58    void deref() final { RefCounted<CSSSegmentedFontFace>::deref(); }
    5959
    6060private:
    6161    CSSSegmentedFontFace();
    62     void fontLoaded(CSSFontFace&) override;
     62    void fontLoaded(CSSFontFace&) final;
    6363
    6464    HashMap<FontDescriptionKey, FontRanges, FontDescriptionKeyHash, WTF::SimpleClassHashTraits<FontDescriptionKey>> m_cache;

  • trunk/Source/WebCore/css/CSSShadowValue.h

    r204466 r205093  
    3030
    3131// Used for text-shadow and box-shadow
    32 class CSSShadowValue : public CSSValue {
     32class CSSShadowValue final : public CSSValue {
    3333public:
    3434    static Ref<CSSShadowValue> create(RefPtr<CSSPrimitiveValue>&& x,

  • trunk/Source/WebCore/css/CSSStyleSheet.cpp

    r203740 r205093  
    4949namespace WebCore {
    5050
    51 class StyleSheetCSSRuleList : public CSSRuleList {
     51class StyleSheetCSSRuleList final : public CSSRuleList {
    5252public:
    5353    StyleSheetCSSRuleList(CSSStyleSheet* sheet) : m_styleSheet(sheet) { }
    5454   
    5555private:
    56     void ref() override { m_styleSheet->ref(); }
    57     void deref() override { m_styleSheet->deref(); }
    58 
    59     unsigned length() const override { return m_styleSheet->length(); }
    60     CSSRule* item(unsigned index) const override { return m_styleSheet->item(index); }
    61 
    62     CSSStyleSheet* styleSheet() const override { return m_styleSheet; }
     56    void ref() final { m_styleSheet->ref(); }
     57    void deref() final { m_styleSheet->deref(); }
     58
     59    unsigned length() const final { return m_styleSheet->length(); }
     60    CSSRule* item(unsigned index) const final { return m_styleSheet->item(index); }
     61
     62    CSSStyleSheet* styleSheet() const final { return m_styleSheet; }
    6363
    6464    CSSStyleSheet* m_styleSheet;

  • trunk/Source/WebCore/css/CSSStyleSheet.h

    r204717 r205093  
    5555    virtual ~CSSStyleSheet();
    5656
    57     CSSStyleSheet* parentStyleSheet() const override;
    58     Node* ownerNode() const override { return m_ownerNode; }
    59     MediaList* media() const override;
    60     String href() const override;
    61     String title() const override { return m_title; }
    62     bool disabled() const override { return m_isDisabled; }
    63     void setDisabled(bool) override;
     57    CSSStyleSheet* parentStyleSheet() const final;
     58    Node* ownerNode() const final { return m_ownerNode; }
     59    MediaList* media() const final;
     60    String href() const final;
     61    String title() const final { return m_title; }
     62    bool disabled() const final { return m_isDisabled; }
     63    void setDisabled(bool) final;
    6464   
    6565    WEBCORE_EXPORT RefPtr<CSSRuleList> cssRules();
    … …  
    7777    CSSRule* item(unsigned index);
    7878
    79     void clearOwnerNode() override;
    80     CSSImportRule* ownerRule() const override { return m_ownerRule; }
    81     URL baseURL() const override;
    82     bool isLoading() const override;
     79    void clearOwnerNode() final;
     80    CSSImportRule* ownerRule() const final { return m_ownerRule; }
     81    URL baseURL() const final;
     82    bool isLoading() const final;
    8383   
    8484    void clearOwnerRule() { m_ownerRule = 0; }
    … …  
    127127    CSSStyleSheet(Ref<StyleSheetContents>&&, Node* ownerNode, const TextPosition& startPosition, bool isInlineStylesheet);
    128128
    129     bool isCSSStyleSheet() const override { return true; }
    130     String type() const override { return ASCIILiteral("text/css"); }
     129    bool isCSSStyleSheet() const final { return true; }
     130    String type() const final { return ASCIILiteral("text/css"); }
    131131
    132132    bool canAccessRules() const;

  • trunk/Source/WebCore/css/CSSSupportsRule.h

    r197563 r205093  
    4646    virtual ~CSSSupportsRule() { }
    4747
    48     String cssText() const override;
     48    String cssText() const final;
    4949
    5050    String conditionText() const;
    … …  
    5353    CSSSupportsRule(StyleRuleSupports&, CSSStyleSheet*);
    5454
    55     CSSRule::Type type() const override { return SUPPORTS_RULE; }
     55    CSSRule::Type type() const final { return SUPPORTS_RULE; }
    5656};
    5757

  • trunk/Source/WebCore/css/CSSTimingFunctionValue.h

    r204466 r205093  
    3131namespace WebCore {
    3232
    33 class CSSCubicBezierTimingFunctionValue : public CSSValue {
     33class CSSCubicBezierTimingFunctionValue final : public CSSValue {
    3434public:
    3535    static Ref<CSSCubicBezierTimingFunctionValue> create(double x1, double y1, double x2, double y2)
    … …  
    6363};
    6464
    65 class CSSStepsTimingFunctionValue : public CSSValue {
     65class CSSStepsTimingFunctionValue final : public CSSValue {
    6666public:
    6767    static Ref<CSSStepsTimingFunctionValue> create(int steps, bool stepAtStart)
    … …  
    8989};
    9090
    91 class CSSSpringTimingFunctionValue : public CSSValue {
     91class CSSSpringTimingFunctionValue final : public CSSValue {
    9292public:
    9393    static Ref<CSSSpringTimingFunctionValue> create(double mass, double stiffness, double damping, double initialVelocity)

  • trunk/Source/WebCore/css/CSSUnicodeRangeValue.h

    r204466 r205093  
    3131namespace WebCore {
    3232
    33 class CSSUnicodeRangeValue : public CSSValue {
     33class CSSUnicodeRangeValue final : public CSSValue {
    3434public:
    3535    static Ref<CSSUnicodeRangeValue> create(UChar32 from, UChar32 to)

  • trunk/Source/WebCore/css/CSSUnknownRule.h

    r197563 r205093  
    3636    virtual ~CSSUnknownRule() { }
    3737
    38     String cssText() const override { return String(); }
    39     void reattach(StyleRuleBase&) override { }
     38    String cssText() const final { return String(); }
     39    void reattach(StyleRuleBase&) final { }
    4040
    4141private:
    42     CSSRule::Type type() const override { return UNKNOWN_RULE; }
     42    CSSRule::Type type() const final { return UNKNOWN_RULE; }
    4343};
    4444

  • trunk/Source/WebCore/css/CSSUnsetValue.h

    r194851 r205093  
    3232namespace WebCore {
    3333
    34 class CSSUnsetValue : public CSSValue {
     34class CSSUnsetValue final : public CSSValue {
    3535public:
    3636    String customCSSText() const;

  • trunk/Source/WebCore/css/CSSValue.cpp

    r204566 r205093  
    7979COMPILE_ASSERT(sizeof(CSSValue) == sizeof(SameSizeAsCSSValue), CSS_value_should_stay_small);
    8080
    81 class TextCloneCSSValue : public CSSValue {
     81class TextCloneCSSValue final : public CSSValue {
    8282public:
    8383    static Ref<TextCloneCSSValue> create(ClassType classType, const String& text)

  • trunk/Source/WebCore/css/CSSVariableDependentValue.h

    r201290 r205093  
    3333namespace WebCore {
    3434
    35 class CSSVariableDependentValue : public CSSValue {
     35class CSSVariableDependentValue final : public CSSValue {
    3636public:
    3737    static Ref<CSSVariableDependentValue> create(Ref<CSSValueList>&& valueList, CSSPropertyID propId)

  • trunk/Source/WebCore/css/CSSVariableValue.h

    r191128 r205093  
    3535struct CSSParserVariable;
    3636
    37 class CSSVariableValue : public CSSValue {
     37class CSSVariableValue final : public CSSValue {
    3838public:
    3939    static Ref<CSSVariableValue> create(CSSParserVariable* Variable)

  • trunk/Source/WebCore/css/Counter.h

    r201290 r205093  
    2626namespace WebCore {
    2727
    28 class Counter : public RefCounted<Counter> {
     28class Counter final : public RefCounted<Counter> {
    2929public:
    3030    static Ref<Counter> create(Ref<CSSPrimitiveValue>&& identifier, Ref<CSSPrimitiveValue>&& listStyle, Ref<CSSPrimitiveValue>&& separator)

  • trunk/Source/WebCore/css/DOMCSSNamespace.h

    r204952 r205093  
    3535namespace WebCore {
    3636
    37 class DOMCSSNamespace : public RefCounted<DOMCSSNamespace> {
     37class DOMCSSNamespace final : public RefCounted<DOMCSSNamespace> {
    3838public:
    3939    static bool supports(const String& property, const String& value);

  • trunk/Source/WebCore/css/DashboardRegion.h

    r177733 r205093  
    2828namespace WebCore {
    2929
    30 class DashboardRegion : public RectBase, public RefCounted<DashboardRegion> {
     30class DashboardRegion final : public RectBase, public RefCounted<DashboardRegion> {
    3131public:
    3232    static Ref<DashboardRegion> create() { return adoptRef(*new DashboardRegion); }

  • trunk/Source/WebCore/css/LengthRepeat.h

    r185238 r205093  
    3535namespace WebCore {
    3636
    37 class LengthRepeat : public RefCounted<LengthRepeat> {
     37class LengthRepeat final : public RefCounted<LengthRepeat> {
    3838public:
    3939    static Ref<LengthRepeat> create(PassRefPtr<CSSValue> interval) { return adoptRef(*new LengthRepeat(interval)); }

  • trunk/Source/WebCore/css/MediaList.h

    r204717 r205093  
    3636using ExceptionCode = int;
    3737
    38 class MediaQuerySet : public RefCounted<MediaQuerySet> {
     38class MediaQuerySet final : public RefCounted<MediaQuerySet> {
    3939public:
    4040    static Ref<MediaQuerySet> create()
    … …  
    8282};
    8383
    84 class MediaList : public RefCounted<MediaList> {
     84class MediaList final : public RefCounted<MediaList> {
    8585public:
    8686    static Ref<MediaList> create(MediaQuerySet* mediaQueries, CSSStyleSheet* parentSheet)

  • trunk/Source/WebCore/css/MediaQueryList.h

    r201441 r205093  
    3636// will be called whenever the value of the query changes.
    3737
    38 class MediaQueryList : public RefCounted<MediaQueryList> {
     38class MediaQueryList final : public RefCounted<MediaQueryList> {
    3939public:
    4040    static Ref<MediaQueryList> create(MediaQueryMatcher&, Ref<MediaQuerySet>&&, bool);

  • trunk/Source/WebCore/css/MediaQueryMatcher.h

    r201441 r205093  
    3939// The listeners must be called in the order in which they were added.
    4040
    41 class MediaQueryMatcher : public RefCounted<MediaQueryMatcher> {
     41class MediaQueryMatcher final : public RefCounted<MediaQueryMatcher> {
    4242public:
    4343    static Ref<MediaQueryMatcher> create(Document& document) { return adoptRef(*new MediaQueryMatcher(document)); }

  • trunk/Source/WebCore/css/Pair.h

    r201113 r205093  
    3131// border-radius and background-size, but (FIXME) border-spacing and background-position could be converted over to use
    3232// it (eliminating some extra -webkit- internal properties).
    33 class Pair : public RefCounted<Pair> {
     33class Pair final : public RefCounted<Pair> {
    3434public:
    3535    enum class IdenticalValueEncoding {

  • trunk/Source/WebCore/css/PropertySetCSSStyleDeclaration.h

    r197566 r205093  
    9292    void clearParentRule() { m_parentRule = 0; }
    9393   
    94     void ref() override;
    95     void deref() override;
     94    void ref() final;
     95    void deref() final;
    9696
    9797    void reattach(MutableStyleProperties&);
    … …  
    100100    StyleRuleCSSStyleDeclaration(MutableStyleProperties&, CSSRule&);
    101101
    102     CSSStyleSheet* parentStyleSheet() const override;
     102    CSSStyleSheet* parentStyleSheet() const final;
    103103
    104     CSSRule* parentRule() const override { return m_parentRule;  }
     104    CSSRule* parentRule() const final { return m_parentRule;  }
    105105
    106     bool willMutate() override WARN_UNUSED_RETURN;
    107     void didMutate(MutationType) override;
     106    bool willMutate() final WARN_UNUSED_RETURN;
     107    void didMutate(MutationType) final;
    108108
    109109    unsigned m_refCount;
    … …  
    121121   
    122122private:
    123     CSSStyleSheet* parentStyleSheet() const override;
    124     StyledElement* parentElement() const override { return m_parentElement; }
    125     void clearParentElement() override { m_parentElement = 0; }
     123    CSSStyleSheet* parentStyleSheet() const final;
     124    StyledElement* parentElement() const final { return m_parentElement; }
     125    void clearParentElement() final { m_parentElement = 0; }
    126126
    127     void didMutate(MutationType) override;
     127    void didMutate(MutationType) final;
    128128
    129129    StyledElement* m_parentElement;

  • trunk/Source/WebCore/css/RGBColor.h

    r204717 r205093  
    3434class CSSPrimitiveValue;
    3535
    36 class RGBColor : public RefCounted<RGBColor> {
     36class RGBColor final : public RefCounted<RGBColor> {
    3737public:
    3838    static Ref<RGBColor> create(unsigned rgbColor);

  • trunk/Source/WebCore/css/Rect.h

    r201290 r205093  
    6666};
    6767
    68 class Rect : public RectBase, public RefCounted<Rect> {
     68class Rect final : public RectBase, public RefCounted<Rect> {
    6969public:
    7070    static Ref<Rect> create() { return adoptRef(*new Rect); }
    … …  
    8686};
    8787
    88 class Quad : public RectBase, public RefCounted<Quad> {
     88class Quad final : public RectBase, public RefCounted<Quad> {
    8989public:
    9090    static Ref<Quad> create() { return adoptRef(*new Quad); }

  • trunk/Source/WebCore/css/StyleMedia.h

    r185238 r205093  
    3636class Frame;
    3737
    38 class StyleMedia : public RefCounted<StyleMedia>, public DOMWindowProperty {
     38class StyleMedia final : public RefCounted<StyleMedia>, public DOMWindowProperty {
    3939public:
    4040    static Ref<StyleMedia> create(Frame* frame) { return adoptRef(*new StyleMedia(frame)); }

  • trunk/Source/WebCore/css/StyleProperties.h

    r204052 r205093  
    155155};
    156156
    157 class ImmutableStyleProperties : public StyleProperties {
     157class ImmutableStyleProperties final : public StyleProperties {
    158158public:
    159159    WEBCORE_EXPORT ~ImmutableStyleProperties();
    … …  
    185185}
    186186
    187 class MutableStyleProperties : public StyleProperties {
     187class MutableStyleProperties final : public StyleProperties {
    188188public:
    189189    WEBCORE_EXPORT static Ref<MutableStyleProperties> create(CSSParserMode = CSSQuirksMode);

  • trunk/Source/WebCore/css/StyleRule.h

    r201318 r205093  
    100100};
    101101
    102 class StyleRule : public StyleRuleBase {
     102class StyleRule final : public StyleRuleBase {
    103103    WTF_MAKE_FAST_ALLOCATED;
    104104public:
    … …  
    134134};
    135135
    136 class StyleRuleFontFace : public StyleRuleBase {
     136class StyleRuleFontFace final : public StyleRuleBase {
    137137public:
    138138    static Ref<StyleRuleFontFace> create(Ref<StyleProperties>&& properties) { return adoptRef(*new StyleRuleFontFace(WTFMove(properties))); }
    … …  
    153153};
    154154
    155 class StyleRulePage : public StyleRuleBase {
     155class StyleRulePage final : public StyleRuleBase {
    156156public:
    157157    static Ref<StyleRulePage> create(Ref<StyleProperties>&& properties) { return adoptRef(*new StyleRulePage(WTFMove(properties))); }
    … …  
    191191};
    192192
    193 class StyleRuleMedia : public StyleRuleGroup {
     193class StyleRuleMedia final : public StyleRuleGroup {
    194194public:
    195195    static Ref<StyleRuleMedia> create(Ref<MediaQuerySet>&& media, Vector<RefPtr<StyleRuleBase>>& adoptRules)
    … …  
    209209};
    210210
    211 class StyleRuleSupports : public StyleRuleGroup {
     211class StyleRuleSupports final : public StyleRuleGroup {
    212212public:
    213213    static Ref<StyleRuleSupports> create(const String& conditionText, bool conditionIsSupported, Vector<RefPtr<StyleRuleBase>>& adoptRules)
    … …  
    228228};
    229229
    230 class StyleRuleRegion : public StyleRuleGroup {
     230class StyleRuleRegion final : public StyleRuleGroup {
    231231public:
    232232    static Ref<StyleRuleRegion> create(Vector<std::unique_ptr<CSSParserSelector>>* selectors, Vector<RefPtr<StyleRuleBase>>& adoptRules)
    … …  
    247247
    248248#if ENABLE(CSS_DEVICE_ADAPTATION)
    249 class StyleRuleViewport : public StyleRuleBase {
     249class StyleRuleViewport final : public StyleRuleBase {
    250250public:
    251251    static Ref<StyleRuleViewport> create(Ref<StyleProperties>&& properties) { return adoptRef(*new StyleRuleViewport(WTFMove(properties))); }

  • trunk/Source/WebCore/css/StyleRuleImport.h

    r201318 r205093  
    3434class StyleSheetContents;
    3535
    36 class StyleRuleImport : public StyleRuleBase {
     36class StyleRuleImport final : public StyleRuleBase {
    3737    WTF_MAKE_FAST_ALLOCATED;
    3838public:
    … …  
    5656    // NOTE: We put the CachedStyleSheetClient in a member instead of inheriting from it
    5757    // to avoid adding a vptr to StyleRuleImport.
    58     class ImportedStyleSheetClient : public CachedStyleSheetClient {
     58class ImportedStyleSheetClient final : public CachedStyleSheetClient {
    5959    public:
    6060        ImportedStyleSheetClient(StyleRuleImport* ownerRule) : m_ownerRule(ownerRule) { }

  • trunk/Source/WebCore/css/StyleSheetContents.h

    r201318 r205093  
    4343class StyleRuleImport;
    4444
    45 class StyleSheetContents : public RefCounted<StyleSheetContents> {
     45class StyleSheetContents final : public RefCounted<StyleSheetContents> {
    4646public:
    4747    static Ref<StyleSheetContents> create(const CSSParserContext& context = CSSParserContext(CSSStrictMode))

  • trunk/Source/WebCore/css/StyleSheetList.h

    r204717 r205093  
    3131class StyleSheet;
    3232
    33 class StyleSheetList : public RefCounted<StyleSheetList> {
     33class StyleSheetList final : public RefCounted<StyleSheetList> {
    3434public:
    3535    static Ref<StyleSheetList> create(Document* document) { return adoptRef(*new StyleSheetList(document)); }

  • trunk/Source/WebCore/css/ViewportStyleResolver.h

    r185238 r205093  
    4545class StyleRuleViewport;
    4646
    47 class ViewportStyleResolver : public RefCounted<ViewportStyleResolver> {
     47class ViewportStyleResolver final : public RefCounted<ViewportStyleResolver> {
    4848public:
    4949    static Ref<ViewportStyleResolver> create(Document* document)

  • trunk/Source/WebCore/css/WebKitCSSFilterValue.h

    r204466 r205093  
    3131namespace WebCore {
    3232
    33 class WebKitCSSFilterValue : public CSSValueList {
     33class WebKitCSSFilterValue final : public CSSValueList {
    3434public:
    3535    // NOTE: these have to match the values in the IDL

  • trunk/Source/WebCore/css/WebKitCSSRegionRule.h

    r197563 r205093  
    4444    static Ref<WebKitCSSRegionRule> create(StyleRuleRegion& rule, CSSStyleSheet* sheet) { return adoptRef(*new WebKitCSSRegionRule(rule, sheet)); }
    4545
    46     CSSRule::Type type() const override { return WEBKIT_REGION_RULE; }
    47     String cssText() const override;
     46    CSSRule::Type type() const final { return WEBKIT_REGION_RULE; }
     47    String cssText() const final;
    4848
    4949private:

  • trunk/Source/WebCore/css/WebKitCSSTransformValue.h

    r204466 r205093  
    3030namespace WebCore {
    3131
    32 class WebKitCSSTransformValue : public CSSValueList {
     32class WebKitCSSTransformValue final : public CSSValueList {
    3333public:
    3434    // NOTE: these have to match the values in the IDL

  • trunk/Source/WebCore/css/WebKitCSSViewportRule.h

    r197563 r205093  
    5050    virtual ~WebKitCSSViewportRule();
    5151
    52     String cssText() const override;
    53     void reattach(StyleRuleBase&) override;
     52    String cssText() const final;
     53    void reattach(StyleRuleBase&) final;
    5454
    5555    CSSStyleDeclaration& style();
    … …  
    5858    WebKitCSSViewportRule(StyleRuleViewport&, CSSStyleSheet*);
    5959
    60     CSSRule::Type type() const override { return WEBKIT_VIEWPORT_RULE; }
     60    CSSRule::Type type() const final { return WEBKIT_VIEWPORT_RULE; }
    6161
    6262    Ref<StyleRuleViewport> m_viewportRule;
Note: See TracChangeset for help on using the changeset viewer.