Changeset 214300 in webkit for trunk/Source/JavaScriptCore/assembler

Timestamp:

Mar 23, 2017, 2:25:06 AM (8 years ago)

Author:

[email protected]

Message:

[jsc] Add MacroAssemblerMIPS::storeFence()
​https://bugs.webkit.org/show_bug.cgi?id=169705

Patch by Guillaume Emont <​[email protected]> on 2017-03-23
Reviewed by Yusuke Suzuki.

There doesn't seem to be anything more fine grained than "sync" that
guarantees that all memory operations following it are going to happen
after all stores before it, so we just use sync.

• assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::sync): Added a FIXME about SYNC_MB.

• assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::storeFence): Added.

Location:

trunk/Source/JavaScriptCore/assembler

Files:

• MIPSAssembler.h (modified) (1 diff)
• MacroAssemblerMIPS.h (modified) (1 diff)

trunk/Source/JavaScriptCore/assembler/MIPSAssembler.h

@@ -208 +208 @@
     void sync()
     {
+        // FIXME: https://bugs.webkit.org/show_bug.cgi?id=169984
+        // We might get a performance improvements by using SYNC_MB in some or
+        // all cases.
         emitInst(0x0000000f);
     }

trunk/Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h

@@ -2976 +2976 @@
     }
 
+    void storeFence()
+    {
+        m_assembler.sync();
+    }
+
     void abortWithReason(AbortReason reason, intptr_t misc)
     {