Changeset 215318 in webkit for trunk/Source/JavaScriptCore/tools

Timestamp:

Apr 13, 2017, 7:17:00 AM (8 years ago)

Author:

Yusuke Suzuki

Message:

[JSC] Use proper ifdef guard for code using MachineContext
​https://bugs.webkit.org/show_bug.cgi?id=170800

Reviewed by Carlos Alberto Lopez Perez.

Source/JavaScriptCore:

This patch drops MachineContext use if it is not available.
This situation can be considered like, building WebKit with musl.
In that case, we simply disable features that rely on MachineContext.
Examples are wasm fast memory, sampling profiler, and code profiling.

• runtime/Options.cpp:

(JSC::overrideDefaults):

• tools/CodeProfiling.cpp:

(JSC::CodeProfiling::begin):
(JSC::CodeProfiling::end):
Previously, PLATFORM(GTK) is excluded. But it is not obvious why it is excluded.
This patch just includes such platforms.

• wasm/WasmFaultSignalHandler.cpp:

(JSC::Wasm::enableFastMemory):

Source/WTF:

SamplingProfiler and FastMemory rely on MachineContext feature.

• wtf/Platform.h:

File:

• trunk/Source/JavaScriptCore/tools/CodeProfiling.cpp (modified) (5 diffs)

trunk/Source/JavaScriptCore/tools/CodeProfiling.cpp

@@ -35 +35 @@
 #endif
 
-#if OS(LINUX) || OS(DARWIN)
+#if HAVE(MACHINE_CONTEXT)
 #include <sys/time.h>
 #endif
@@ -50 +50 @@
 #endif
 
-#if (OS(DARWIN) && !PLATFORM(GTK) && CPU(X86_64)) || (OS(LINUX) && CPU(X86))
+#if HAVE(MACHINE_CONTEXT)
 // Helper function to start & stop the timer.
 // Presently we're using the wall-clock timer, since this seems to give the best results.
@@ -68 +68 @@
 #endif
 
-#if (OS(DARWIN) && !PLATFORM(GTK) && CPU(X86_64)) || (OS(LINUX) && CPU(X86))
+#if HAVE(MACHINE_CONTEXT)
 static void profilingTimer(int, siginfo_t*, void* uap)
 {
@@ -137 +137 @@
         return;
 
-#if (OS(DARWIN) && !PLATFORM(GTK) && CPU(X86_64)) || (OS(LINUX) && CPU(X86))
+#if HAVE(MACHINE_CONTEXT)
     // Regsiter a signal handler & itimer.
     struct sigaction action;
@@ -161 +161 @@
         return;
 
-#if (OS(DARWIN) && !PLATFORM(GTK) && CPU(X86_64)) || (OS(LINUX) && CPU(X86))
+#if HAVE(MACHINE_CONTEXT)
     // Stop profiling
     setProfileTimer(0);