Changeset 216049 in webkit for trunk/Source/JavaScriptCore/disassembler

Timestamp:

May 1, 2017, 6:00:35 PM (8 years ago)

Author:

[email protected]

Message:

Stop using sprintf() in JavaScriptCore debugger
<​https://webkit.org/b/171512>

Reviewed by Keith Miller.

Source/JavaScriptCore:

• disassembler/udis86/udis86.c:

(ud_insn_hex): Switch from sprintf() to snprintf().

Tools:

• Scripts/webkitpy/style/checker.py:

(_PATH_RULES_SPECIFIER): Ignore some formatting checkers since
Source/JavaScriptCore/disassembler/udis86/ is generated code.

File:

• trunk/Source/JavaScriptCore/disassembler/udis86/udis86.c (modified) (1 diff)

trunk/Source/JavaScriptCore/disassembler/udis86/udis86.c

@@ -168 +168 @@
     unsigned int i;
     const unsigned char *src_ptr = ud_insn_ptr(u);
-    char* src_hex;
-    src_hex = (char*) u->insn_hexcode;
+    char* src_hex = (char*) u->insn_hexcode;
+    char* const src_hex_base = src_hex;
     /* for each byte used to decode instruction */
     for (i = 0; i < ud_insn_len(u) && i < sizeof(u->insn_hexcode) / 2;
          ++i, ++src_ptr) {
-      sprintf(src_hex, "%02x", *src_ptr & 0xFF);
+      snprintf(src_hex, sizeof(u->insn_hexcode) - (src_hex - src_hex_base), "%02x", *src_ptr & 0xFF);
       src_hex += 2;
     }