Changeset 2168 in webkit for trunk/JavaScriptCore/kjs

Timestamp:

Sep 25, 2002, 3:46:33 PM (23 years ago)

Author:

hyatt

Message:

Fix the impls of min/max to not use +inf/-inf when you have
arguments. Technically there's still a bug here for the no
argument case, probably caused by a screwup when +inf/-inf are
converted to doubles.

• kjs/math_object.cpp: (MathFuncImp::call):

File:

• trunk/JavaScriptCore/kjs/math_object.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/math_object.cpp

@@ -183 +183 @@
       if ( isNaN( val ) )
       {
-        result = NaN;
+            result = NaN;
         break;
       }
-      if ( val > result )
+      // Comparing a number to negative infinity doesn't work.  
+      // -dwh
+      if ( k == 0 || val > result )
         result = val;
     }
@@ -201 +203 @@
         break;
       }
-      if ( val < result )
+      // Comparing a number to positive infinity doesn't work.  
+      // -dwh
+      if ( k == 0 || val < result )
         result = val;
     }