Changeset 221546 in webkit for trunk/Source/JavaScriptCore/API

Timestamp:

Sep 2, 2017, 9:42:51 PM (8 years ago)

Author:

[email protected]

Message:

Need an API to get the global context from JSObjectRef
​https://bugs.webkit.org/show_bug.cgi?id=176291

Reviewed by Saam Barati.

Very simple additional API, starting off as SPI on principle.

• API/JSObjectRef.cpp:

(JSObjectGetGlobalContext):

• API/JSObjectRefPrivate.h:
• API/tests/testapi.c:

(main):

Location:

trunk/Source/JavaScriptCore/API

Files:

• JSObjectRef.cpp (modified) (1 diff)
• JSObjectRefPrivate.h (modified) (1 diff)
• tests/testapi.c (modified) (1 diff)

trunk/Source/JavaScriptCore/API/JSObjectRef.cpp

@@ -692 +692 @@
     return toRef(result);
 }
+
+JSGlobalContextRef JSObjectGetGlobalContext(JSObjectRef objectRef)
+{
+    JSObject* object = toJS(objectRef);
+    if (!object)
+        return nullptr;
+    return reinterpret_cast<JSGlobalContextRef>(object->globalObject()->globalExec());
+}
+

trunk/Source/JavaScriptCore/API/JSObjectRefPrivate.h

@@ -70 +70 @@
 JS_EXPORT JSObjectRef JSObjectGetProxyTarget(JSObjectRef);
 
+JS_EXPORT JSGlobalContextRef JSObjectGetGlobalContext(JSObjectRef object);
+    
 #ifdef __cplusplus
 }

trunk/Source/JavaScriptCore/API/tests/testapi.c

@@ -2041 +2041 @@
     }
 
+    // Check JSObjectGetGlobalContext
+    {
+        JSGlobalContextRef context = JSGlobalContextCreateInGroup(NULL, NULL);
+        {
+            JSObjectRef globalObject = JSContextGetGlobalObject(context);
+            assertTrue(JSObjectGetGlobalContext(globalObject) == context, "global object context is correct");
+            JSObjectRef object = JSObjectMake(context, NULL, NULL);
+            assertTrue(JSObjectGetGlobalContext(object) == context, "regular object context is correct");
+            JSStringRef returnFunctionSource = JSStringCreateWithUTF8CString("return this;");
+            JSObjectRef theFunction = JSObjectMakeFunction(context, NULL, 0, NULL, returnFunctionSource, NULL, 1, NULL);
+            assertTrue(JSObjectGetGlobalContext(theFunction) == context, "function object context is correct");
+            assertTrue(JSObjectGetGlobalContext(NULL) == NULL, "NULL object context is NULL");
+            JSStringRelease(returnFunctionSource);
+        }
+        JSGlobalContextRelease(context);
+    }
     failed = testTypedArrayCAPI() || failed;
     failed = testExecutionTimeLimit() || failed;