Changeset 222356 in webkit for trunk/Source/JavaScriptCore


Ignore:
Timestamp:
Sep 21, 2017, 3:32:49 PM (8 years ago)
Author:
[email protected]
Message:

Web Inspector: Remove support for CSS Regions
​https://bugs.webkit.org/show_bug.cgi?id=177287

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-21
Reviewed by Matt Baker.

Source/JavaScriptCore:

  • inspector/protocol/CSS.json:
  • inspector/protocol/OverlayTypes.json:

Source/WebCore:

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getNamedFlowCollection): Deleted.

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorOverlay.cpp:

(WebCore::buildRendererHighlight):
(WebCore::buildNodeHighlight):
(WebCore::InspectorOverlay::getHighlight const):
(WebCore::buildArrayForRendererFragments):
(WebCore::buildQuadObjectForCSSRegionContentClip): Deleted.

  • inspector/InspectorOverlayPage.js:

(_createElementTitle):
(_drawElementTitle):
(_drawFragmentHighlight):
(drawNodeHighlight):
(_drawRegionNumber): Deleted.
(_quadMidPoint): Deleted.
(_drawRegionLink): Deleted.
(_drawRegionsHighlight): Deleted.

Source/WebInspectorUI:

  • UserInterface/Protocol/CSSObserver.js:

(WI.CSSObserver.prototype.namedFlowCreated):
(WI.CSSObserver.prototype.namedFlowRemoved):
(WI.CSSObserver.prototype.regionLayoutUpdated):
(WI.CSSObserver.prototype.regionOversetChanged):
(WI.CSSObserver.prototype.registeredNamedFlowContentElement):
(WI.CSSObserver.prototype.unregisteredNamedFlowContentElement):
Leave observer functions in for older backends that will send
these messages, but we just ignore them.

  • UserInterface/Base/Main.js:
  • UserInterface/Controllers/DOMTreeManager.js:

(WI.DOMTreeManager):
(WI.DOMTreeManager.prototype._unbind):
(WI.DOMTreeManager._flowPayloadHashKey): Deleted.
(WI.DOMTreeManager.prototype._createContentFlowFromPayload): Deleted.
(WI.DOMTreeManager.prototype._updateContentFlowFromPayload): Deleted.
(WI.DOMTreeManager.prototype.getNamedFlowCollection.onNamedFlowCollectionAvailable): Deleted.
(WI.DOMTreeManager.prototype.getNamedFlowCollection): Deleted.
(WI.DOMTreeManager.prototype.namedFlowCreated): Deleted.
(WI.DOMTreeManager.prototype.namedFlowRemoved): Deleted.
(WI.DOMTreeManager.prototype._sendNamedFlowUpdateEvents): Deleted.
(WI.DOMTreeManager.prototype.regionOversetChanged): Deleted.
(WI.DOMTreeManager.prototype.registeredNamedFlowContentElement): Deleted.
(WI.DOMTreeManager.prototype._removeContentNodeFromFlowIfNeeded): Deleted.
(WI.DOMTreeManager.prototype.unregisteredNamedFlowContentElement): Deleted.
(WI.DOMTreeManager.prototype._coerceRemoteArrayOfDOMNodes.nodeRequested): Deleted.
(WI.DOMTreeManager.prototype._coerceRemoteArrayOfDOMNodes): Deleted.
(WI.DOMTreeManager.prototype.getNodeContentFlowInfo.regionNodesAvailable): Deleted.
(WI.DOMTreeManager.prototype.getNodeContentFlowInfo.remoteObjectPropertiesAvailable): Deleted.
(WI.DOMTreeManager.prototype.getNodeContentFlowInfo.inspectedPage_node_getFlowInfo.getComputedProperty): Deleted.
(WI.DOMTreeManager.prototype.getNodeContentFlowInfo.inspectedPage_node_getFlowInfo.getContentFlowName): Deleted.
(WI.DOMTreeManager.prototype.getNodeContentFlowInfo): Deleted.

  • UserInterface/Images/ContentFlow.svg: Removed.
  • UserInterface/Images/gtk/ContentFlow.svg: Removed.
  • UserInterface/Main.html:
  • UserInterface/Models/Collection.js:
  • UserInterface/Models/ContentFlow.js: Removed.
  • UserInterface/Models/DOMTree.js:

(WI.DOMTree):
(WI.DOMTree.prototype.get frame):
(WI.DOMTree.prototype._framePageExecutionContextChanged):
(WI.DOMTree.prototype.get contentFlowCollection): Deleted.
(WI.DOMTree.prototype.requestContentFlowList): Deleted.
(WI.DOMTree.prototype._isContentFlowInCurrentDocument): Deleted.
(WI.DOMTree.prototype._contentFlowListWasUpdated): Deleted.
(WI.DOMTree.prototype._contentFlowWasAdded): Deleted.
(WI.DOMTree.prototype._contentFlowWasRemoved): Deleted.

  • UserInterface/Test.html:
  • UserInterface/Views/CollectionContentView.js:

(WI.CollectionContentView):

  • UserInterface/Views/ComputedStyleDetailsPanel.css:

(.details-section > .content > .group > .row.simple.content-flow-link > .value > span > .icon): Deleted.

  • UserInterface/Views/ComputedStyleDetailsPanel.js:

(WI.ComputedStyleDetailsPanel.prototype.refresh):
(WI.ComputedStyleDetailsPanel.prototype.initialLayout):
(WI.ComputedStyleDetailsPanel.prototype._handleVariablesSectionCollapsedStateChanged):
(WI.ComputedStyleDetailsPanel):
(WI.ComputedStyleDetailsPanel.prototype.get regionFlow): Deleted.
(WI.ComputedStyleDetailsPanel.prototype.set regionFlow): Deleted.
(WI.ComputedStyleDetailsPanel.prototype.get contentFlow): Deleted.
(WI.ComputedStyleDetailsPanel.prototype.set contentFlow): Deleted.
(WI.ComputedStyleDetailsPanel.prototype.get containerRegions): Deleted.
(WI.ComputedStyleDetailsPanel.prototype.set containerRegions): Deleted.
(WI.ComputedStyleDetailsPanel.prototype.sizeDidChange): Deleted.
(WI.ComputedStyleDetailsPanel.prototype._updateFlowNamesSectionVisibility): Deleted.
(WI.ComputedStyleDetailsPanel.prototype._resetFlowDetails): Deleted.
(WI.ComputedStyleDetailsPanel.prototype._refreshFlowDetails.contentFlowInfoReady): Deleted.
(WI.ComputedStyleDetailsPanel.prototype._refreshFlowDetails): Deleted.
(WI.ComputedStyleDetailsPanel.prototype._goToRegionFlowArrowWasClicked): Deleted.
(WI.ComputedStyleDetailsPanel.prototype._goToContentFlowArrowWasClicked): Deleted.

  • UserInterface/Views/ContentFlowDOMTreeContentView.js: Removed.
  • UserInterface/Views/ContentFlowIcon.css: Removed.
  • UserInterface/Views/ContentFlowTreeElement.js: Removed.
  • UserInterface/Views/ContentView.js:

(WI.ContentView.createFromRepresentedObject):
(WI.ContentView.isViewable):

  • UserInterface/Views/FrameTreeElement.js:

(WI.FrameTreeElement.prototype.onpopulate):
(WI.FrameTreeElement.prototype.onexpand):
(WI.FrameTreeElement.prototype._childContentFlowWasAdded): Deleted.
(WI.FrameTreeElement.prototype._childContentFlowWasRemoved): Deleted.
(WI.FrameTreeElement.prototype._rootDOMNodeInvalidated): Deleted.

  • UserInterface/Views/ResourceSidebarPanel.js:

(WI.ResourceSidebarPanel.prototype._treeSelectionDidChange):

  • UserInterface/Views/ResourcesTabContentView.js:

(WI.ResourcesTabContentView):
(WI.ResourcesTabContentView.prototype.canShowRepresentedObject):

LayoutTests:

  • inspector/dom/content-flow-content-nodes-expected.txt: Removed.
  • inspector/dom/content-flow-content-nodes.html: Removed.
  • inspector/dom/content-flow-content-removal-expected.txt: Removed.
  • inspector/dom/content-flow-content-removal.html: Removed.
  • inspector/dom/content-flow-list-expected.txt: Removed.
  • inspector/dom/content-flow-list.html: Removed.
  • inspector/dom/content-node-region-info-expected.txt: Removed.
  • inspector/dom/content-node-region-info.html: Removed.
  • inspector/dom/highlight-flow-with-no-region-expected.txt: Removed.
  • inspector/dom/highlight-flow-with-no-region.html: Removed.
Location:
trunk/Source/JavaScriptCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r222338 r222356  
     12017-09-21  Joseph Pecoraro  <[email protected]>
     2
     3        Web Inspector: Remove support for CSS Regions
     4        https://bugs.webkit.org/show_bug.cgi?id=177287
     5
     6        Reviewed by Matt Baker.
     7
     8        * inspector/protocol/CSS.json:
     9        * inspector/protocol/OverlayTypes.json:
     10
    1112017-09-21  Brian Burg  <[email protected]>
    212

  • trunk/Source/JavaScriptCore/inspector/protocol/CSS.json

    r218898 r222356  
    209209                { "name": "sourceLine", "type": "integer", "optional": true, "description": "Line in the document containing the media query (not defined for the \"stylesheet\" source)." }
    210210            ]
    211         },
    212         {
    213             "id": "Region",
    214             "type": "object",
    215             "description": "This object represents a region that flows from a Named Flow.",
    216             "properties": [
    217                 { "name": "regionOverset", "type": "string", "enum": ["overset", "fit", "empty"], "description": "The \"overset\" attribute of a Named Flow." },
    218                 { "name": "nodeId", "$ref": "DOM.NodeId", "description": "The corresponding DOM node id." }
    219             ]
    220         },
    221         {
    222             "id": "NamedFlow",
    223             "type": "object",
    224             "description": "This object represents a Named Flow.",
    225             "properties": [
    226                 { "name": "documentNodeId", "$ref": "DOM.NodeId", "description": "The document node id." },
    227                 { "name": "name", "type": "string", "description": "Named Flow identifier." },
    228                 { "name": "overset", "type": "boolean", "description": "The \"overset\" attribute of a Named Flow." },
    229                 { "name": "content", "type": "array", "items": { "$ref": "DOM.NodeId" }, "description": "An array of nodes that flow into the Named Flow." },
    230                 { "name": "regions", "type": "array", "items": { "$ref": "Region" }, "description": "An array of regions associated with the Named Flow." }
    231             ]
    232211        }
    233212    ],
    … …  
    375354                { "name": "forcedPseudoClasses", "type": "array", "items": { "type": "string", "enum": ["active", "focus", "hover", "visited"] }, "description": "Element pseudo classes to force when computing the element's style." }
    376355            ]
    377         },
    378         {
    379             "name": "getNamedFlowCollection",
    380             "description": "Returns the Named Flows from the document.",
    381             "parameters": [
    382                 { "name": "documentNodeId", "$ref": "DOM.NodeId", "description": "The document node id for which to get the Named Flow Collection." }
    383             ],
    384             "returns": [
    385                 { "name": "namedFlows", "type": "array", "items": { "$ref": "NamedFlow" }, "description": "An array containing the Named Flows in the document." }
    386             ]
    387356        }
    388357    ],
    … …  
    412381                { "name": "styleSheetId", "$ref": "StyleSheetId", "description": "Identifier of the removed stylesheet." }
    413382            ]
    414         },
    415         {
    416             "name": "namedFlowCreated",
    417             "description": "Fires when a Named Flow is created.",
    418             "parameters": [
    419                 { "name": "namedFlow", "$ref": "NamedFlow", "description": "The new Named Flow." }
    420             ]
    421         },
    422         {
    423             "name": "namedFlowRemoved",
    424             "description": "Fires when a Named Flow is removed: has no associated content nodes and regions.",
    425             "parameters": [
    426                 { "name": "documentNodeId", "$ref": "DOM.NodeId", "description": "The document node id." },
    427                 { "name": "flowName", "type": "string", "description": "Identifier of the removed Named Flow." }
    428             ]
    429         },
    430         {
    431             "name": "regionOversetChanged",
    432             "description": "Fires if any of the regionOverset values changed in a Named Flow's region chain.",
    433             "parameters": [
    434                 { "name": "namedFlow", "$ref": "NamedFlow", "description": "The Named Flow containing the regions whose regionOverset values changed." }
    435             ]
    436         },
    437         {
    438             "name": "registeredNamedFlowContentElement",
    439             "description": "Fires when a Named Flow's has been registered with a new content node.",
    440             "parameters": [
    441                 { "name": "documentNodeId", "$ref": "DOM.NodeId", "description": "The document node id." },
    442                 { "name": "flowName", "type": "string", "description": "Named Flow identifier for which the new content element was registered." },
    443                 { "name": "contentNodeId", "$ref": "DOM.NodeId", "description": "The node id of the registered content node." },
    444                 { "name": "nextContentNodeId", "$ref": "DOM.NodeId", "description": "The node id of the element following the registered content node." }
    445             ]
    446         },
    447         {
    448             "name": "unregisteredNamedFlowContentElement",
    449             "description": "Fires when a Named Flow's has been registered with a new content node.",
    450             "parameters": [
    451                 { "name": "documentNodeId", "$ref": "DOM.NodeId", "description": "The document node id." },
    452                 { "name": "flowName", "type": "string", "description": "Named Flow identifier for which the new content element was unregistered." },
    453                 { "name": "contentNodeId", "$ref": "DOM.NodeId", "description": "The node id of the unregistered content node." }
    454             ]
    455383        }
    456384    ]

  • trunk/Source/JavaScriptCore/inspector/protocol/OverlayTypes.json

    r205035 r222356  
    3737        },
    3838        {
    39             "id": "Region",
    40             "description": "A single region in a flow thread.",
    41             "type": "object",
    42             "properties": [
    43                 { "name": "borderQuad", "$ref": "Quad" },
    44                 { "name": "incomingQuad", "$ref": "Quad" },
    45                 { "name": "outgoingQuad", "$ref": "Quad" },
    46                 { "name": "isHighlighted", "type": "boolean", "optional": true }
    47             ]
    48         },
    49         {
    5039            "id": "DisplayPath",
    5140            "description": "A vector path described using SVG path syntax.",
    5241            "type": "array",
    5342            "items": { "type": "any" }
    54         },
    55         {
    56             "id": "RegionFlowData",
    57             "type": "object",
    58             "properties": [
    59                 { "name": "regions", "type": "array", "items": { "$ref": "Region"} },
    60                 { "name": "name", "type": "string" }
    61             ]
    62         },
    63         {
    64             "id": "ContentFlowData",
    65             "type": "object",
    66             "properties": [
    67                 { "name": "name", "type": "string" }
    68             ]
    6943        },
    7044        {
    … …  
    8862                { "name": "role", "type": "string", "description": "Computed accessibility role for the element.", "optional": true },
    8963                { "name": "pseudoElement", "type": "string", "optional": true },
    90                 { "name": "regionFlowData", "$ref": "RegionFlowData", "optional": true },
    91                 { "name": "contentFlowData", "$ref": "ContentFlowData", "optional": true },
    9264                { "name": "shapeOutsideData", "$ref": "ShapeOutsideData", "optional": true }
    9365            ]
    … …  
    10375                { "name": "paddingColor", "type": "string" },
    10476                { "name": "borderColor", "type": "string" },
    105                 { "name": "marginColor", "type": "string" },
    106                 { "name": "regionClippingArea", "$ref": "Quad", "optional": true }
     77                { "name": "marginColor", "type": "string" }
    10778            ]
    10879        },
Note: See TracChangeset for help on using the changeset viewer.