Changeset 223222 in webkit for trunk/Source/JavaScriptCore

Timestamp:

Oct 11, 2017, 5:53:45 PM (8 years ago)

Author:

[email protected]

Message:

Runtime disable poly proto because it may be a 3-4% Speedometer regression
​https://bugs.webkit.org/show_bug.cgi?id=178192

Reviewed by JF Bastien.

Source/JavaScriptCore:

• runtime/Options.h:
• runtime/StructureInlines.h:

(JSC::Structure::shouldConvertToPolyProto):

Tools:

• Scripts/run-jsc-stress-tests:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/Options.h (modified) (1 diff)
• runtime/StructureInlines.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-10-11  Saam Barati  <[email protected]>
+
+        Runtime disable poly proto because it may be a 3-4% Speedometer regression
+        https://bugs.webkit.org/show_bug.cgi?id=178192
+
+        Reviewed by JF Bastien.
+
+        * runtime/Options.h:
+        * runtime/StructureInlines.h:
+        (JSC::Structure::shouldConvertToPolyProto):
+
 2017-10-11  Commit Queue  <[email protected]>
 

trunk/Source/JavaScriptCore/runtime/Options.h

@@ -474 +474 @@
     v(bool, useObjectRestSpread, true, Normal, "If true, we will enable Object Rest/Spread feature.") \
     v(bool, useArrayAllocationProfiling, true, Normal, "If true, we will use our normal array allocation profiling. If false, the allocation profile will always claim to be undecided.")\
+    v(bool, usePolyProto, false, Normal, "If true, we may convert allocations to generate poly proto structures.") \
     v(bool, forcePolyProto, false, Normal, "If true, create_this will always create an object with a poly proto structure.")
 

trunk/Source/JavaScriptCore/runtime/StructureInlines.h

@@ -448 +448 @@
 ALWAYS_INLINE bool Structure::shouldConvertToPolyProto(const Structure* a, const Structure* b)
 {
+    if (!Options::usePolyProto())
+        return false;
+
     if (!a || !b)
         return false;