Changeset 226725 in webkit for trunk/Source/JavaScriptCore/debugger

Timestamp:

Jan 10, 2018, 11:41:12 AM (7 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r226667 and r226673.
​https://bugs.webkit.org/show_bug.cgi?id=181488

This caused a flaky crash. (Requested by mlewis13 on #webkit).

Reverted changesets:

"CodeBlocks should be in IsoSubspaces"
​https://bugs.webkit.org/show_bug.cgi?id=180884
​https://trac.webkit.org/changeset/226667

"REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
​https://bugs.webkit.org/show_bug.cgi?id=180884
​https://trac.webkit.org/changeset/226673

File:

• trunk/Source/JavaScriptCore/debugger/Debugger.cpp (modified) (5 diffs)

trunk/Source/JavaScriptCore/debugger/Debugger.cpp

@@ -208 +208 @@
     }
 
-    void operator()(CodeBlock* codeBlock) const
+    bool operator()(CodeBlock* codeBlock) const
     {
         if (m_debugger == codeBlock->globalObject()->debugger()) {
@@ -216 +216 @@
                 codeBlock->setSteppingMode(CodeBlock::SteppingModeDisabled);
         }
+        return false;
     }
 
@@ -315 +316 @@
     }
 
-    void operator()(CodeBlock* codeBlock) const
+    bool operator()(CodeBlock* codeBlock) const
     {
         if (m_debugger == codeBlock->globalObject()->debugger())
             m_debugger->toggleBreakpoint(codeBlock, m_breakpoint, m_enabledOrNot);
+        return false;
     }
 
@@ -527 +529 @@
     }
 
-    void operator()(CodeBlock* codeBlock) const
+    bool operator()(CodeBlock* codeBlock) const
     {
         if (codeBlock->hasDebuggerRequests() && m_debugger == codeBlock->globalObject()->debugger())
             codeBlock->clearDebuggerRequests();
+        return false;
     }
 
@@ -556 +559 @@
     }
 
-    void operator()(CodeBlock* codeBlock) const
+    bool operator()(CodeBlock* codeBlock) const
     {
         if (codeBlock->hasDebuggerRequests() && m_globalObject == codeBlock->globalObject())
             codeBlock->clearDebuggerRequests();
+        return false;
     }