Changeset 23892 in webkit for trunk/JavaScriptCore/kjs

Timestamp:

Jun 29, 2007, 2:36:10 PM (18 years ago)

Author:

weinig

Message:

JavaScriptCore:

Reviewed by Darin.

Second pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

• Add a toFloat() method to JSValue for float conversion.

• JavaScriptCore.exp:
• kjs/value.cpp: (KJS::JSValue::toFloat):
• kjs/value.h:

WebCore:

Reviewed by Darin.

Second pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

• Use new JSValue::toFloat() method instead of toNumber() where appropriate.

• bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::setFillColor): (WebCore::JSCanvasRenderingContext2D::setStrokeColor): (WebCore::JSCanvasRenderingContext2D::strokeRect): (WebCore::JSCanvasRenderingContext2D::drawImage): (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): (WebCore::JSCanvasRenderingContext2D::setShadow):
• bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::remove):
• bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::rotateFromVector):
• bindings/js/kjs_events.cpp: (KJS::JSClipboardPrototypeFunction::callAsFunction):
• bindings/scripts/CodeGeneratorJS.pm:
• ksvg2/svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::executeScript):

Location:

trunk/JavaScriptCore/kjs

Files:

• value.cpp (modified) (1 diff)
• value.h (modified) (1 diff)

trunk/JavaScriptCore/kjs/value.cpp

@@ -129 +129 @@
 }
 
+float JSValue::toFloat(ExecState* exec) const
+{
+    return static_cast<float>(toNumber(exec));
+}
+
 bool JSCell::getNumber(double &numericValue) const
 {

trunk/JavaScriptCore/kjs/value.h

@@ -102 +102 @@
     uint32_t toUInt32(ExecState*, bool& ok) const;
     uint16_t toUInt16(ExecState*) const;
+
+    // Floating point conversions.
+    float toFloat(ExecState*) const;
 
     // Garbage collection.