Changeset 239867 in webkit for trunk/Source/JavaScriptCore/offlineasm

Timestamp:

Jan 11, 2019, 12:41:42 PM (6 years ago)

Author:

[email protected]

Message:

Enable DFG on ARM/Linux again
​https://bugs.webkit.org/show_bug.cgi?id=192496

Reviewed by Yusuke Suzuki.

JSTests:

Test wasn't really skipped before moving the line with skip
to the top.

• stress/regress-192717.js:

Source/JavaScriptCore:

After changing the bytecode format DFG was disabled on all 32-bit
architectures. Enable DFG now again on ARM/Linux. Do not use register
r11 in compiled DFG mode since it is already used in LLInt as metadataTable
register. Also clean up code since ARM traditional isn't supported anymore.

• dfg/DFGOSRExit.cpp:

(JSC::DFG::restoreCalleeSavesFromVMEntryFrameCalleeSavesBuffer):
(JSC::DFG::copyCalleeSavesToVMEntryFrameCalleeSavesBuffer):

• jit/CallFrameShuffler.cpp:

(JSC::CallFrameShuffler::CallFrameShuffler):

• jit/GPRInfo.h:

(JSC::GPRInfo::toIndex):

• llint/LowLevelInterpreter32_64.asm:
• offlineasm/arm.rb:

Source/WTF:

After changing the bytecode format DFG was disabled on all 32-bit
architectures. Enable DFG now again on ARM/Linux.

• wtf/Platform.h:

Tools:

After changing the bytecode format DFG was disabled on all 32-bit
architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
on ARM by default.

• Scripts/run-jsc-stress-tests:

LayoutTests:

After changing the bytecode format DFG was disabled on all 32-bit
architectures. Enable DFG now again on ARM/Linux. Disable tests that
run out of executable memory with LLInt disabled.

• js/script-tests/dfg-float32array.js:
• js/script-tests/dfg-float64array.js:
• js/script-tests/dfg-int16array.js:
• js/script-tests/dfg-int32array-overflow-values.js:
• js/script-tests/dfg-int32array.js:
• js/script-tests/dfg-int8array.js:
• js/script-tests/dfg-uint16array.js:
• js/script-tests/dfg-uint32array.js:
• js/script-tests/dfg-uint8array.js:

File:

• trunk/Source/JavaScriptCore/offlineasm/arm.rb (modified) (6 diffs)

trunk/Source/JavaScriptCore/offlineasm/arm.rb

@@ -35 +35 @@
 #  x3 => t3, a3, r3
 #  x6 =>            (callee-save scratch)
-#  x7 => cfr        (ARMv7 only)
+#  x7 => cfr
 #  x8 => t4         (callee-save)
 #  x9 => t5         (callee-save)
@@ -56 +56 @@
 # d7 =>              (scratch)
 
-def isARMv7
-    case $activeBackend
-    when "ARMv7"
-        true
-    else
-        raise "bad value for $activeBackend: #{$activeBackend}"
-    end
-end
-
 class Node
     def armSingle
@@ -92 +83 @@
     elsif (~value) >= 0 && (~value) < 256
         $asm.puts "mvn #{register.armOperand}, \##{~value}"
-    elsif isARMv7
+    else
         $asm.puts "movw #{register.armOperand}, \##{value & 0xffff}"
         if (value & 0xffff0000) != 0
             $asm.puts "movt #{register.armOperand}, \##{(value >> 16) & 0xffff}"
         end
-    else
-        $asm.puts "ldr #{register.armOperand}, =#{value}"
     end
 end
@@ -120 +109 @@
             "r9"
         when "cfr"
-            isARMv7 ?  "r7" : "r11"
+            "r7"
         when "csr0"
             "r11"
@@ -610 +599 @@
                 $asm.puts "mov pc, #{operands[0].armOperand}"
             end
-            if not isARMv7 and not isARMv7Traditional
-                $asm.puts ".ltorg"
-            end
         when "call"
             if operands[0].label?
@@ -693 +679 @@
             $asm.puts "ldr #{dest.armOperand}, [#{dest.armOperand}, #{temp.armOperand}]"
 
-            offset = $activeBackend == "ARMv7" ? 4 : 8
+            offset = 4
 
             $asm.deferNextLabelAction {