Context Navigation

← Previous Change
Next Change →

JavaScriptCore

Timestamp:

Jan 28, 2019, 10:00:30 PM (6 years ago)

Author:

Ross Kirsling

Message:

Remove unnecessary using namespace WTFs (or at least restrict their scope).
https://bugs.webkit.org/show_bug.cgi?id=193941

Reviewed by Alex Christensen.

Source/JavaScriptCore:

API/JSWeakObjectMapRefPrivate.cpp:
bytecompiler/NodesCodegen.cpp:
heap/MachineStackMarker.cpp:
jit/ExecutableAllocator.cpp:
jsc.cpp:
parser/Nodes.cpp:
runtime/DateConstructor.cpp:
runtime/DateConversion.cpp:
runtime/DateInstance.cpp:
runtime/DatePrototype.cpp:
runtime/InitializeThreading.cpp:
runtime/IteratorOperations.cpp:
runtime/JSDateMath.cpp:
runtime/JSGlobalObjectFunctions.cpp:
runtime/StringPrototype.cpp:
runtime/VM.cpp:
testRegExp.cpp:
tools/JSDollarVM.cpp:
yarr/YarrInterpreter.cpp:
yarr/YarrJIT.cpp:
yarr/YarrPattern.cpp:
yarr/YarrUnicodeProperties.cpp:

Source/WebCore:

css/CSSBasicShapes.cpp:
css/CSSPrimitiveValue.cpp:
css/parser/CSSParser.cpp:
css/parser/CSSParserSelector.cpp:
css/parser/CSSPropertyParser.cpp:
dom/Document.cpp:
dom/EventListenerMap.cpp:
dom/EventTarget.cpp:
editing/Editor.cpp:
html/HTMLElement.cpp:
html/HTMLFontElement.cpp:
html/parser/HTMLTokenizer.cpp:
html/track/TrackBase.cpp:
loader/FTPDirectoryParser.cpp:
loader/TextResourceDecoder.cpp:
loader/cache/CachedResource.cpp:
page/ContextMenuController.cpp:
page/Navigator.cpp:
platform/Length.cpp:
platform/cocoa/KeyEventCocoa.mm:
platform/graphics/FontCascade.cpp:
platform/graphics/WidthIterator.cpp:
platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
platform/ios/KeyEventIOS.mm:
platform/mac/KeyEventMac.mm:
platform/network/HTTPParsers.cpp:
platform/text/TextCodecUTF8.cpp:
platform/text/TextEncodingRegistry.cpp:
platform/win/KeyEventWin.cpp:
rendering/BidiRun.cpp:
rendering/FloatingObjects.cpp:
rendering/RenderBlock.cpp:
rendering/RenderListMarker.cpp:
rendering/RenderText.cpp:

Source/WebKit:

Shared/linux/WebMemorySamplerLinux.cpp:

Source/WebKitLegacy/win:

Plugins/PluginMessageThrottlerWin.cpp:
Plugins/PluginView.cpp:
Plugins/PluginViewWin.cpp:

Tools:

TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
TestWebKitAPI/Tests/WTF/Condition.cpp:
TestWebKitAPI/Tests/WTF/Lock.cpp:
TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
TestWebKitAPI/Tests/WTF/Time.cpp:
TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
TestWebKitAPI/Tests/WebCore/Logging.cpp:
WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:

Location:

trunk/Source/JavaScriptCore

Files:

: 23 edited

API/JSWeakObjectMapRefPrivate.cpp (modified) (1 diff)
ChangeLog (modified) (1 diff)
bytecompiler/NodesCodegen.cpp (modified) (1 diff)
heap/MachineStackMarker.cpp (modified) (1 diff)
jit/ExecutableAllocator.cpp (modified) (1 diff)
jsc.cpp (modified) (1 diff)
parser/Nodes.cpp (modified) (1 diff)
runtime/DateConstructor.cpp (modified) (2 diffs)
runtime/DateConversion.cpp (modified) (1 diff)
runtime/DateInstance.cpp (modified) (1 diff)
runtime/DatePrototype.cpp (modified) (1 diff)
runtime/InitializeThreading.cpp (modified) (1 diff)
runtime/IteratorOperations.cpp (modified) (1 diff)
runtime/JSDateMath.cpp (modified) (1 diff)
runtime/JSGlobalObjectFunctions.cpp (modified) (1 diff)
runtime/StringPrototype.cpp (modified) (1 diff)
runtime/VM.cpp (modified) (1 diff)
testRegExp.cpp (modified) (1 diff)
tools/JSDollarVM.cpp (modified) (1 diff)
yarr/YarrInterpreter.cpp (modified) (2 diffs)
yarr/YarrJIT.cpp (modified) (1 diff)
yarr/YarrPattern.cpp (modified) (1 diff)
yarr/YarrUnicodeProperties.cpp (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/Source/JavaScriptCore/API/JSWeakObjectMapRefPrivate.cpp

r239535	r240641
35	35	#include "WeakGCMapInlines.h"
36	36
37		~~using namespace WTF;~~
38	37	using namespace JSC;
39	38

trunk/Source/JavaScriptCore/ChangeLog

-              r240637
+              r240641
+-01-28  Ross Kirsling  <[email protected]>
+        Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
+        https://bugs.webkit.org/show_bug.cgi?id=193941
+        Reviewed by Alex Christensen.
+        * API/JSWeakObjectMapRefPrivate.cpp:
+        * bytecompiler/NodesCodegen.cpp:
+        * heap/MachineStackMarker.cpp:
+        * jit/ExecutableAllocator.cpp:
+        * jsc.cpp:
+        * parser/Nodes.cpp:
+        * runtime/DateConstructor.cpp:
+        * runtime/DateConversion.cpp:
+        * runtime/DateInstance.cpp:
+        * runtime/DatePrototype.cpp:
+        * runtime/InitializeThreading.cpp:
+        * runtime/IteratorOperations.cpp:
+        * runtime/JSDateMath.cpp:
+        * runtime/JSGlobalObjectFunctions.cpp:
+        * runtime/StringPrototype.cpp:
+        * runtime/VM.cpp:
+        * testRegExp.cpp:
+        * tools/JSDollarVM.cpp:
+        * yarr/YarrInterpreter.cpp:
+        * yarr/YarrJIT.cpp:
+        * yarr/YarrPattern.cpp:
+        * yarr/YarrUnicodeProperties.cpp:
 -01-28  Yusuke Suzuki  <[email protected]>

trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp

r239761	r240641
45	45	#include <wtf/Threading.h>
46	46	#include <wtf/text/StringBuilder.h>
47
48		~~using namespace WTF;~~
49	47
50	48	namespace JSC {

trunk/Source/JavaScriptCore/heap/MachineStackMarker.cpp

r237173	r240641
30	30	#include <wtf/PageBlock.h>
31	31	#include <wtf/StdLibExtras.h>
32
33		~~using namespace WTF;~~
34	32
35	33	namespace JSC {

trunk/Source/JavaScriptCore/jit/ExecutableAllocator.cpp

-              r238564
+              r240641
 #endif
+namespace JSC {
 using namespace WTF;
-namespace JSC {
 #if defined(FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB) && FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB > 0

trunk/Source/JavaScriptCore/jsc.cpp

r240557	r240641
158	158
159	159	using namespace JSC;
160		~~using namespace WTF;~~
161	160
162	161	namespace {

trunk/Source/JavaScriptCore/parser/Nodes.cpp

r233937	r240641
32	32	#include <wtf/Assertions.h>
33	33
34		~~using namespace WTF;~~
35
36	34	namespace JSC {
37	35

trunk/Source/JavaScriptCore/runtime/DateConstructor.cpp

-              r236697
+              r240641
 #endif
-using namespace WTF;
 namespace JSC {
 …
 namespace JSC {
+using namespace WTF;
 const ClassInfo DateConstructor::s_info = { "Function", &InternalFunction::s_info, &dateConstructorTable, nullptr, CREATE_METHOD_TABLE(DateConstructor) };

trunk/Source/JavaScriptCore/runtime/DateConversion.cpp

-              r217771
+              r240641
 #endif
+namespace JSC {
 using namespace WTF;
-namespace JSC {
 template<int width>

trunk/Source/JavaScriptCore/runtime/DateInstance.cpp

-              r217108
+              r240641
 #include <wtf/MathExtras.h>
+namespace JSC {
 using namespace WTF;
-namespace JSC {
 const ClassInfo DateInstance::s_info = {"Date", &JSWrapperObject::s_info, nullptr, nullptr, CREATE_METHOD_TABLE(DateInstance)};

trunk/Source/JavaScriptCore/runtime/DatePrototype.cpp

-              r236697
+              r240641
 #endif
+namespace JSC {
 using namespace WTF;
-namespace JSC {
 EncodedJSValue JSC_HOST_CALL dateProtoFuncGetDate(ExecState*);

trunk/Source/JavaScriptCore/runtime/InitializeThreading.cpp

r234171	r240641
50	50	#include <wtf/dtoa/cached-powers.h>
51	51
52		~~using namespace WTF;~~
53
54	52	namespace JSC {
55	53

trunk/Source/JavaScriptCore/runtime/IteratorOperations.cpp

r233740	r240641
33	33	#include "ObjectConstructor.h"
34	34
35		~~using namespace WTF;~~
36
37	35	namespace JSC {
38	36

trunk/Source/JavaScriptCore/runtime/JSDateMath.cpp

-              r232089
+              r240641
 #endif
+namespace JSC {
 using namespace WTF;
-namespace JSC {
 static inline double timeToMS(double hour, double min, double sec, double ms)

trunk/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp

-              r239256
+              r240641
 #include <wtf/unicode/UTF8Conversion.h>
-using namespace WTF;
-using namespace Unicode;
 namespace JSC {
+using namespace WTF::Unicode;
 const ASCIILiteral ObjectProtoCalledOnNullOrUndefinedError { "Object.prototype.__proto__ called on null or undefined"_s };

trunk/Source/JavaScriptCore/runtime/StringPrototype.cpp

r240593	r240641
55	55	#include <wtf/text/StringView.h>
56	56	#include <wtf/unicode/Collator.h>
57
58		~~using namespace WTF;~~
59	57
60	58	namespace JSC {

trunk/Source/JavaScriptCore/runtime/VM.cpp

r240637	r240641
171	171	#endif
172	172
173		~~using namespace WTF;~~
174
175	173	namespace JSC {
176	174

trunk/Source/JavaScriptCore/testRegExp.cpp

r229309	r240641
49	49
50	50	using namespace JSC;
51		~~using namespace WTF;~~
52	51
53	52	struct CommandLine {

trunk/Source/JavaScriptCore/tools/JSDollarVM.cpp

r240637	r240641
58	58
59	59	using namespace JSC;
60		~~using namespace WTF;~~
61	60
62	61	namespace {

trunk/Source/JavaScriptCore/yarr/YarrInterpreter.cpp

-              r234916
+              r240641
 #include <wtf/text/WTFString.h>
-using namespace WTF;
 namespace JSC { namespace Yarr {
 …
     unsigned* output;
     InputStream input;
     BumpPointerPool* allocatorPool { nullptr };
+    WTF::BumpPointerPool* allocatorPool { nullptr };
     unsigned startOffset;
     unsigned remainingMatchCount;

trunk/Source/JavaScriptCore/yarr/YarrJIT.cpp

r239427	r240641
36	36
37	37	#if ENABLE(YARR_JIT)
38
39		~~using namespace WTF;~~
40	38
41	39	namespace JSC { namespace Yarr {

trunk/Source/JavaScriptCore/yarr/YarrPattern.cpp

r239427	r240641
38	38	#include <wtf/Vector.h>
39	39	#include <wtf/text/WTFString.h>
40
41		~~using namespace WTF;~~
42	40
43	41	namespace JSC { namespace Yarr {

trunk/Source/JavaScriptCore/yarr/YarrUnicodeProperties.cpp

r239427	r240641
29	29	#include "Yarr.h"
30	30	#include "YarrPattern.h"
31
32		~~using namespace WTF;~~
33	31
34	32	namespace JSC { namespace Yarr {

Note: See TracChangeset for help on using the changeset viewer.

Context Navigation

Changeset 240641 in webkit for trunk/Source/JavaScriptCore

Legend:

Download in other formats: