Changeset 240679 in webkit for trunk/Source/JavaScriptCore

Timestamp:

Jan 29, 2019, 1:55:51 PM (6 years ago)

Author:

[email protected]

Message:

[JSC] FTL should handle LocalAllocator*
​https://bugs.webkit.org/show_bug.cgi?id=193980

Reviewed by Saam Barati.

At some point, Allocator holds LocalAllocator* instead of 32bit integer. In FTL allocation path, we fail to use this constant LocalAllocator*
because the FTL still use the incoming value as 32bit integer there.

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::allocateHeapCell):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• ftl/FTLLowerDFGToB3.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-01-29  Yusuke Suzuki  <[email protected]>
+
+        [JSC] FTL should handle LocalAllocator*
+        https://bugs.webkit.org/show_bug.cgi?id=193980
+
+        Reviewed by Saam Barati.
+
+        At some point, Allocator holds LocalAllocator* instead of 32bit integer. In FTL allocation path, we fail to use this constant LocalAllocator*
+        because the FTL still use the incoming value as 32bit integer there.
+
+        * ftl/FTLLowerDFGToB3.cpp:
+        (JSC::FTL::DFG::LowerDFGToB3::allocateHeapCell):
+
 2019-01-29  Keith Rollin  <[email protected]>
 

trunk/Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp

@@ -13042 +13042 @@
     {
         JITAllocator actualAllocator;
-        if (allocator->hasInt32())
+        if (allocator->hasIntPtr())
             actualAllocator = JITAllocator::constant(Allocator(bitwise_cast<LocalAllocator*>(allocator->asIntPtr())));
         else