Changeset 253263 in webkit for trunk/Source/JavaScriptCore/llint

Timestamp:

Dec 7, 2019, 2:25:18 PM (5 years ago)

Author:

[email protected]

Message:

Unreviewed. Roll out r253201. It was not a progression on any benchmarks, and was 8% slower on JetStream 2 ML.

• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/BytecodeList.rb:
• bytecode/GetByValHistory.h: Added.

(JSC::GetByValHistory::observeNonUID):
(JSC::GetByValHistory::observe):
(JSC::GetByValHistory::count const):
(JSC::GetByValHistory::filter const):
(JSC::GetByValHistory::update):

• bytecode/PointerHistory.h: Removed.
• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseGetById):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGGraph.h:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetById):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetById):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):

• generator/DSL.rb:
• jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_try_get_by_id):
(JSC::JIT::emitSlow_op_try_get_by_id):
(JSC::JIT::emit_op_get_by_id_direct):
(JSC::JIT::emitSlow_op_get_by_id_direct):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• runtime/OptionsList.h:

File:

• trunk/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp (modified) (4 diffs)

trunk/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp

@@ -641 +641 @@
     LLINT_BEGIN();
     auto bytecode = pc->as<OpTryGetById>();
-    auto& metadata = bytecode.metadata(codeBlock);
-
     const Identifier& ident = codeBlock->identifier(bytecode.m_property);
     JSValue baseValue = getOperand(callFrame, bytecode.m_base);
-    if (metadata.m_seenStructures.count() <= Options::getByIdICMaxNumberOfStructures())
-        metadata.m_seenStructures.observe(baseValue.structureOrNull());
     PropertySlot slot(baseValue, PropertySlot::PropertySlot::InternalMethodType::VMInquiry);
 
@@ -659 +655 @@
     LLINT_BEGIN();
     auto bytecode = pc->as<OpGetByIdDirect>();
-    auto& metadata = bytecode.metadata(codeBlock);
     const Identifier& ident = codeBlock->identifier(bytecode.m_property);
     JSValue baseValue = getOperand(callFrame, bytecode.m_base);
-    if (metadata.m_seenStructures.count() <= Options::getByIdICMaxNumberOfStructures())
-        metadata.m_seenStructures.observe(baseValue.structureOrNull());
     PropertySlot slot(baseValue, PropertySlot::PropertySlot::InternalMethodType::GetOwnProperty);
 
@@ -672 +665 @@
 
     if (!LLINT_ALWAYS_ACCESS_SLOW && slot.isCacheable() && !slot.isUnset()) {
+        auto& metadata = bytecode.metadata(codeBlock);
         {
             StructureID oldStructureID = metadata.m_structureID;
@@ -772 +766 @@
     const Identifier& ident = codeBlock->identifier(bytecode.m_property);
     JSValue baseValue = getOperand(callFrame, bytecode.m_base);
-
-    if (metadata.m_seenStructures.count() <= Options::getByIdICMaxNumberOfStructures())
-        metadata.m_seenStructures.observe(baseValue.structureOrNull());
-
     PropertySlot slot(baseValue, PropertySlot::PropertySlot::InternalMethodType::Get);