Changeset 253321 in webkit for trunk/Source/JavaScriptCore/tools

Timestamp:

Dec 10, 2019, 1:41:35 AM (5 years ago)

Author:

[email protected]

Message:

[JSC] Put JSArray in IsoSubspace
​https://bugs.webkit.org/show_bug.cgi?id=205049

Reviewed by Mark Lam.

Source/JavaScriptCore:

Put JSArray in IsoSubspace.

• runtime/ArrayPrototype.h:
• runtime/JSArray.h:

(JSC::JSArray::subspaceFor):

• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:
• tools/JSDollarVM.cpp:

Source/WebCore:

RuntimeArray is inheriting JSArray. We should have separate IsoSubspace for this.

• bindings/js/WebCoreJSClientData.cpp:

(WebCore::JSVMClientData::JSVMClientData):

• bindings/js/WebCoreJSClientData.h:

(WebCore::JSVMClientData::runtimeArraySpace):

• bridge/runtime_array.cpp:

(JSC::RuntimeArray::subspaceForImpl):

• bridge/runtime_array.h:

(JSC::RuntimeArray::create): Deleted.
(JSC::RuntimeArray::getLength const): Deleted.
(JSC::RuntimeArray::getConcreteArray const): Deleted.
(JSC::RuntimeArray::createPrototype): Deleted.
(JSC::RuntimeArray::createStructure): Deleted.

File:

• trunk/Source/JavaScriptCore/tools/JSDollarVM.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/tools/JSDollarVM.cpp

@@ -493 +493 @@
 };
 
-class RuntimeArray : public JSArray {
+class RuntimeArray final : public JSArray {
 public:
-    typedef JSArray Base;
+    using Base = JSArray;
     static constexpr unsigned StructureFlags = Base::StructureFlags | OverridesGetOwnPropertySlot | InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | OverridesGetPropertyNames;
+
+    template<typename CellType, SubspaceAccess>
+    static CompleteSubspace* subspaceFor(VM& vm)
+    {
+        return &vm.cellSpace;
+    }
 
     static RuntimeArray* create(JSGlobalObject* globalObject, CallFrame* callFrame)