Changeset 254087 in webkit for trunk/Source/JavaScriptCore/builtins

Timestamp:

Jan 6, 2020, 2:24:50 PM (5 years ago)

Author:

[email protected]

Message:

PerformanceTests:
Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.
​https://bugs.webkit.org/show_bug.cgi?id=205776

Reviewed by Saam Barati.

• JetStream2/wasm/HashSet.cpp:
• StitchMarker/wtf/Assertions.h:
• StitchMarker/wtf/DateMath.cpp:

(WTF::initializeDates):

• StitchMarker/wtf/HashTable.h:
• StitchMarker/wtf/Hasher.h:

(WTF::StringHasher::addCharacters):

• StitchMarker/wtf/NeverDestroyed.h:

(WTF::LazyNeverDestroyed::construct):

• StitchMarker/wtf/StackBounds.h:

(WTF::StackBounds::checkConsistency const):

• StitchMarker/wtf/ValueCheck.h:
• StitchMarker/wtf/Vector.h:

(WTF::minCapacity>::checkConsistency):

• StitchMarker/wtf/text/AtomicStringImpl.cpp:
• StitchMarker/wtf/text/AtomicStringImpl.h:
• StitchMarker/wtf/text/StringCommon.h:

(WTF::hasPrefixWithLettersIgnoringASCIICaseCommon):

• StitchMarker/wtf/text/StringImpl.h:
• StitchMarker/wtf/text/SymbolImpl.h:
• StitchMarker/wtf/text/UniquedStringImpl.h:

Source/JavaScriptCore:
Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.
​https://bugs.webkit.org/show_bug.cgi?id=205776

Reviewed by Saam Barati.

• API/tests/testapi.c:
• assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::replaceWithLoad):
(JSC::ARM64Assembler::replaceWithAddressComputation):

• assembler/AssemblerBuffer.h:

(JSC::AssemblerBuffer::LocalWriter::LocalWriter):

• assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::copyCompactAndLinkCode):

• assembler/ProbeStack.cpp:

(JSC::Probe::Stack::Stack):

• assembler/ProbeStack.h:
• b3/B3FoldPathConstants.cpp:
• b3/B3LowerToAir.cpp:
• b3/B3MemoryValue.cpp:

(JSC::B3::MemoryValue::MemoryValue):

• b3/B3Opcode.cpp:
• b3/B3Type.h:
• b3/B3TypeMap.h:
• b3/B3Width.h:
• b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:

(JSC::B3::Air::GenerateAndAllocateRegisters::prepareForGeneration):
(JSC::B3::Air::GenerateAndAllocateRegisters::generate):

• b3/air/AirAllocateRegistersAndStackAndGenerateCode.h:
• b3/air/AirAllocateRegistersByGraphColoring.cpp:
• b3/air/AirArg.cpp:
• b3/air/AirArg.h:
• b3/air/AirCode.h:
• b3/air/AirEmitShuffle.cpp:

(JSC::B3::Air::emitShuffle):

• builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::createExecutable):

• bytecode/AccessCase.cpp:
• bytecode/AccessCase.h:
• bytecode/CallVariant.cpp:

(JSC::variantListWithVariant):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::ensureCatchLivenessIsComputedForBytecodeIndex):

• bytecode/CodeBlockHash.cpp:

(JSC::CodeBlockHash::dump const):

• bytecode/StructureStubInfo.cpp:
• bytecode/StructureStubInfo.h:
• bytecompiler/NodesCodegen.cpp:

(JSC::FunctionCallResolveNode::emitBytecode):

• bytecompiler/RegisterID.h:

(JSC::RegisterID::RegisterID):
(JSC::RegisterID::setIndex):

• debugger/Debugger.cpp:

(JSC::Debugger::removeBreakpoint):

• debugger/DebuggerEvalEnabler.h:

(JSC::DebuggerEvalEnabler::DebuggerEvalEnabler):
(JSC::DebuggerEvalEnabler::~DebuggerEvalEnabler):

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::observeTransitions):

• dfg/DFGAbstractValue.cpp:
• dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::checkConsistency const):
(JSC::DFG::AbstractValue::assertIsRegistered const):

• dfg/DFGArithMode.h:

(JSC::DFG::doesOverflow):

• dfg/DFGBasicBlock.cpp:

(JSC::DFG::BasicBlock::BasicBlock):

• dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::didLink):

• dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::performBlockCFA):

• dfg/DFGCommon.h:

(JSC::DFG::validationEnabled):

• dfg/DFGCommonData.cpp:

(JSC::DFG::CommonData::finalizeCatchEntrypoints):

• dfg/DFGDesiredWatchpoints.h:
• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGEdge.h:

(JSC::DFG::Edge::makeWord):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::finalizeOSREntrypoints):

• dfg/DFGObjectAllocationSinkingPhase.cpp:
• dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run):

• dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::assertClear):

• dfg/DFGSlowPathGenerator.h:

(JSC::DFG::SlowPathGenerator::generate):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::emitBinarySwitchStringRecurse):
(JSC::DFG::SpeculativeJIT::emitAllocateButterfly):
(JSC::DFG::SpeculativeJIT::compileAllocateNewArrayWithSize):
(JSC::DFG::SpeculativeJIT::compileMakeRope):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateCell):

• dfg/DFGStructureAbstractValue.cpp:
• dfg/DFGStructureAbstractValue.h:

(JSC::DFG::StructureAbstractValue::assertIsRegistered const):

• dfg/DFGVarargsForwardingPhase.cpp:
• dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

• ftl/FTLLink.cpp:

(JSC::FTL::link):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::callPreflight):
(JSC::FTL::DFG::LowerDFGToB3::callCheck):
(JSC::FTL::DFG::LowerDFGToB3::crash):

• ftl/FTLOperations.cpp:

(JSC::FTL::operationMaterializeObjectInOSR):

• heap/BlockDirectory.cpp:

(JSC::BlockDirectory::assertNoUnswept):

• heap/GCSegmentedArray.h:

(JSC::GCArraySegment::GCArraySegment):

• heap/GCSegmentedArrayInlines.h:

(JSC::GCSegmentedArray<T>::clear):
(JSC::GCSegmentedArray<T>::expand):
(JSC::GCSegmentedArray<T>::validatePrevious):

• heap/HandleSet.cpp:
• heap/HandleSet.h:
• heap/Heap.cpp:

(JSC::Heap::updateAllocationLimits):

• heap/Heap.h:
• heap/MarkedBlock.cpp:
• heap/MarkedBlock.h:

(JSC::MarkedBlock::assertValidCell const):
(JSC::MarkedBlock::assertMarksNotStale):

• heap/MarkedSpace.cpp:

(JSC::MarkedSpace::beginMarking):
(JSC::MarkedSpace::endMarking):
(JSC::MarkedSpace::assertNoUnswept):

• heap/PreciseAllocation.cpp:
• heap/PreciseAllocation.h:

(JSC::PreciseAllocation::assertValidCell const):

• heap/SlotVisitor.cpp:

(JSC::SlotVisitor::SlotVisitor):
(JSC::SlotVisitor::appendJSCellOrAuxiliary):

• heap/SlotVisitor.h:
• inspector/InspectorProtocolTypes.h:

(Inspector::Protocol::BindingTraits<JSON::ArrayOf<T>>::assertValueHasExpectedType):

• inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:

(CppProtocolTypesImplementationGenerator._generate_assertion_for_object_declaration):
(CppProtocolTypesImplementationGenerator):
(CppProtocolTypesImplementationGenerator._generate_assertion_for_enum):

• inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result:
• interpreter/FrameTracers.h:

(JSC::JITOperationPrologueCallFrameTracer::JITOperationPrologueCallFrameTracer):

• interpreter/Interpreter.cpp:

(JSC::Interpreter::Interpreter):

• interpreter/Interpreter.h:
• jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitStoreStructureWithTypeInfo):

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::prepareCallOperation):

• jit/BinarySwitch.cpp:

(JSC::BinarySwitch::BinarySwitch):

• jit/CCallHelpers.h:

(JSC::CCallHelpers::setupStubArgs):

• jit/CallFrameShuffler.cpp:

(JSC::CallFrameShuffler::emitDeltaCheck):
(JSC::CallFrameShuffler::prepareAny):

• jit/JIT.cpp:

(JSC::JIT::assertStackPointerOffset):
(JSC::JIT::compileWithoutLinking):

• jit/JITOpcodes.cpp:

(JSC::JIT::emitSlow_op_loop_hint):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_from_scope):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_from_scope):

• jit/Repatch.cpp:

(JSC::linkPolymorphicCall):

• jit/ThunkGenerators.cpp:

(JSC::emitPointerValidation):

• llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

• llint/LLIntOfflineAsmConfig.h:
• parser/Lexer.cpp:
• parser/Lexer.h:

(JSC::isSafeBuiltinIdentifier):
(JSC::Lexer<T>::lexExpectIdentifier):

• runtime/ArgList.h:

(JSC::MarkedArgumentBuffer::setNeedsOverflowCheck):
(JSC::MarkedArgumentBuffer::clearNeedsOverflowCheck):

• runtime/Butterfly.h:

(JSC::ContiguousData::ContiguousData):
(JSC::ContiguousData::Data::Data):

• runtime/HashMapImpl.h:

(JSC::HashMapImpl::checkConsistency const):
(JSC::HashMapImpl::assertBufferIsEmpty const):

• runtime/JSCellInlines.h:

(JSC::JSCell::methodTable const):

• runtime/JSFunction.cpp:
• runtime/JSFunction.h:

(JSC::JSFunction::assertTypeInfoFlagInvariants):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• runtime/JSGlobalObject.h:
• runtime/JSObject.cpp:

(JSC::JSObject::visitChildren):
(JSC::JSFinalObject::visitChildren):

• runtime/JSObjectInlines.h:

(JSC::JSObject::validatePutOwnDataProperty):

• runtime/JSSegmentedVariableObject.h:

(JSC::JSSegmentedVariableObject::assertVariableIsInThisObject):

• runtime/LiteralParser.cpp:

(JSC::LiteralParser<CharType>::Lexer::lex):

• runtime/LiteralParser.h:
• runtime/Operations.h:

(JSC::scribbleFreeCells):

• runtime/OptionsList.h:
• runtime/VM.cpp:

(JSC::VM::computeCanUseJIT):

• runtime/VM.h:

(JSC::VM::canUseJIT):

• runtime/VarOffset.h:

(JSC::VarOffset::checkSanity const):

• runtime/WeakMapImpl.h:

(JSC::WeakMapImpl::checkConsistency const):
(JSC::WeakMapImpl::assertBufferIsEmpty const):

• wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::validateInst):

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::parseAndCompile):

• wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser::validationFail const):

• wasm/WasmLLIntGenerator.cpp:

(JSC::Wasm::LLIntGenerator::checkConsistency):

• wasm/WasmPlan.cpp:

(JSC::Wasm::Plan::tryRemoveContextAndCancelIfLast):

• wasm/WasmSectionParser.h:
• wasm/WasmSections.h:
• wasm/WasmSignatureInlines.h:

(JSC::Wasm::SignatureInformation::get):

• wasm/WasmWorklist.cpp:

(JSC::Wasm::Worklist::enqueue):

• wasm/js/JSToWasm.cpp:

(JSC::Wasm::createJSToWasmWrapper):

• wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::previousInstanceOffset const):

Source/WebCore:
Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.
​https://bugs.webkit.org/show_bug.cgi?id=205776

Reviewed by Saam Barati.

• Modules/fetch/FetchBodySource.cpp:

(WebCore::FetchBodySource::close):

• Modules/fetch/FetchBodySource.h:
• Modules/webdatabase/DatabaseDetails.h:

(WebCore::DatabaseDetails::DatabaseDetails):
(WebCore::DatabaseDetails::operator=):

• Modules/webdatabase/DatabaseTask.cpp:

(WebCore::DatabaseTask::performTask):

• Modules/webdatabase/DatabaseTask.h:
• Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::terminationRequested const):

• Modules/webgpu/WHLSL/AST/WHLSLAddressSpace.h:

(WebCore::WHLSL::AST::TypeAnnotation::TypeAnnotation):

• Modules/webgpu/WHLSL/WHLSLHighZombieFinder.cpp:

(WebCore::WHLSL::findHighZombies):

• Modules/webgpu/WHLSL/WHLSLInferTypes.cpp:

(WebCore::WHLSL::matches):

• Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.cpp:

(WebCore::WHLSL::checkLiteralTypes):

• Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp:

(WebCore::WHLSL::FindAllTypes::appendNamedType):

• bindings/js/JSCallbackData.h:
• bindings/js/JSLazyEventListener.cpp:
• bindings/js/JSLazyEventListener.h:
• contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::compileRuleList):

• css/CSSCalculationValue.cpp:

(WebCore::CSSCalcOperationNode::primitiveType const):

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

• css/CSSPrimitiveValue.cpp:
• css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText const):

• css/CSSStyleSheet.cpp:
• dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::suspendIfNeeded):
(WebCore::ActiveDOMObject::assertSuspendIfNeededWasCalled const):

• dom/ActiveDOMObject.h:
• dom/ContainerNode.cpp:
• dom/ContainerNodeAlgorithms.cpp:
• dom/ContainerNodeAlgorithms.h:
• dom/CustomElementReactionQueue.cpp:
• dom/CustomElementReactionQueue.h:

(WebCore::CustomElementReactionDisallowedScope::CustomElementReactionDisallowedScope):
(WebCore::CustomElementReactionDisallowedScope::~CustomElementReactionDisallowedScope):

• dom/Document.cpp:

(WebCore::Document::hitTest):

• dom/Document.h:

(WebCore::Document::decrementReferencingNodeCount):

• dom/Element.cpp:

(WebCore::Element::addShadowRoot):
(WebCore::Element::getURLAttribute const):
(WebCore::Element::getNonEmptyURLAttribute const):

• dom/Element.h:
• dom/ElementAndTextDescendantIterator.h:

(WebCore::ElementAndTextDescendantIterator::ElementAndTextDescendantIterator):
(WebCore::ElementAndTextDescendantIterator::dropAssertions):
(WebCore::ElementAndTextDescendantIterator::popAncestorSiblingStack):
(WebCore::ElementAndTextDescendantIterator::traverseNextSibling):
(WebCore::ElementAndTextDescendantIterator::traversePreviousSibling):

• dom/ElementDescendantIterator.h:

(WebCore::ElementDescendantIterator::ElementDescendantIterator):
(WebCore::ElementDescendantIterator::dropAssertions):
(WebCore::ElementDescendantIterator::operator++):
(WebCore::ElementDescendantIterator::operator--):
(WebCore::ElementDescendantConstIterator::ElementDescendantConstIterator):
(WebCore::ElementDescendantConstIterator::dropAssertions):
(WebCore::ElementDescendantConstIterator::operator++):

• dom/ElementIterator.h:

(WebCore::ElementIterator<ElementType>::ElementIterator):
(WebCore::ElementIterator<ElementType>::traverseNext):
(WebCore::ElementIterator<ElementType>::traversePrevious):
(WebCore::ElementIterator<ElementType>::traverseNextSibling):
(WebCore::ElementIterator<ElementType>::traversePreviousSibling):
(WebCore::ElementIterator<ElementType>::traverseNextSkippingChildren):
(WebCore::ElementIterator<ElementType>::dropAssertions):
(WebCore::ElementIterator<ElementType>::traverseAncestor):
(WebCore::ElementConstIterator<ElementType>::ElementConstIterator):
(WebCore::ElementConstIterator<ElementType>::traverseNext):
(WebCore::ElementConstIterator<ElementType>::traversePrevious):
(WebCore::ElementConstIterator<ElementType>::traverseNextSibling):
(WebCore::ElementConstIterator<ElementType>::traversePreviousSibling):
(WebCore::ElementConstIterator<ElementType>::traverseNextSkippingChildren):
(WebCore::ElementConstIterator<ElementType>::traverseAncestor):
(WebCore::ElementConstIterator<ElementType>::dropAssertions):

• dom/EventContext.cpp:
• dom/EventContext.h:
• dom/EventListener.h:
• dom/EventPath.cpp:
• dom/EventSender.h:
• dom/EventTarget.cpp:

(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::setAttributeEventListener):
(WebCore::EventTarget::innerInvokeEventListeners):

• dom/Node.cpp:

(WebCore::Node::~Node):
(WebCore::Node::moveNodeToNewDocument):
(WebCore::Node::removedLastRef):

• dom/Node.h:

(WebCore::Node::deref const):

• dom/ScriptDisallowedScope.h:

(WebCore::ScriptDisallowedScope::InMainThread::isEventDispatchAllowedInSubtree):

• dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):

• dom/ScriptExecutionContext.h:
• dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::execute const):

• dom/SlotAssignment.cpp:

(WebCore::SlotAssignment::addSlotElementByName):
(WebCore::SlotAssignment::removeSlotElementByName):
(WebCore::SlotAssignment::resolveSlotsAfterSlotMutation):
(WebCore::SlotAssignment::findFirstSlotElement):

• dom/SlotAssignment.h:
• dom/TreeScopeOrderedMap.cpp:

(WebCore::TreeScopeOrderedMap::add):
(WebCore::TreeScopeOrderedMap::get const):

• dom/TreeScopeOrderedMap.h:
• fileapi/Blob.cpp:
• fileapi/Blob.h:
• history/BackForwardCache.cpp:

(WebCore::BackForwardCache::removeAllItemsForPage):

• history/BackForwardCache.h:
• html/CanvasBase.cpp:

(WebCore::CanvasBase::notifyObserversCanvasDestroyed):

• html/CanvasBase.h:
• html/HTMLCollection.h:

(WebCore::CollectionNamedElementCache::didPopulate):

• html/HTMLSelectElement.cpp:

(WebCore:: const):

• html/HTMLTableRowsCollection.cpp:

(WebCore::assertRowIsInTable):

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::indexForPosition const):

• html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::~CanvasRenderingContext2DBase):

• html/parser/HTMLParserScheduler.cpp:

(WebCore::HTMLParserScheduler::HTMLParserScheduler):
(WebCore::HTMLParserScheduler::suspend):
(WebCore::HTMLParserScheduler::resume):

• html/parser/HTMLParserScheduler.h:
• html/parser/HTMLToken.h:

(WebCore::HTMLToken::beginStartTag):
(WebCore::HTMLToken::beginEndTag):
(WebCore::HTMLToken::endAttribute):

• html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::constructTree):

• html/parser/HTMLTreeBuilder.h:

(WebCore::HTMLTreeBuilder::~HTMLTreeBuilder):

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::geometryForBox const):

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPosition):

• layout/blockformatting/BlockFormattingContext.h:
• layout/displaytree/DisplayBox.cpp:

(WebCore::Display::Box::Box):

• layout/displaytree/DisplayBox.h:

(WebCore::Display::Box::setTopLeft):
(WebCore::Display::Box::setTop):
(WebCore::Display::Box::setLeft):
(WebCore::Display::Box::setContentBoxHeight):
(WebCore::Display::Box::setContentBoxWidth):
(WebCore::Display::Box::setHorizontalMargin):
(WebCore::Display::Box::setVerticalMargin):
(WebCore::Display::Box::setHorizontalComputedMargin):
(WebCore::Display::Box::setBorder):
(WebCore::Display::Box::setPadding):

• layout/displaytree/DisplayInlineRect.h:

(WebCore::Display::InlineRect::InlineRect):
(WebCore::Display::InlineRect::setTopLeft):
(WebCore::Display::InlineRect::setTop):
(WebCore::Display::InlineRect::setBottom):
(WebCore::Display::InlineRect::setLeft):
(WebCore::Display::InlineRect::setWidth):
(WebCore::Display::InlineRect::setHeight):

• layout/displaytree/DisplayLineBox.h:

(WebCore::Display::LineBox::LineBox):
(WebCore::Display::LineBox::setBaselineOffsetIfGreater):
(WebCore::Display::LineBox::resetBaseline):
(WebCore::Display::LineBox::Baseline::Baseline):
(WebCore::Display::LineBox::Baseline::setAscent):
(WebCore::Display::LineBox::Baseline::setDescent):
(WebCore::Display::LineBox::Baseline::reset):

• layout/displaytree/DisplayRect.h:

(WebCore::Display::Rect::Rect):
(WebCore::Display::Rect::setTopLeft):
(WebCore::Display::Rect::setTop):
(WebCore::Display::Rect::setLeft):
(WebCore::Display::Rect::setWidth):
(WebCore::Display::Rect::setHeight):
(WebCore::Display::Rect::setSize):
(WebCore::Display::Rect::clone const):

• layout/floats/FloatingContext.cpp:
• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::CollapsibleContent::collapse):

• layout/tableformatting/TableGrid.cpp:

(WebCore::Layout::TableGrid::Column::setWidthConstraints):
(WebCore::Layout::TableGrid::Column::setLogicalWidth):
(WebCore::Layout::TableGrid::Column::setLogicalLeft):

• layout/tableformatting/TableGrid.h:
• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::continueAfterContentPolicy):
(WebCore::DocumentLoader::attachToFrame):
(WebCore::DocumentLoader::detachFromFrame):
(WebCore::DocumentLoader::addSubresourceLoader):

• loader/DocumentLoader.h:
• loader/ImageLoader.cpp:
• loader/cache/CachedResource.h:
• loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::lruListFor):
(WebCore::MemoryCache::removeFromLRUList):

• page/FrameView.cpp:

(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):

• page/FrameViewLayoutContext.cpp:
• page/FrameViewLayoutContext.h:
• page/Page.cpp:
• page/Page.h:
• page/ViewportConfiguration.cpp:
• page/ViewportConfiguration.h:
• page/mac/EventHandlerMac.mm:

(WebCore::CurrentEventScope::CurrentEventScope):

• platform/DateComponents.cpp:

(WebCore::DateComponents::toStringForTime const):

• platform/ScrollableArea.cpp:
• platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::combineIntoOneSegment const):

• platform/SharedBuffer.h:
• platform/Supplementable.h:
• platform/Timer.cpp:

(WebCore::TimerBase::checkHeapIndex const):
(WebCore::TimerBase::updateHeapIfNeeded):

• platform/graphics/BitmapImage.cpp:
• platform/graphics/BitmapImage.h:
• platform/graphics/Image.h:
• platform/graphics/ShadowBlur.cpp:

(WebCore::ScratchBuffer::ScratchBuffer):
(WebCore::ScratchBuffer::getScratchBuffer):
(WebCore::ScratchBuffer::scheduleScratchBufferPurge):

• platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::setWindow):

• platform/graphics/ca/win/CACFLayerTreeHost.h:
• platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::putData):

• platform/graphics/cocoa/FontCacheCoreText.cpp:
• platform/graphics/gstreamer/GstAllocatorFastMalloc.cpp:

(gstAllocatorFastMallocFree):

• platform/graphics/nicosia/cairo/NicosiaPaintingContextCairo.cpp:

(Nicosia::PaintingContextCairo::ForPainting::ForPainting):

• platform/graphics/nicosia/texmap/NicosiaBackingStoreTextureMapperImpl.cpp:

(Nicosia::BackingStoreTextureMapperImpl::createTile):

• platform/graphics/nicosia/texmap/NicosiaContentLayerTextureMapperImpl.cpp:

(Nicosia::ContentLayerTextureMapperImpl::~ContentLayerTextureMapperImpl):

• platform/graphics/win/GradientDirect2D.cpp:

(WebCore::Gradient::fill):

• platform/graphics/win/ImageBufferDataDirect2D.cpp:

(WebCore::ImageBufferData::putData):

• platform/graphics/win/PathDirect2D.cpp:

(WebCore::Path::appendGeometry):
(WebCore::Path::Path):
(WebCore::Path::operator=):
(WebCore::Path::strokeContains const):
(WebCore::Path::transform):

• platform/graphics/win/PlatformContextDirect2D.cpp:

(WebCore::PlatformContextDirect2D::setTags):

• platform/mediastream/MediaStreamTrackPrivate.h:
• platform/mediastream/RealtimeOutgoingAudioSource.cpp:

(WebCore::RealtimeOutgoingAudioSource::~RealtimeOutgoingAudioSource):

• platform/mediastream/RealtimeOutgoingVideoSource.cpp:

(WebCore::RealtimeOutgoingVideoSource::~RealtimeOutgoingVideoSource):

• platform/network/HTTPParsers.cpp:

(WebCore::isCrossOriginSafeHeader):

• platform/sql/SQLiteDatabase.cpp:
• platform/sql/SQLiteDatabase.h:
• platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::SQLiteStatement):
(WebCore::SQLiteStatement::prepare):
(WebCore::SQLiteStatement::finalize):

• platform/sql/SQLiteStatement.h:
• platform/win/COMPtr.h:
• rendering/ComplexLineLayout.cpp:

(WebCore::ComplexLineLayout::removeInlineBox const):

• rendering/FloatingObjects.cpp:

(WebCore::FloatingObject::FloatingObject):
(WebCore::FloatingObjects::addPlacedObject):
(WebCore::FloatingObjects::removePlacedObject):

• rendering/FloatingObjects.h:
• rendering/GridTrackSizingAlgorithm.cpp:
• rendering/GridTrackSizingAlgorithm.h:
• rendering/LayoutDisallowedScope.cpp:
• rendering/LayoutDisallowedScope.h:
• rendering/RenderBlock.cpp:
• rendering/RenderBlock.h:
• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::removeFloatingObject):
(WebCore::RenderBlockFlow::ensureLineBoxes):

• rendering/RenderBoxModelObject.cpp:
• rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

• rendering/RenderElement.cpp:
• rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::mapToContainer const):

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::placeItemsOnGrid const):
(WebCore::RenderGrid::baselinePosition const):

• rendering/RenderInline.cpp:

(WebCore::RenderInline::willBeDestroyed):

• rendering/RenderLayer.cpp:

(WebCore::ClipRectsCache::ClipRectsCache):
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::updateClipRects):
(WebCore::RenderLayer::calculateClipRects const):

• rendering/RenderLayer.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::traverseVisibleNonCompositedDescendantLayers):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::traverseUnchangedSubtree):
(WebCore::RenderLayerCompositor::updateBackingAndHierarchy):
(WebCore::RenderLayerCompositor::addDescendantsToOverlapMapRecursive const):
(WebCore::RenderLayerCompositor::recursiveRepaintLayer):
(WebCore::RenderLayerCompositor::layerHas3DContent const):

• rendering/RenderLayoutState.cpp:

(WebCore::RenderLayoutState::RenderLayoutState):
(WebCore::RenderLayoutState::computeOffsets):
(WebCore::RenderLayoutState::addLayoutDelta):

• rendering/RenderLayoutState.h:

(WebCore::RenderLayoutState::RenderLayoutState):

• rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::~RenderObject):
(WebCore::RenderObject::clearNeedsLayout):

• rendering/RenderObject.h:
• rendering/RenderQuote.cpp:

(WebCore::quotesForLanguage):

• rendering/RenderTableCell.h:
• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::computeOverflowFromCells):

• rendering/RenderTextLineBoxes.cpp:

(WebCore::RenderTextLineBoxes::checkConsistency const):

• rendering/RenderTextLineBoxes.h:
• rendering/line/BreakingContext.h:

(WebCore::tryHyphenating):

• rendering/style/GridArea.h:

(WebCore::GridSpan::GridSpan):

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::~RenderStyle):

• rendering/style/RenderStyle.h:
• rendering/updating/RenderTreeBuilderRuby.cpp:

(WebCore::RenderTreeBuilder::Ruby::detach):

• rendering/updating/RenderTreePosition.cpp:

(WebCore::RenderTreePosition::computeNextSibling):

• rendering/updating/RenderTreePosition.h:
• svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::Placeholder::Placeholder):
(WebCore::SVGToOTFFontConverter::Placeholder::populate):
(WebCore::SVGToOTFFontConverter::appendCFFTable):
(WebCore::SVGToOTFFontConverter::firstGlyph const):
(WebCore::SVGToOTFFontConverter::appendKERNTable):

• svg/SVGTransformDistance.cpp:

(WebCore::SVGTransformDistance::SVGTransformDistance):
(WebCore::SVGTransformDistance::scaledDistance const):
(WebCore::SVGTransformDistance::addSVGTransforms):
(WebCore::SVGTransformDistance::addToSVGTransform const):
(WebCore::SVGTransformDistance::distance const):

• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::nativeImage):

• testing/InternalSettings.cpp:
• workers/service/ServiceWorkerJob.h:
• worklets/PaintWorkletGlobalScope.h:

(WebCore::PaintWorkletGlobalScope::~PaintWorkletGlobalScope):

• xml/XPathStep.cpp:

Source/WebKit:
Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.
​https://bugs.webkit.org/show_bug.cgi?id=205776

Reviewed by Saam Barati.

• NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::invalidateAndCancel):

• NetworkProcess/NetworkSession.h:
• NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::setCapacity):

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(toNSURLSessionResponseDisposition):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

• Platform/IPC/Connection.cpp:

(IPC::Connection::waitForMessage):

• Platform/IPC/MessageReceiver.h:

(IPC::MessageReceiver::willBeAddedToMessageReceiverMap):
(IPC::MessageReceiver::willBeRemovedFromMessageReceiverMap):

• Platform/IPC/cocoa/ConnectionCocoa.mm:

(IPC::readFromMachPort):

• Platform/mac/MachUtilities.cpp:

(setMachExceptionPort):

• Shared/API/APIClient.h:

(API::Client::Client):

• Shared/API/Cocoa/WKRemoteObjectCoder.mm:
• Shared/Cocoa/ArgumentCodersCocoa.h:
• Shared/SharedStringHashTableReadOnly.cpp:
• UIProcess/BackingStore.cpp:

(WebKit::BackingStore::incorporateUpdate):

• UIProcess/GenericCallback.h:
• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

• UIProcess/PageLoadState.h:

(WebKit::PageLoadState::Transaction::Token::Token):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::~WebPageProxy):

• WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResponse):

• WebProcess/Network/WebResourceLoader.h:
• WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::NetscapePluginStream):
(WebKit::NetscapePluginStream::notifyAndDestroyStream):

• WebProcess/Plugins/Netscape/NetscapePluginStream.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runModal):

• WebProcess/WebProcess.cpp:

(WebKit::checkDocumentsCaptureStateConsistency):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::updateProcessName):

Source/WebKitLegacy:
Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.
​https://bugs.webkit.org/show_bug.cgi?id=205776

Reviewed by Saam Barati.

• Storage/StorageAreaImpl.cpp:

(WebKit::StorageAreaImpl::StorageAreaImpl):
(WebKit::StorageAreaImpl::close):

• Storage/StorageAreaImpl.h:

Source/WebKitLegacy/mac:
Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.
​https://bugs.webkit.org/show_bug.cgi?id=205776

Reviewed by Saam Barati.

• History/WebHistory.mm:

(-[WebHistoryPrivate removeItemForURLString:]):

• WebView/WebFrame.mm:

Source/WebKitLegacy/win:
Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.
​https://bugs.webkit.org/show_bug.cgi?id=205776

Reviewed by Saam Barati.

• WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:

(WKQCA::CAD3DRenderer::swapChain):
(WKQCA::CAD3DRenderer::initialize):

• WebKitQuartzCoreAdditions/CAD3DRenderer.h:
• WebView.cpp:

(WebView::Release):

• WebView.h:

Source/WTF:
Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.
​https://bugs.webkit.org/show_bug.cgi?id=205776

Reviewed by Saam Barati.

This patch did the following changes:

1. Replaced ASSERT_DISABLED with ASSERT_ENABLED. This change does away with the need for the double negative !ASSERT_DISABLED test that is commonly used all over the code, thereby improving code readability.

In Assertions.h, there is also BACKTRACE_DISABLED, ASSERT_MSG_DISABLED,
ASSERT_ARG_DISABLED, FATAL_DISABLED, ERROR_DISABLED, LOG_DISABLED, and
RELEASE_LOG_DISABLED. We should replace those with ..._ENABLED equivalents
as well. We'll do that in another patch. For now, they are left as is to
minimize the size of this patch.
See ​https://bugs.webkit.org/show_bug.cgi?id=205780.

2. Fixed some code was guarded with "#ifndef NDEBUG" that should actually be guarded by "#if ASSERT_ENABLED" instead.

3. In cases where the change is minimal, we move some code around so that we can test for "#if ASSERT_ENABLED" instead of "#if !ASSERT_ENABLED".

• wtf/Assertions.h:
• wtf/AutomaticThread.cpp:

(WTF::AutomaticThread::start):

• wtf/BitVector.h:
• wtf/BlockObjCExceptions.mm:

(ReportBlockedObjCException):

• wtf/BloomFilter.h:
• wtf/CallbackAggregator.h:

(WTF::CallbackAggregator::CallbackAggregator):

• wtf/CheckedArithmetic.h:

(WTF::observesOverflow<AssertNoOverflow>):

• wtf/CheckedBoolean.h:

(CheckedBoolean::CheckedBoolean):
(CheckedBoolean::operator bool):

• wtf/CompletionHandler.h:

(WTF::CompletionHandler<Out):

• wtf/DateMath.cpp:

(WTF::initializeDates):

• wtf/Gigacage.cpp:

(Gigacage::tryAllocateZeroedVirtualPages):

• wtf/HashTable.h:

(WTF::KeyTraits>::checkKey):
(WTF::KeyTraits>::checkTableConsistencyExceptSize const):

• wtf/LoggerHelper.h:
• wtf/NaturalLoops.h:

(WTF::NaturalLoops::headerOf const):

• wtf/NeverDestroyed.h:

(WTF::LazyNeverDestroyed::construct):

• wtf/OptionSet.h:

(WTF::OptionSet::OptionSet):

• wtf/Platform.h:
• wtf/PtrTag.h:
• wtf/RefCounted.h:

(WTF::RefCountedBase::disableThreadingChecks):
(WTF::RefCountedBase::enableThreadingChecksGlobally):
(WTF::RefCountedBase::RefCountedBase):
(WTF::RefCountedBase::applyRefDerefThreadingCheck const):

• wtf/SingleRootGraph.h:

(WTF::SingleRootGraph::assertIsConsistent const):

• wtf/SizeLimits.cpp:
• wtf/StackBounds.h:

(WTF::StackBounds::checkConsistency const):

• wtf/URLParser.cpp:

(WTF::URLParser::URLParser):
(WTF::URLParser::domainToASCII):

• wtf/ValueCheck.h:
• wtf/Vector.h:

(WTF::Malloc>::checkConsistency):

• wtf/WeakHashSet.h:
• wtf/WeakPtr.h:

(WTF::WeakPtrImpl::WeakPtrImpl):
(WTF::WeakPtrFactory::WeakPtrFactory):

• wtf/text/AtomStringImpl.cpp:
• wtf/text/AtomStringImpl.h:
• wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::reifyString const):

• wtf/text/StringBuilder.h:
• wtf/text/StringCommon.h:

(WTF::hasPrefixWithLettersIgnoringASCIICaseCommon):

• wtf/text/StringHasher.h:

(WTF::StringHasher::addCharacters):

• wtf/text/StringImpl.h:
• wtf/text/SymbolImpl.h:
• wtf/text/UniquedStringImpl.h:

Tools:
Remove WebsiteDataStore::setServiceWorkerRegistrationDirectory
​https://bugs.webkit.org/show_bug.cgi?id=205754

Patch by Alex Christensen <​[email protected]> on 2020-01-06
Reviewed by Youenn Fablet.

• TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::websiteDataStore):
(WTR::TestController::platformAdjustContext):

• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::initializeWebViewConfiguration):

File:

• trunk/Source/JavaScriptCore/builtins/BuiltinExecutables.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/builtins/BuiltinExecutables.cpp

@@ -206 +206 @@
     metadata.setEndPosition(positionBeforeLastNewline);
 
-    if (!ASSERT_DISABLED || Options::validateBytecode()) {
+    if (UNLIKELY(ASSERT_ENABLED || Options::validateBytecode())) {
         JSTextPosition positionBeforeLastNewlineFromParser;
         ParserError error;