Changeset 254500 in webkit for trunk/Source/JavaScriptCore/b3

Timestamp:

Jan 14, 2020, 12:40:50 AM (5 years ago)

Author:

[email protected]

Message:

Enable -Wconditional-uninitialized in bmalloc, WTF, JavaScriptCore
<​https://webkit.org/b/206190>
<rdar://problem/58540387>

Reviewed by Mark Lam.

Source/bmalloc:

• Configurations/Base.xcconfig:

(WARNING_CFLAGS): Add -Wconditional-uninitialized.

Source/JavaScriptCore:

Initialize stack variables to fix warnings.

• Configurations/Base.xcconfig:

(WARNING_CFLAGS): Add -Wconditional-uninitialized.

• b3/B3LowerToAir.cpp:

(LowerToAir::appendCAS):

• b3/testb3_4.cpp:

(testLoadAddrShift):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCheckStructureOrEmpty):
Move declaration of notEmpty into if block since it's not used
outside that scope.
(JSC::FTL::DFG::LowerDFGToB3::compileCallDOMGetter):

• ftl/FTLThunks.cpp:

(JSC::FTL::registerClobberCheck):

• wasm/js/WebAssemblyTablePrototype.cpp:

(JSC::webAssemblyTableProtoFuncSet):
variables.

• wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::parseBody):

Source/WTF:

• Configurations/Base.xcconfig:

(WARNING_CFLAGS): Add -Wconditional-uninitialized.

Location:

trunk/Source/JavaScriptCore/b3

Files:

• B3LowerToAir.cpp (modified) (1 diff)
• testb3_4.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/b3/B3LowerToAir.cpp

@@ -2289 +2289 @@
             failure = failBlock;
         }
-        Air::BasicBlock* strongFailBlock;
+        Air::BasicBlock* strongFailBlock = nullptr;
         if (isStrong && hasFence)
             strongFailBlock = newBlock();

trunk/Source/JavaScriptCore/b3/testb3_4.cpp

@@ -848 +848 @@
 
     // Figure out which slot to use while having proper alignment for the shift.
-    int* slot;
-    uintptr_t arg;
+    int* slot = nullptr;
+    uintptr_t arg = 0;
     for (unsigned i = sizeof(slots)/sizeof(slots[0]); i--;) {
         slot = slots + i;