Timestamp:
Oct 2, 2007, 1:49:13 PM (18 years ago)
Author:
darin
Message:

JavaScriptCore:

Reviewed by Adam.

  • add support for GDI objects to OwnPtr; I plan to use this to fix some GDI handle leaks
  • kjs/grammar.y: Change parser to avoid macros that conflict with macros defined in Windows system headers: THIS, DELETE, VOID, IN, and CONST. This is needed because OwnPtr.h will now include <windows.h>.
  • kjs/keywords.table: Ditto.
  • wtf/OwnPtr.h: For PLATFORM(WIN), add support so that OwnPtr can be a GDI handle, and it will call DeleteObject. Also change to use the RemovePointer technique used by RetainPtr, so you can say OwnPtr<HBITMAP> rather than having to pass in the type pointed to by HBITMAP.
  • wtf/OwnPtrWin.cpp: Added. (WebCore::deleteOwnedPtr): Put this in a separate file so that we don't have to include <windows.h> in OwnPtr.h.

WebCore:

Reviewed by Adam.

  • add support for GDI objects to OwnPtr; I plan to use this to fix some GDI handle leaks
  • css/CSSGrammar.y: Change parser to avoid macro that conflicts with macro defined in Windows system headers: FLOAT. This is needed because OwnPtr.h will now include <windows.h>.
  • css/CSSParser.cpp: (WebCore::CSSParser::lex): Ditto.
  • css/tokenizer.flex: Ditto.
  • platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor): Use OwnPtr for a few HBITMAP objects as a test case.
  • platform/win/COMPtr.h: (COMPtr::COMPtr): Fix so that we can use Query with other COMPtr. Before this would not compile if it was ever instantiated.

win:

Reviewed by Adam.

  • started using the new OwnPtr everywhere we do DeleteObject
  • WebNodeHighlight.cpp: (WebNodeHighlight::updateWindow):
  • WebView.cpp: (WebView::WebView): (WebView::deleteBackingStore): (WebView::ensureBackingStore): (WebView::addToDirtyRegion): (WebView::scrollBackingStore): (WebView::updateBackingStore): (WebView::paint): (WebView::paintIntoBackingStore): (WebView::paintIntoWindow):
  • WebView.h:

Also set svn:eol-style on all .vcproj to CRLF.

Also added svn:ignore of *.user for WebKitInitializer.

File:
1 edited

Note: See TracChangeset for help on using the changeset viewer.