Changeset 263635 in webkit for trunk/Source/JavaScriptCore/shell

Timestamp:

Jun 28, 2020, 1:55:08 PM (5 years ago)

Author:

[email protected]

Message:

Rename initializeThreading to initialize
​https://bugs.webkit.org/show_bug.cgi?id=213674

Reviewed by Mark Lam.

Source/JavaScriptCore:

• API/JSClassRef.cpp:
• API/JSContextRef.cpp:

(JSContextGroupCreate):
(JSGlobalContextCreate):
(JSGlobalContextCreateInGroup):

• API/JSObjectRef.cpp:

(JSClassCreate):

• API/JSStringRef.cpp:

(JSStringCreateWithCharacters):
(JSStringCreateWithUTF8CString):
(JSStringCreateWithCharactersNoCopy):

• API/JSStringRefCF.cpp:

(JSStringCreateWithCFString):

• API/tests/CompareAndSwapTest.cpp:

(testCompareAndSwap):

• API/tests/ExecutionTimeLimitTest.cpp:

(testExecutionTimeLimit):

• API/tests/FunctionOverridesTest.cpp:

(testFunctionOverrides):

• API/tests/MultithreadedMultiVMExecutionTest.cpp:

(startMultithreadedMultiVMExecutionTest):

• API/tests/PingPongStackOverflowTest.cpp:

(testPingPongStackOverflow):

• JavaScriptCore.order:
• assembler/testmasm.cpp:

(JSC::run):

• b3/air/testair.cpp:

(main):

• b3/testb3_1.cpp:

(main):

• dfg/testdfg.cpp:

(main):

• dynbench.cpp:

(main):

• inspector/remote/cocoa/RemoteInspectorCocoa.mm:

(Inspector::RemoteInspector::singleton):

• jsc.cpp:

(main):
(jscmain):

• runtime/InitializeThreading.cpp:

(JSC::initialize):
(JSC::initializeThreading): Deleted.

• runtime/InitializeThreading.h:
• runtime/JSCConfig.h:
• shell/playstation/TestShell.cpp:

(setupTestRun):

• testRegExp.cpp:

(main):

Source/WebCore:

• Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabase):

• WebCore.order:
• bindings/js/CommonVM.cpp:

(WebCore::commonVMSlow):

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::initializeMainThread):
(WebCore::ScriptController::initializeThreading): Deleted.

• bindings/js/ScriptController.h:
• bridge/objc/WebScriptObject.mm:

(+[WebScriptObject initialize]):

• platform/cocoa/SharedBufferCocoa.mm:

(+[WebCoreSharedBufferData initialize]):

• platform/ios/wak/WebCoreThread.mm:

(RunWebThread):

Source/WebKit:

• Shared/API/c/WKString.cpp:

(WKStringCopyJSString):

• Shared/Cocoa/WebKit2InitializeCocoa.mm:

(WebKit::runInitializationCode):

• Shared/WebKit2Initialize.cpp:

(WebKit::InitializeWebKit2):

Source/WebKitLegacy/mac:

• History/WebBackForwardList.mm:

(+[WebBackForwardList initialize]):

• History/WebHistoryItem.mm:

(+[WebHistoryItem initialize]):

• Misc/WebCache.mm:

(+[WebCache initialize]):

• Misc/WebElementDictionary.mm:

(+[WebElementDictionary initialize]):

• Misc/WebIconDatabase.mm:
• Misc/WebStringTruncator.mm:

(+[WebStringTruncator initialize]):

• Plugins/Hosted/WebHostedNetscapePluginView.mm:

(+[WebHostedNetscapePluginView initialize]):

• Plugins/WebBaseNetscapePluginView.mm:
• Plugins/WebBasePluginPackage.mm:

(+[WebBasePluginPackage initialize]):

• Plugins/WebNetscapePluginView.mm:

(+[WebNetscapePluginView initialize]):

• WebCoreSupport/WebEditorClient.mm:

(+[WebUndoStep initialize]):

• WebCoreSupport/WebFrameLoaderClient.mm:

(+[WebFramePolicyListener initialize]):

• WebView/WebArchive.mm:

(+[WebArchivePrivate initialize]):

• WebView/WebDataSource.mm:

(+[WebDataSource initialize]):

• WebView/WebHTMLView.mm:

(+[WebHTMLViewPrivate initialize]):
(+[WebHTMLView initialize]):

• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

• WebView/WebResource.mm:

(+[WebResourcePrivate initialize]):

• WebView/WebTextIterator.mm:

(+[WebTextIteratorPrivate initialize]):

• WebView/WebView.mm:

(+[WebView initialize]):

• WebView/WebViewData.mm:

(+[WebViewPrivate initialize]):

Source/WebKitLegacy/win:

• WebKitClassFactory.cpp:

(WebKitClassFactory::WebKitClassFactory):

• WebView.cpp:

(WebView::WebView):

Source/WTF:

Reasons:

(1) You need to call it even if you don't use threads.

(2) It initializes things unrelated to threads (like the PRNG).

(3) People seem to get confused about the relationship between
initializeThreading() and initializeMainThread(), and sometimes think
initializeThreading() is a superset. The opposite is true! I think the
confusion may come from "threading" being read as "all threading".

Some filenames still use the legacy name. We can fix that in post.

• benchmarks/ConditionSpeedTest.cpp:

(main):

• benchmarks/HashSetDFGReplay.cpp:

(main):

• benchmarks/LockFairnessTest.cpp:

(main):

• benchmarks/LockSpeedTest.cpp:

(main):

• wtf/MainThread.cpp:

(WTF::initializeMainThread):

• wtf/Threading.cpp:

(WTF::Thread::create):
(WTF::initialize):
(WTF::initializeThreading): Deleted.

• wtf/Threading.h:

(WTF::Thread::current):

Tools:

• TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:

(ApplicationManifestParserTest::SetUp):

• TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:

(TestWebKitAPI::ComplexTextControllerTest::SetUp):

• TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::ContentExtensionTest::SetUp):

• TestWebKitAPI/Tests/WebCore/StringUtilities.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:

(TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):

• TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:

(WebKitTestServer::WebKitTestServer):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

File:

• trunk/Source/JavaScriptCore/shell/playstation/TestShell.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/shell/playstation/TestShell.cpp

@@ -41 +41 @@
 #undef STATIC_OPTION
 
-    // Need to initialize WTF threading before we start any threads. Cannot initialize JSC
-    // threading yet, since that would do somethings that we'd like to defer until after we
+    // Need to initialize WTF before we start any threads. Cannot initialize JSC
+    // yet, since that would do somethings that we'd like to defer until after we
     // have a chance to parse options.
     WTF::initializeMainThread();
@@ -49 +49 @@
     Config::enableRestrictedOptions();
 
-    JSC::initializeThreading();
+    JSC::initialize();
 
 #if ENABLE(WEBASSEMBLY)