Changeset 266324 in webkit for trunk/Source/JavaScriptCore

Timestamp:

Aug 29, 2020, 1:38:09 AM (5 years ago)

Author:

[email protected]

Message:

[JSC] for-of / for-in left-hand-side target should be simple-assignment-target
​https://bugs.webkit.org/show_bug.cgi?id=215969

Reviewed by Ross Kirsling.

JSTests:

• stress/for-of-in-non-reference.js: Added.

(testSyntax):
(testSyntaxError):
(testSyntaxError.t):
(testSyntaxError.async t):
(testSyntax.async t):

• test262/expectations.yaml:

Source/JavaScriptCore:

Left-hand-side of for-in, for-of, and for-await-of should be simple assignment target[1]
if the target is not declaration and not destructuring pattern.

[1]: ​https://tc39.es/ecma262/#sec-for-in-and-for-of-statements-static-semantics-early-errors

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseForStatement):

• parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createCommaExpr): Should return CommaExpr to align it to ASTBuilder.
(JSC::SyntaxChecker::appendToCommaExpr):
(JSC::SyntaxChecker::appendStatement):
(JSC::SyntaxChecker::combineCommaNodes): Deleted since it is not used.

LayoutTests:

Fix for-in / for-of parser behavior.

• js/basic-strict-mode-expected.txt:
• js/parser-syntax-check-expected.txt:
• js/script-tests/parser-syntax-check.js:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• parser/Parser.cpp (modified) (1 diff)
• parser/SyntaxChecker.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-08-28  Yusuke Suzuki  <[email protected]>
+
+        [JSC] for-of / for-in left-hand-side target should be simple-assignment-target
+        https://bugs.webkit.org/show_bug.cgi?id=215969
+
+        Reviewed by Ross Kirsling.
+
+        Left-hand-side of `for-in`, `for-of`, and `for-await-of` should be simple assignment target[1]
+        if the target is not declaration and not destructuring pattern.
+
+        [1]: https://tc39.es/ecma262/#sec-for-in-and-for-of-statements-static-semantics-early-errors
+
+        * parser/Parser.cpp:
+        (JSC::Parser<LexerType>::parseForStatement):
+        * parser/SyntaxChecker.h:
+        (JSC::SyntaxChecker::createCommaExpr): Should return CommaExpr to align it to ASTBuilder.
+        (JSC::SyntaxChecker::appendToCommaExpr):
+        (JSC::SyntaxChecker::appendStatement):
+        (JSC::SyntaxChecker::combineCommaNodes): Deleted since it is not used.
+
 2020-08-28  Yusuke Suzuki  <[email protected]>
 

trunk/Source/JavaScriptCore/parser/Parser.cpp

@@ -1543 +1543 @@
         return result;
     }
+
+    semanticFailIfFalse(isSimpleAssignmentTarget(context, decls), "Left side of assignment is not a reference");
     if (isOfEnumeration)
         result = context.createForOfLoop(isAwaitFor, location, decls, expr, statement, declLocation, declsStart, declsEnd, exprEnd, startLine, endLine, *lexicalVariables);

trunk/Source/JavaScriptCore/parser/SyntaxChecker.h

@@ -148 +148 @@
     int createSourceElements() { return SourceElementsResult; }
     ExpressionType makeFunctionCallNode(const JSTokenLocation&, ExpressionType, bool, int, int, int, int, size_t, bool) { return CallExpr; }
-    ExpressionType createCommaExpr(const JSTokenLocation&, ExpressionType expr) { return expr; }
-    ExpressionType appendToCommaExpr(const JSTokenLocation&, ExpressionType& head, ExpressionType, ExpressionType next) { head = next; return next; }
+    ExpressionType createCommaExpr(const JSTokenLocation&, ExpressionType) { return CommaExpr; }
+    ExpressionType appendToCommaExpr(const JSTokenLocation&, ExpressionType, ExpressionType, ExpressionType) { return CommaExpr; }
     ExpressionType makeAssignNode(const JSTokenLocation&, ExpressionType, Operator, ExpressionType, bool, bool, int, int, int) { return AssignmentExpr; }
     ExpressionType makePrefixNode(const JSTokenLocation&, ExpressionType, Operator, int, int, int) { return PreExpr; }
@@ -302 +302 @@
 
     void appendStatement(int, int) { }
-    int combineCommaNodes(const JSTokenLocation&, int, int) { return CommaExpr; }
     int evalCount() const { return 0; }
     void appendBinaryExpressionInfo(int& operandStackDepth, int expr, int, int, int, bool)