Changeset 26676 in webkit for trunk/JavaScriptCore/JavaScriptCore.xcodeproj

Timestamp:

Oct 16, 2007, 1:13:24 PM (18 years ago)

Author:

darin

Message:

JavaScriptCore:

Reviewed by Maciej and Geoff (and looked over by Eric).

• ​http://bugs.webkit.org/show_bug.cgi?id=15519 eliminate use of <ctype.h> for processing ASCII

• wtf/ASCIICType.h: Added.
• wtf/DisallowCType.h: Added.

• kjs/config.h: Include DisallowCType.h.

• kjs/date_object.cpp: (KJS::skipSpacesAndComments): (KJS::findMonth): (KJS::parseDate):
• kjs/function.cpp: (KJS::decode):
• kjs/ustring.cpp: (KJS::UString::toDouble): Use ASCIICType.h functions instead of ctype.h ones.

WebCore:

Reviewed by Maciej and Geoff (and looked over by Eric).

• ​http://bugs.webkit.org/show_bug.cgi?id=15519 eliminate use of <ctype.h> for processing ASCII

• ForwardingHeaders/wtf/ASCIICType.h: Added.
• ForwardingHeaders/wtf/DisallowCType.h: Added.

• WebCorePrefix.h: Get rid of inclusion of <ctype.h>.
• config.h: Include DisallowCType.h.

• css/CSSParser.cpp: (WebCore::ParseString::lower):
• css/CSSPrimitiveValue.cpp: (WebCore::isCSSTokenizerIdentifier):
• css/CSSStyleDeclaration.cpp: (WebCore::propertyID):
• html/HTMLSelectElement.cpp: (WebCore::stripLeadingWhiteSpace):
• html/HTMLTokenizer.cpp: (WebCore::tagMatch):
• loader/FTPDirectoryParser.cpp: (WebCore::parseOneFTPLine):
• loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset):
• platform/DeprecatedCString.cpp: (WebCore::DeprecatedCString::lower): (WebCore::DeprecatedCString::upper): (WebCore::DeprecatedCString::find): (WebCore::DeprecatedCString::contains):
• platform/DeprecatedString.cpp: (WebCore::equalCaseInsensitive): (WebCore::isCharacterAllowedInBase): (WebCore::DeprecatedString::find): (WebCore::DeprecatedString::contains): (WebCore::toIntegralType):
• platform/DeprecatedString.h: (WebCore::DeprecatedChar::isSpace): (WebCore::DeprecatedChar::lower): (WebCore::DeprecatedChar::upper):
• platform/KURL.cpp: (WebCore::KURL::parse):
• platform/StringImpl.cpp: (WebCore::isSpace): (WebCore::StringImpl::containsOnlyWhitespace): (WebCore::StringImpl::isLower): (WebCore::StringImpl::lower): (WebCore::StringImpl::find): (WebCore::StringImpl::reverseFind): (WebCore::equalIgnoringCase):
• platform/TextEncodingRegistry.cpp: (WebCore::TextEncodingNameHash::equal): (WebCore::TextEncodingNameHash::hash): (WebCore::atomicCanonicalTextEncodingName):
• platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent):
• platform/win/KeyEventWin.cpp: (WebCore::keyIdentifierForWindowsKeyCode):
• platform/win/PopupMenuWin.cpp: (WebCore::isASCIIPrintable): (WebCore::PopupWndProc):
• plugins/win/PluginViewWin.cpp: (WebCore::capitalizeRFC822HeaderFieldName):
• rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): Use ASCIICType.h functions instead of ctype.h ones.

WebKit:

Reviewed by Maciej and Geoff (and looked over by Eric).

• ​http://bugs.webkit.org/show_bug.cgi?id=15519 eliminate use of <ctype.h> for processing ASCII

• ForwardingHeaders/wtf/ASCIICType.h: Added.
• ForwardingHeaders/wtf/DisallowCType.h: Added.

• WebKitPrefix.h: Include DisallowCType.h.

• Misc/WebNSURLExtras.mm: (-[NSURL _web_URLWithLowercasedScheme]): Use toASCIILower.
• WebView/WebHTMLView.mm: (-[WebHTMLView callWebCoreCommand:]): Use toASCIIUpper. (-[WebTextCompleteController filterKeyDown:]): Add a list of specific character codes, instead of using ispunct.

File:

• trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj (modified) (5 diffs)

trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

@@ -218 +218 @@
                 935AF46E09E9D9DB00ACD1D8 /* UnusedParam.h in Headers */ = {isa = PBXBuildFile; fileRef = 935AF46B09E9D9DB00ACD1D8 /* UnusedParam.h */; };
                 935F69FE08245057003D1A45 /* dftables.c in Sources */ = {isa = PBXBuildFile; fileRef = 6541720E039E08B90058BFEB /* dftables.c */; };
+                938C4F6A0CA06BC700D9310A /* ASCIICType.h in Headers */ = {isa = PBXBuildFile; fileRef = 938C4F690CA06BC700D9310A /* ASCIICType.h */; settings = {ATTRIBUTES = (Private, ); }; };
+                938C4F6C0CA06BCE00D9310A /* DisallowCType.h in Headers */ = {isa = PBXBuildFile; fileRef = 938C4F6B0CA06BCE00D9310A /* DisallowCType.h */; settings = {ATTRIBUTES = (Private, ); }; };
                 93AA4F780957251F0084B3A7 /* AlwaysInline.h in Headers */ = {isa = PBXBuildFile; fileRef = 93AA4F770957251F0084B3A7 /* AlwaysInline.h */; settings = {ATTRIBUTES = (Private, ); }; };
                 93B6A0DF0AA64DA40076DE27 /* GetPtr.h in Headers */ = {isa = PBXBuildFile; fileRef = 93B6A0DE0AA64DA40076DE27 /* GetPtr.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -570 +572 @@
                 937B63CC09E766D200A671DD /* DerivedSources.make */ = {isa = PBXFileReference; explicitFileType = sourcecode.make; fileEncoding = 4; path = DerivedSources.make; sourceTree = "<group>"; usesTabs = 1; };
                 938772E5038BFE19008635CE /* array_instance.h */ = {isa = PBXFileReference; fileEncoding = 4; indentWidth = 4; lastKnownFileType = sourcecode.c.h; path = array_instance.h; sourceTree = "<group>"; tabWidth = 8; };
+                938C4F690CA06BC700D9310A /* ASCIICType.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ASCIICType.h; sourceTree = "<group>"; };
+                938C4F6B0CA06BCE00D9310A /* DisallowCType.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DisallowCType.h; sourceTree = "<group>"; };
                 93AA4F770957251F0084B3A7 /* AlwaysInline.h */ = {isa = PBXFileReference; fileEncoding = 4; indentWidth = 4; lastKnownFileType = sourcecode.c.h; path = AlwaysInline.h; sourceTree = "<group>"; tabWidth = 8; };
                 93B6A0DE0AA64DA40076DE27 /* GetPtr.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = GetPtr.h; sourceTree = "<group>"; };
@@ -897 +901 @@
                         isa = PBXGroup;
                         children = (
-                                652246A40C8D7A0E007BDAF7 /* HashIterators.h */,
                                 E195678D09E7CF1200B89D13 /* unicode */,
                                 93AA4F770957251F0084B3A7 /* AlwaysInline.h */,
+                                938C4F690CA06BC700D9310A /* ASCIICType.h */,
                                 65E217B808E7EECC0023E5F6 /* Assertions.cpp */,
                                 65E217B708E7EECC0023E5F6 /* Assertions.h */,
+                                938C4F6B0CA06BCE00D9310A /* DisallowCType.h */,
                                 65E217B908E7EECC0023E5F6 /* FastMalloc.cpp */,
                                 65E217BA08E7EECC0023E5F6 /* FastMalloc.h */,
@@ -909 +914 @@
                                 657EEBBF094E445E008C9C7B /* HashCountedSet.h */,
                                 65DFC92A08EA173A00F7300B /* HashFunctions.h */,
+                                652246A40C8D7A0E007BDAF7 /* HashIterators.h */,
                                 65DFC92B08EA173A00F7300B /* HashMap.h */,
                                 65DFC92C08EA173A00F7300B /* HashSet.h */,
@@ -1254 +1260 @@
                                 652246A50C8D7A0E007BDAF7 /* HashIterators.h in Headers */,
                                 95C18D490C90E82600E72F73 /* JSRetainPtr.h in Headers */,
+                                938C4F6A0CA06BC700D9310A /* ASCIICType.h in Headers */,
+                                938C4F6C0CA06BCE00D9310A /* DisallowCType.h in Headers */,
                         );
                         runOnlyForDeploymentPostprocessing = 0;