Changeset 268374 in webkit for trunk/Source/JavaScriptCore/bytecompiler

Timestamp:

Oct 12, 2020, 4:02:40 PM (5 years ago)

Author:

[email protected]

Message:

OpToPropertyKey only accepts temporary for destination
​https://bugs.webkit.org/show_bug.cgi?id=217471

Reviewed by Saam Barati.

JSTests:

• stress/spread-to-property-key-constant.js: Added.

Source/JavaScriptCore:

propertyName register can be constant. We should create temporary register if it is necessary for the destination.

• bytecompiler/NodesCodegen.cpp:

(JSC::ObjectPatternNode::bindValue const):

File:

• trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp

@@ -5235 +5235 @@
                 if (m_containsComputedProperty) {
                     if (target.propertyExpression)
-                        generator.emitToPropertyKey(propertyName.get(), propertyName.get());
+                        propertyName = generator.emitToPropertyKey(generator.tempDestination(propertyName.get()), propertyName.get());
                     else
                         propertyName = generator.emitLoad(nullptr, target.propertyName);