Changeset 27022 in webkit for trunk/JavaScriptCore/bindings

Timestamp:

Oct 24, 2007, 11:38:35 PM (18 years ago)

Author:

eseidel

Message:

2007-10-24 Eric Seidel <​[email protected]>

Reviewed by Maciej.

Add a JSGlobalObject class and remove the InterpreterMap
​http://bugs.webkit.org/show_bug.cgi?id=15681

This required making JSCallbackObject a template class to allow for
JSGlobalObjects with JSCallbackObject functionality.

SunSpider claims this was a 0.5% speedup.

• API/JSCallbackObject.cpp: (KJS::):
• API/JSCallbackObject.h:
• API/JSCallbackObjectFunctions.h: Copied from API/JSCallbackObject.cpp. (KJS::::JSCallbackObject): (KJS::::init): (KJS::::~JSCallbackObject): (KJS::::initializeIfNeeded): (KJS::::className): (KJS::::getOwnPropertySlot): (KJS::::put): (KJS::::deleteProperty): (KJS::::implementsConstruct): (KJS::::construct): (KJS::::implementsHasInstance): (KJS::::hasInstance): (KJS::::implementsCall): (KJS::::callAsFunction): (KJS::::getPropertyNames): (KJS::::toNumber): (KJS::::toString): (KJS::::setPrivate): (KJS::::getPrivate): (KJS::::inherits): (KJS::::cachedValueGetter): (KJS::::staticValueGetter): (KJS::::staticFunctionGetter): (KJS::::callbackGetter):
• API/JSClassRef.cpp: (OpaqueJSClass::prototype):
• API/JSContextRef.cpp: (JSGlobalContextCreate):
• API/JSObjectRef.cpp: (JSObjectMake): (JSObjectGetPrivate): (JSObjectSetPrivate):
• API/JSValueRef.cpp: (JSValueIsObjectOfClass):
• JavaScriptCore.exp:
• JavaScriptCore.xcodeproj/project.pbxproj:
• bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant):
• bindings/jni/jni_jsobject.cpp:
• bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):
• kjs/Context.cpp: (KJS::Context::Context):
• kjs/ExecState.cpp: (KJS::ExecState::lexicalInterpreter):
• kjs/JSGlobalObject.h: Added. (KJS::JSGlobalObject::JSGlobalObject): (KJS::JSGlobalObject::isGlobalObject): (KJS::JSGlobalObject::interpreter): (KJS::JSGlobalObject::setInterpreter):
• kjs/array_instance.cpp:
• kjs/context.h:
• kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::GlobalFuncImp::callAsFunction):
• kjs/interpreter.cpp: (KJS::Interpreter::Interpreter): (KJS::Interpreter::init): (KJS::Interpreter::~Interpreter): (KJS::Interpreter::globalObject): (KJS::Interpreter::initGlobalObject): (KJS::Interpreter::evaluate):
• kjs/interpreter.h:
• kjs/lookup.h: (KJS::cacheGlobalObject):
• kjs/object.h: (KJS::JSObject::isGlobalObject):
• kjs/testkjs.cpp:

Location:

trunk/JavaScriptCore/bindings

Files:

• c/c_utility.cpp (modified) (2 diffs)
• jni/jni_jsobject.cpp (modified) (1 diff)
• objc/objc_utility.mm (modified) (2 diffs)

trunk/JavaScriptCore/bindings/c/c_utility.cpp

@@ -32 +32 @@
 
 #include "NP_jsobject.h"
-#include "c_instance.h" 
+#include "c_instance.h"
+#include "JSGlobalObject.h"
 #include "npruntime_impl.h"
 #include "npruntime_priv.h"
@@ -131 +132 @@
 
             Interpreter* interpreter = 0;
-            if (originInterpreter->isGlobalObject(value)) {
-                interpreter = originInterpreter->interpreterForGlobalObject(value);
-            }
+            if (object->isGlobalObject())
+                interpreter = static_cast<JSGlobalObject*>(object)->interpreter();
 
             if (!interpreter)

trunk/JavaScriptCore/bindings/jni/jni_jsobject.cpp

@@ -31 +31 @@
 #include "jni_runtime.h"
 #include "jni_utility.h"
+#include "JSGlobalObject.h"
 #include "list.h"
 #include "runtime_object.h"

trunk/JavaScriptCore/bindings/objc/objc_utility.mm

@@ -28 +28 @@
 
 #include "objc_instance.h"
+#include "JSGlobalObject.h"
 #include "runtime_array.h"
 #include "runtime_object.h"
@@ -141 +142 @@
 
             Interpreter *interpreter = 0;
-            if (originInterpreter->isGlobalObject(value))
-                interpreter = originInterpreter->interpreterForGlobalObject(value);
+            if (value->isObject() && static_cast<JSObject*>(value)->isGlobalObject())
+                interpreter = static_cast<JSGlobalObject*>(value)->interpreter();
 
             if (!interpreter)