Changeset 272892 in webkit for trunk/Source/JavaScriptCore/offlineasm

Timestamp:

Feb 15, 2021, 5:51:50 PM (4 years ago)

Author:

[email protected]

Message:

[ARM64] Change break instruction comment to indicate possible security failure
​https://bugs.webkit.org/show_bug.cgi?id=221936

Reviewed by Mark Lam.

Source/bmalloc:

Change the ASSERT break comment immediate to the same value the C++ compiler uses.

• bmalloc/BAssert.h:

Source/JavaScriptCore:

We change the comment value to indicate a possible security issue by
using the same value the C++ compiler emits.

• assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::breakpoint):

• disassembler/ARM64/A64DOpcode.cpp:

(JSC::ARM64Disassembler::A64OpcodeExceptionGeneration::format):

• disassembler/ARM64/A64DOpcode.h:

(JSC::ARM64Disassembler::A64OpcodeExceptionGeneration::immediate16):

• offlineasm/arm64.rb:

Source/WTF:

Change the ASSERT break comment immediate to the same value the C++ compiler uses.

• wtf/Assertions.cpp:
• wtf/Assertions.h:

File:

• trunk/Source/JavaScriptCore/offlineasm/arm64.rb (modified) (1 diff)

trunk/Source/JavaScriptCore/offlineasm/arm64.rb

@@ -1017 +1017 @@
             end
         when "break"
-            $asm.puts "brk \#0"
+            $asm.puts "brk \#0xc471"
         when "ret"
             $asm.puts "ret"