Changeset 27733 in webkit for trunk/JavaScriptCore

Timestamp:

Nov 12, 2007, 4:22:49 PM (18 years ago)

Author:

Darin Adler

Message:

JavaScriptCore:

Reviewed by Sam.

• ​http://bugs.webkit.org/show_bug.cgi?id=15951 REGRESSION: assertion failure in regexp match() when running JS tests

Test: fast/js/regexp-many-brackets.html

• pcre/pcre_exec.cpp: (match): Added back accidentally-removed case for the BRANUMBER opcode.

LayoutTests:

Reviewed by Sam.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=15951 REGRESSION: assertion failure in regexp match() when running JS tests

• fast/js/regexp-many-brackets-expected.txt: Added.
• fast/js/regexp-many-brackets.html: Added.
• fast/js/resources/regexp-many-brackets.js: Added.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• pcre/pcre_exec.cpp (modified) (2 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2007-11-12  Darin Adler  <[email protected]>
+
+        Reviewed by Sam.
+
+        - http://bugs.webkit.org/show_bug.cgi?id=15951
+          REGRESSION: assertion failure in regexp match() when running JS tests
+
+        Test: fast/js/regexp-many-brackets.html
+
+        * pcre/pcre_exec.cpp: (match): Added back accidentally-removed case for
+        the BRANUMBER opcode.
+
 2007-11-12  Darin Adler  <[email protected]>
 

trunk/JavaScriptCore/pcre/pcre_exec.cpp

@@ -447 +447 @@
     RRETURN;
 
+    /* Skip over large extraction number data if encountered. */
+
+    BEGIN_OPCODE(BRANUMBER):
+    frame->ecode += 3;
+    NEXT_OPCODE;
+
     /* End of the pattern. */
 
@@ -1853 +1859 @@
     /* Control never gets here */
 
-    BEGIN_OPCODE(BRANUMBER):
     BEGIN_OPCODE(CRMINPLUS):
     BEGIN_OPCODE(CRMINQUERY):