Changeset 27810 in webkit for trunk/JavaScriptCore/wtf

Timestamp:

Nov 14, 2007, 9:59:40 PM (18 years ago)

Author:

[email protected]

Message:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15982
Improve JSString UTF-8 decoding

• API/JSStringRef.cpp: (JSStringCreateWithUTF8CString): Use strict decoding, return 0 on error.

• wtf/unicode/UTF8.cpp: (WTF::Unicode::convertUTF16ToUTF8): (WTF::Unicode::convertUTF8ToUTF16):
• wtf/unicode/UTF8.h: Made these function names start with a lower case letter.

• kjs/ustring.cpp: (KJS::UString::UTF8String): Updated for the above renaming.

• bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16WithLatin1Fallback): Renamed to highlight the difference from convertUTF8ToUTF16 in wtf/unicode. (KJS::Bindings::convertNPStringToUTF16): Updated for the above renaming. (KJS::Bindings::identifierFromNPIdentifier): Ditto.
• bindings/c/c_utility.h: Made convertUTF8ToUTF16WithLatin1Fallback() a file static.

Location:

trunk/JavaScriptCore/wtf/unicode

Files:

• UTF8.cpp (modified) (2 diffs)
• UTF8.h (modified) (1 diff)

trunk/JavaScriptCore/wtf/unicode/UTF8.cpp

@@ -120 +120 @@
 static const unsigned char firstByteMark[7] = { 0x00, 0x00, 0xC0, 0xE0, 0xF0, 0xF8, 0xFC };
 
-ConversionResult ConvertUTF16ToUTF8(
+ConversionResult convertUTF16ToUTF8(
     const UChar** sourceStart, const UChar* sourceEnd, 
     char** targetStart, char* targetEnd, bool strict)
@@ -231 +231 @@
             0x03C82080UL, 0xFA082080UL, 0x82082080UL };
 
-ConversionResult ConvertUTF8ToUTF16(
+ConversionResult convertUTF8ToUTF16(
     const char** sourceStart, const char* sourceEnd, 
     UChar** targetStart, UChar* targetEnd, bool strict)

trunk/JavaScriptCore/wtf/unicode/UTF8.h

@@ -63 +63 @@
     // they constitute an error.
 
-    ConversionResult ConvertUTF8ToUTF16(
+    ConversionResult convertUTF8ToUTF16(
                     const char** sourceStart, const char* sourceEnd, 
                     UChar** targetStart, UChar* targetEnd, bool strict = true);
 
-    ConversionResult ConvertUTF16ToUTF8(
+    ConversionResult convertUTF16ToUTF8(
                     const UChar** sourceStart, const UChar* sourceEnd, 
                     char** targetStart, char* targetEnd, bool strict = true);