Changeset 27879 in webkit for trunk/JavaScriptCore

Timestamp:

Nov 17, 2007, 3:14:40 PM (18 years ago)

Author:

[email protected]

Message:

2007-11-17 Alp Toker <​[email protected]>

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=16032
JS minidom is not portable

Use a plain UTF-8 string instead of a CFString.

Print to stdout, not stderr like CFShow() would have done, since that
behaviour seems unintentional.

• API/minidom.c: (main):

Location:

trunk/JavaScriptCore

Files:

• API/minidom.c (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/JavaScriptCore/API/minidom.c

@@ -2 +2 @@
 /*
  * Copyright (C) 2006 Apple Computer, Inc.  All rights reserved.
+ * Copyright (C) 2007 Alp Toker <[email protected]>
  *
  * Redistribution and use in source and binary forms, with or without
@@ -26 +27 @@
 
 #include "JSNode.h"
+#include <stdio.h>
+#include <stdlib.h>
 #include <wtf/Assertions.h>
 #include <wtf/UnusedParam.h>
@@ -57 +60 @@
         printf("FAIL: Test script threw exception:\n");
         JSStringRef exceptionIString = JSValueToStringCopy(context, exception, NULL);
-        CFStringRef exceptionCF = JSStringCopyCFString(kCFAllocatorDefault, exceptionIString);
-        CFShow(exceptionCF);
-        CFRelease(exceptionCF);
+        size_t exceptionUTF8Size = JSStringGetMaximumUTF8CStringSize(exceptionIString);
+        char* exceptionUTF8 = (char*)malloc(exceptionUTF8Size);
+        JSStringGetUTF8CString(exceptionIString, exceptionUTF8, exceptionUTF8Size);
+        printf("%s\n", exceptionUTF8);
+        free(exceptionUTF8);
         JSStringRelease(exceptionIString);
     }

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2007-11-17  Alp Toker  <[email protected]>
+
+        Reviewed by Eric.
+
+        http://bugs.webkit.org/show_bug.cgi?id=16032
+        JS minidom is not portable
+
+        Use a plain UTF-8 string instead of a CFString.
+
+        Print to stdout, not stderr like CFShow() would have done, since that
+        behaviour seems unintentional.
+
+        * API/minidom.c:
+        (main):
+
 2007-11-17  Steve Falkenburg  <[email protected]>