Changeset 2791 in webkit for trunk/JavaScriptCore

Timestamp:

Nov 20, 2002, 4:21:24 PM (23 years ago)

Author:

mjs

Message:

Reduced the size of ValueImp by 8 bytes for a .5% speedup.

• kjs/value.h: Removed destructed flag. Made refcount and flag 16 bits each.
• kjs/value.cpp: (ValueImp::~ValueImp): Don't set destructed flag.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• ChangeLog-2002-12-03 (modified) (1 diff)
• ChangeLog-2003-10-25 (modified) (1 diff)
• kjs/value.cpp (modified) (1 diff)
• kjs/value.h (modified) (3 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2002-11-20  Maciej Stachowiak  <[email protected]>
+
+        Reduced the size of ValueImp by 8 bytes for a .5% speedup.
+        
+        * kjs/value.h: Removed destructed flag. Made refcount and flag 16
+        bits each.
+        * kjs/value.cpp:
+        (ValueImp::~ValueImp): Don't set destructed flag.
+
 2002-11-20  Darin Adler  <[email protected]>
 

trunk/JavaScriptCore/ChangeLog-2002-12-03

@@ +1 @@
+2002-11-20  Maciej Stachowiak  <[email protected]>
+
+        Reduced the size of ValueImp by 8 bytes for a .5% speedup.
+        
+        * kjs/value.h: Removed destructed flag. Made refcount and flag 16
+        bits each.
+        * kjs/value.cpp:
+        (ValueImp::~ValueImp): Don't set destructed flag.
+
 2002-11-20  Darin Adler  <[email protected]>
 

trunk/JavaScriptCore/ChangeLog-2003-10-25

@@ +1 @@
+2002-11-20  Maciej Stachowiak  <[email protected]>
+
+        Reduced the size of ValueImp by 8 bytes for a .5% speedup.
+        
+        * kjs/value.h: Removed destructed flag. Made refcount and flag 16
+        bits each.
+        * kjs/value.cpp:
+        (ValueImp::~ValueImp): Don't set destructed flag.
+
 2002-11-20  Darin Adler  <[email protected]>
 

trunk/JavaScriptCore/kjs/value.cpp

@@ -54 +54 @@
 {
   //fprintf(stderr,"ValueImp::~ValueImp %p\n",(void*)this);
-  _flags |= VI_DESTRUCTED;
 }
 

trunk/JavaScriptCore/kjs/value.h

@@ -96 +96 @@
     ValueImp* ref() { if (!SimpleNumber::is(this)) refcount++; return this; }
     bool deref() { if (SimpleNumber::is(this)) return false; else return (!--refcount); }
-    unsigned int refcount;
 
     virtual void mark();
@@ -128 +127 @@
     Object dispatchToObject(ExecState *exec) const;
 
-  private:
+    unsigned short int refcount;
+
+  private:
+    unsigned short int _flags;
+
     virtual Type type() const = 0;
 
@@ -143 +146 @@
       VI_MARKED = 1,
       VI_GCALLOWED = 2,
-      VI_CREATED = 4,
-      VI_DESTRUCTED = 8
+      VI_CREATED = 4
     }; // VI means VALUEIMPL
 
-    ValueImpPrivate *_vd;
-    unsigned int _flags;
-    
     // Give a compile time error if we try to copy one of these.
     ValueImp(const ValueImp&);