Changeset 281665 in webkit for trunk/Source/JavaScriptCore/bytecompiler

Timestamp:

Aug 26, 2021, 3:43:32 PM (4 years ago)

Author:

[email protected]

Message:

r281485 was not sufficient in where it called disablePeepholeOptimization
​https://bugs.webkit.org/show_bug.cgi?id=229582
<rdar://82346980>

Reviewed by Yusuke Suzuki.

JSTests:

• stress/for-in-disable-bytecode-generator-peephole-optimizations-after-rewrite-2.js: Added.

(foo):

Source/JavaScriptCore:

r281485 accidentally deleted a place where we called disablePeepholeOptimization
that was necessary. Basically, after we seek where the current instruction
in BytecodeGenerator is, we need to disablePeepholeOptimization.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::ForInContext::finalize):

File:

• trunk/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp

@@ -5387 +5387 @@
 
         generator.m_writer.seek(branchInstIndex);
+        generator.disablePeepholeOptimization();
 
         OpJmp::emit(&generator, BoundLabel(static_cast<int>(newBranchTarget) - static_cast<int>(branchInstIndex)));
@@ -5394 +5395 @@
     }
 
+    generator.m_writer.seek(generator.m_writer.size());
     generator.disablePeepholeOptimization(); // We might've just changed the last bytecode that was emitted.
-
-    generator.m_writer.seek(generator.m_writer.size());
 }