Changeset 288492 in webkit for trunk/Source/JavaScriptCore

Timestamp:

Jan 24, 2022, 5:11:15 PM (3 years ago)

Author:

Patrick Angle

Message:

Web Inspector: [Flexbox] Add instrumentation/protocol bits for flex layout containers
​https://bugs.webkit.org/show_bug.cgi?id=235454

Reviewed by Devin Rousso.

Source/JavaScriptCore:

• inspector/protocol/CSS.json:

Source/WebCore:

Added tests in inspector/css/nodeLayoutContextTypeChanged.html.

Add instrumentation to RenderFlexibleBox to observe elements becoming/ceasing to be flex containers. We only
instrument RenderFlexibleBox created with an Element, not a Document, since all anonymous nodes will have their
document passed, which means we would attempt to track multiple different nodes against the same document,
resulting in unexpected results. Conversely, we only instrument in the destructor for non-anonymous nodes.

• inspector/agents/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::layoutContextTypeForRenderer):

• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::RenderFlexibleBox):
(WebCore::RenderFlexibleBox::~RenderFlexibleBox):

Source/WebInspectorUI:

• UserInterface/Models/DOMNode.js:

LayoutTests:

• inspector/css/nodeLayoutContextTypeChanged-expected.txt:
• inspector/css/nodeLayoutContextTypeChanged.html:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/protocol/CSS.json (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2022-01-24  Patrick Angle  <[email protected]>
+
+        Web Inspector: [Flexbox] Add instrumentation/protocol bits for flex layout containers
+        https://bugs.webkit.org/show_bug.cgi?id=235454
+
+        Reviewed by Devin Rousso.
+
+        * inspector/protocol/CSS.json:
+
 2022-01-24  Mikhail R. Gadelha  <[email protected]>
 

trunk/Source/JavaScriptCore/inspector/protocol/CSS.json

@@ -258 +258 @@
             "id": "LayoutContextType",
             "type": "string",
-            "enum": ["grid"],
+            "enum": ["flex", "grid"],
             "description": "The layout context type of a node."
         },