Changeset 288541 in webkit for trunk/Source/JavaScriptCore

Timestamp:

Jan 24, 2022, 10:15:32 PM (3 years ago)

Author:

[email protected]

Message:

Rename Vector and FixedVector::findMatching to findIf to match stl naming.
​https://bugs.webkit.org/show_bug.cgi?id=234864
rdar://87424746

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

• bytecompiler/NodesCodegen.cpp:

(JSC::ArrayPatternNode::emitDirectBinding):

Source/WebCore:

• Modules/async-clipboard/Clipboard.cpp:

(WebCore::Clipboard::getType):

• Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:

(WebCore::ClipboardItemBindingsDataSource::getType):
(WebCore::ClipboardItemBindingsDataSource::collectDataForWriting):

• Modules/cache/DOMCacheStorage.cpp:

(WebCore::DOMCacheStorage::match):
(WebCore::DOMCacheStorage::has):
(WebCore::DOMCacheStorage::findCacheOrCreate):
(WebCore::DOMCacheStorage::doOpen):
(WebCore::DOMCacheStorage::doRemove):

• Modules/highlight/Highlight.cpp:

(WebCore::Highlight::addToSetLike):

• Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::showMediaControlsContextMenu):

• Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::trackEnded):

• Modules/mediastream/RTCController.cpp:

(WebCore::RTCController::shouldDisableICECandidateFiltering):

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::setConfiguration):
(WebCore::RTCPeerConnection::getOrCreateIceTransport):
(WebCore::RTCPeerConnection::getOrCreateDtlsTransport):

• Modules/mediastream/RTCRtpSFrameTransformer.cpp:

(WebCore::RTCRtpSFrameTransformer::decryptFrame):

• Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::checkNumberOfChannelsForInput):

• Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::cancelAndHoldAtTime):

• Modules/webaudio/IIRFilterNode.cpp:

(WebCore::IIRFilterNode::create):

• Modules/webauthn/fido/U2fCommandConstructor.cpp:

(fido::isConvertibleToU2fRegisterCommand):

• Modules/webxr/WebXRInputSourceArray.cpp:

(WebCore::WebXRInputSourceArray::handleAddedOrUpdatedInputSources):

• Modules/webxr/WebXRSession.cpp:

(WebCore::WebXRSession::cancelAnimationFrame):

• Modules/webxr/WebXRSystem.cpp:

(WebCore::WebXRSystem::ensureImmersiveXRDeviceIsSelected):

• accessibility/AXObjectCache.cpp:

(WebCore::appendIfNotContainsMatching):

• accessibility/atspi/AccessibilityAtspi.cpp:

(WebCore::AccessibilityAtspi::shouldEmitSignal):

• dom/DataTransfer.cpp:

(WebCore::DataTransfer::types const):

• dom/DataTransferItemList.cpp:

(WebCore::removeStringItemOfLowercasedType):

• dom/Document.cpp:

(WebCore::Document::addPendingScrollEventTarget):
(WebCore::Document::updateIntersectionObservations):

• dom/EventPath.cpp:

(WebCore:: const):

• dom/MutationObserver.cpp:

(WebCore::MutationObserver::enqueueSlotChangeEvent):

• html/BaseTextInputType.cpp:

(WebCore::BaseTextInputType::patternMismatch const):

• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::cancelVideoFrameCallback):

• html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::fieldIndexOf const):
(WebCore::DateTimeEditElement::focusedFieldElement const):
(WebCore::DateTimeEditElement::didBlurFromField):

• html/track/InbandDataTextTrack.cpp:

(WebCore::InbandDataTextTrack::findIncompleteCue):

• inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::indexForData):

• inspector/agents/WebDebuggerAgent.cpp:

(WebCore::WebDebuggerAgent::didAddEventListener):
(WebCore::WebDebuggerAgent::willRemoveEventListener):

• layout/floats/FloatingState.cpp:

(WebCore::Layout::FloatingState::append):

• layout/integration/LayoutIntegrationBoxTree.cpp:

(WebCore::LayoutIntegration::BoxTree::layoutBoxForRenderer):
(WebCore::LayoutIntegration::BoxTree::rendererForLayoutBox):

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startIconLoading):

• page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::isObserving const):

• page/ModalContainerObserver.cpp:

(WebCore::ModalContainerObserver::collectClickableElementsTimerFired):

• page/ResizeObserver.cpp:

(WebCore::ResizeObserver::observe):

• page/scrolling/ScrollLatchingController.cpp:

(WebCore::ScrollLatchingController::removeLatchingStateForTarget):

• page/scrolling/ScrollSnapOffsetsInfo.cpp:

(WebCore::hasCompatibleSnapArea):

• page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::removeChild):

• platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::preferredImageMIMETypeForEncoding):

• platform/PasteboardCustomData.cpp:

(WebCore::PasteboardCustomData::addOrMoveEntryToEnd):
(WebCore::PasteboardCustomData::hasSameOriginCustomData const):

• platform/cocoa/PasteboardCocoa.mm:

(WebCore::Pasteboard::fileContentState):

• platform/encryptedmedia/CDMProxy.cpp:

(WebCore::KeyStore::containsKeyID const):
(WebCore::KeyStore::add):

• platform/graphics/DisplayRefreshMonitorManager.cpp:

(WebCore::DisplayRefreshMonitorManager::findMonitorForDisplayID const):

• platform/graphics/HEVCUtilities.cpp:

(WebCore::createHEVCCodecParametersString):

• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::mediaEngine):
(WebCore::MediaPlayer::nextMediaEngine):

• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceFairPlayStreamingAVFObjC::sessionForKeyIDs const):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::sessionForRequest const):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::sessionForGroup const):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::animationIsRunning const):
(WebCore::GraphicsLayerCA::platformCALayerAnimationStarted):
(WebCore::GraphicsLayerCA::isRunningTransformAnimation const):

• platform/graphics/coretext/FontCoreText.cpp:

(WebCore::Font::isProbablyOnlyUsedToRenderIcons const):

• platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::getEGLConfig):

• platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:

(WebCore::GStreamerRegistryScanner::isContentTypeSupported const):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::shouldHaveBackingStore const):

• platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::fileContentState):

• platform/mediastream/CaptureDevice.h:

(WebCore::haveDevicesChanged):

• platform/mediastream/MediaConstraints.h:

(WebCore::NumericConstraint::valueForDiscreteCapabilityValues const):

• platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:

(WebKitMediaStreamObserver::didRemoveTrack):

• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::generatePresets):

• platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::getUncommonHeader const):
(WebCore::HTTPHeaderMap::setUncommonHeader):
(WebCore::HTTPHeaderMap::add):
(WebCore::HTTPHeaderMap::contains const):
(WebCore::HTTPHeaderMap::get const):
(WebCore::HTTPHeaderMap::set):

• platform/xr/openxr/OpenXRExtensions.cpp:

(PlatformXR::OpenXRExtensions::isExtensionSupported const):

• plugins/PluginData.h:

(WebCore::isSupportedPlugin):

Source/WebKit:

• GPUProcess/media/RemoteCDMFactoryProxy.cpp:

(WebKit::factoryForKeySystem):

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::findRootNetworkActivity):
(WebKit::NetworkConnectionToWebProcess::findNetworkActivityTracker):

• NetworkProcess/cache/CacheStorageEngineCache.cpp:

(WebKit::CacheStorage::Cache::storeRecords):
(WebKit::CacheStorage::Cache::put):
(WebKit::CacheStorage::Cache::remove):
(WebKit::CacheStorage::Cache::removeFromRecordList):
(WebKit::CacheStorage::Cache::updateRecordToDisk):

• NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::find):
(WebKit::CacheStorage::Caches::remove):
(WebKit::CacheStorage::Caches::hasActiveCache const):
(WebKit::CacheStorage::Caches::dispose):

• Shared/mac/MediaFormatReader/MediaFormatReader.cpp:

(WebKit::MediaFormatReader::didProvideMediaData):

• UIProcess/API/glib/WebKitWebView.cpp:

(webkit_web_view_remove_frame_displayed_callback):

• UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:

(WebKit::WebPasteboardProxy::PasteboardAccessInformation::grantAccess):
(WebKit::WebPasteboardProxy::PasteboardAccessInformation::accessType const):

• UIProcess/UserMediaPermissionRequestProxy.cpp:

(WebKit::setDeviceAsFirst):

• UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:

(WebKit::LocalAuthenticator::makeCredential):
(WebKit::LocalAuthenticator::getAssertion):
(WebKit::LocalAuthenticator::deleteDuplicateCredential const):

• UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:

(WebKit::CtapAuthenticator::continueGetNextAssertionAfterResponseReceived):

• UIProcess/ios/DragDropInteractionState.mm:

(WebKit::DragDropInteractionState::defaultDropPreview const):
(WebKit::BlockPtr<void):

• UIProcess/mac/DisplayLink.cpp:

(WebKit::DisplayLink::setPreferredFramesPerSecond):

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::getContextMenuFromItems):

• UIProcess/mac/WebDataListSuggestionsDropdownMac.mm:

(shouldShowDividersBetweenCells):

• WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::computeElementLayout):

• WebProcess/UserContent/WebUserContentController.cpp:

(WebKit::WebUserContentController::addUserScriptMessageHandlerInternal):
(WebKit::WebUserContentController::addUserScriptInternal):
(WebKit::WebUserContentController::addUserStyleSheetInternal):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::requestTextRecognition):

• WebProcess/WebProcess.cpp:

(WebKit::checkDocumentsCaptureStateConsistency):

Source/WTF:

Also rename reverseFindMatching to reverseFindIf.

See ​https://bugs.webkit.org/show_bug.cgi?id=234855#c3 and
​https://en.cppreference.com/w/cpp/algorithm/find.

• wtf/FixedVector.h:

(WTF::FixedVector<T>::findIf const):
(WTF::FixedVector<T>::find const):
(WTF::FixedVector<T>::findMatching const): Deleted.

• wtf/Vector.h:

(WTF::Malloc>::findIf const):
(WTF::Malloc>::find const):
(WTF::Malloc>::reverseFindIf const):
(WTF::Malloc>::findMatching const): Deleted.
(WTF::Malloc>::reverseFindMatching const): Deleted.

Tools:

• TestWebKitAPI/Tests/WTF/FixedVector.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WTF/Vector.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:

(TestWebKitAPI::parseUserAgent):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::closeOtherPage):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• bytecompiler/NodesCodegen.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2022-01-24  Mark Lam  <[email protected]>
+
+        Rename Vector and FixedVector::findMatching to findIf to match stl naming.
+        https://bugs.webkit.org/show_bug.cgi?id=234864
+        rdar://87424746
+
+        Reviewed by Yusuke Suzuki.
+
+        * bytecompiler/NodesCodegen.cpp:
+        (JSC::ArrayPatternNode::emitDirectBinding):
+
 2022-01-24  Yusuke Suzuki  <[email protected]>
 

trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp

@@ -2 +2 @@
 *  Copyright (C) 1999-2002 Harri Porten ([email protected])
 *  Copyright (C) 2001 Peter Kelly ([email protected])
-*  Copyright (C) 2003-2019 Apple Inc. All rights reserved.
+*  Copyright (C) 2003-2022 Apple Inc. All rights reserved.
 *  Copyright (C) 2007 Cameron Zwarich ([email protected])
 *  Copyright (C) 2007 Maks Orlovich
@@ -5352 +5352 @@
         return nullptr;
 
-    if (m_targetPatterns.findMatching([&] (auto& target) { return target.bindingType == BindingType::RestElement; }) != notFound)
+    if (m_targetPatterns.findIf([&] (auto& target) { return target.bindingType == BindingType::RestElement; }) != notFound)
         return nullptr;