Changeset 289780 in webkit for trunk/Source/JavaScriptCore/builtins

Timestamp:

Feb 14, 2022, 4:14:28 PM (3 years ago)

Author:

[email protected]

Message:

Array#{ groupBy, groupByToMap } should throw a TypeError when this is null or undefined
​https://bugs.webkit.org/show_bug.cgi?id=236541

Reviewed by Alexey Shvayka.

JSTests:

• stress/array-group-by-null-or-undefined.js: Added.

(shouldThrow):

Source/JavaScriptCore:

While we are correctly using @toObject, these functions missed "use strict", which enforces a function
to change a non object |this| to an object (in this case, global object). This patch adds "use strict",
to make these function strict code.

• builtins/ArrayPrototype.js:

(groupBy):
(groupByToMap):

File:

• trunk/Source/JavaScriptCore/builtins/ArrayPrototype.js (modified) (2 diffs)

trunk/Source/JavaScriptCore/builtins/ArrayPrototype.js

@@ -159 +159 @@
 function groupBy(callback /*, thisArg */)
 {
+    "use strict";
+
     var array = @toObject(this, "Array.prototype.groupBy requires that |this| not be null or undefined");
     var length = @toLength(array.length);
@@ -183 +185 @@
 function groupByToMap(callback /*, thisArg */)
 {
+    "use strict";
+
     var array = @toObject(this, "Array.prototype.groupByToMap requires that |this| not be null or undefined");
     var length = @toLength(array.length);