Changeset 290359 in webkit for trunk/Source/JavaScriptCore/assembler

Timestamp:

Feb 23, 2022, 1:28:47 AM (4 years ago)

Author:

Adrian Perez de Castro

Message:

Ensure generated inline assembler that setups segments returns to previous state
​https://bugs.webkit.org/show_bug.cgi?id=236976

Reviewed by Yusuke Suzuki.

Use .previous in inline assembler in order to ensure that mixed emission of assembler
functions and other definitions correctly puts each of them in their rightful sections
in the output object code.

• assembler/MacroAssemblerARM64.cpp:
• assembler/MacroAssemblerARMv7.cpp:
• assembler/MacroAssemblerMIPS.cpp:
• assembler/MacroAssemblerX86Common.cpp:

Location:

trunk/Source/JavaScriptCore/assembler

Files:

• MacroAssemblerARM64.cpp (modified) (1 diff)
• MacroAssemblerARMv7.cpp (modified) (1 diff)
• MacroAssemblerMIPS.cpp (modified) (1 diff)
• MacroAssemblerX86Common.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/assembler/MacroAssemblerARM64.cpp

@@ -573 +573 @@
     "ret" "\n"
 #endif
+    ".previous" "\n"
 );
 #endif // COMPILER(GCC_COMPATIBLE)

trunk/Source/JavaScriptCore/assembler/MacroAssemblerARMv7.cpp

@@ -362 +362 @@
     "ldr       sp, [sp, #" STRINGIZE_VALUE_OF(PROBE_CPU_SP_OFFSET) "]" "\n"
     "pop       { pc }" "\n"
+    ".previous" "\n"
 );
 #endif // COMPILER(GCC_COMPATIBLE)

trunk/Source/JavaScriptCore/assembler/MacroAssemblerMIPS.cpp

@@ -550 +550 @@
     "nop" "\n"
     ".set pop" "\n"
+    ".previous" "\n"
 );
 #endif // COMPILER(GCC_COMPATIBLE)

trunk/Source/JavaScriptCore/assembler/MacroAssemblerX86Common.cpp

@@ -342 +342 @@
     "popl %ebp" "\n"
     "ret" "\n"
+    ".previous" "\n"
 );
 #endif
@@ -710 +711 @@
     "popq %rbp" "\n"
     "ret" "\n"
+    ".previous" "\n"
 );
 #endif // COMPILER(GCC_COMPATIBLE)