Changeset 291745 in webkit for trunk/Source/JavaScriptCore/assembler

Timestamp:

Mar 23, 2022, 7:12:54 AM (3 years ago)

Author:

[email protected]

Message:

[JSC] Add DoNotHaveTagRegisters mode to unboxDouble
​https://bugs.webkit.org/show_bug.cgi?id=238018

Patch by Xan Lopez <Xan Lopez> on 2022-03-23
Reviewed by Yusuke Suzuki.

Wasm cannot use unboxDouble as-is because
GPRInfo::numberTagRegister is not available. Add a
DoNotHaveTagRegister mode so we can get rid of some duplicated
code.

• assembler/MacroAssembler.h:

(JSC::MacroAssembler::add64):

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::unboxDoubleWithoutAssertions):
(JSC::AssemblyHelpers::unboxDouble):

• wasm/js/WasmToJS.cpp:

(JSC::Wasm::wasmToJS):

File:

• trunk/Source/JavaScriptCore/assembler/MacroAssembler.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/assembler/MacroAssembler.h

@@ -154 +154 @@
 
 #if CPU(ARM64) || CPU(X86_64) || CPU(RISCV64)
+    using MacroAssemblerBase::add64;
     using MacroAssemblerBase::and64;
     using MacroAssemblerBase::convertInt32ToDouble;
@@ -1461 +1462 @@
     }
 
+    void add64(TrustedImm64 imm, RegisterID src, RegisterID dest)
+    {
+        RegisterID scratch = scratchRegister();
+        move(imm, scratch);
+        add64(scratch, src, dest);
+    }
 #endif // USE(JSVALUE64)