Changeset 2974 in webkit for trunk/JavaScriptCore/kjs

Timestamp:

Dec 9, 2002, 8:21:10 AM (22 years ago)

Author:

mjs

Message:

Reviewed by Ken.

• fixed 3059637 - all articles missing at excite.com sports page
• fixed 3065903 - most of content missing at excite.com news page

These bugs both came up because a JavaScript function has a var
declaration that collides with a function parameter name.

• kjs/nodes.cpp: (VarDeclNode::processVarDecls): Don't set the property to undefined if a property with that name is already set on the global object. Otherwise we may clobber function parameters with undefined even before hitting a possible var initializer.

File:

• trunk/JavaScriptCore/kjs/nodes.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -1658 +1658 @@
 {
   Object variable = exec->context().imp()->variableObject();
-  variable.put(exec,ident, Undefined(), DontDelete);
+
+  // If a variable by this name already exists, don't clobber it -
+  // it might be a function parameter
+  if (!variable.hasProperty(exec, ident)) {
+    variable.put(exec,ident, Undefined(), DontDelete);
+  }
 }