Changeset 3018 in webkit for trunk/JavaScriptCore/kjs

Timestamp:

Dec 12, 2002, 2:38:17 AM (22 years ago)

Author:

mjs

Message:

JavaScriptCore:

Reviewed by Darin.

• fixed 3056449 - can't select state at tucows.com

• kjs/array_instance.h:
• kjs/array_object.cpp: (ArrayInstanceImp::propList): Add numeric proprties that are in special storage.
• kjs/array_object.h:
• kjs/object.h: Make propList a virtual method.

WebCore:

Reviewed by Darin.

• force-js-clean-timestamp: Update for JavaScriptCore changes.

Location:

trunk/JavaScriptCore/kjs

Files:

• array_instance.h (modified) (1 diff)
• array_object.cpp (modified) (1 diff)
• object.h (modified) (1 diff)

trunk/JavaScriptCore/kjs/array_instance.h

@@ -41 +41 @@
     virtual bool deleteProperty(ExecState *exec, const Identifier &propertyName);
     virtual bool deleteProperty(ExecState *exec, unsigned propertyName);
+    virtual ReferenceList propList(ExecState *exec, bool recursive);
 
     virtual void mark();

trunk/JavaScriptCore/kjs/array_object.cpp

@@ -196 +196 @@
   return ObjectImp::deleteProperty(exec, Identifier::from(index));
 }
+
+ReferenceList ArrayInstanceImp::propList(ExecState *exec, bool recursive)
+{
+  ReferenceList properties = ObjectImp::propList(exec,recursive);
+
+  // avoid fetching this every time through the loop
+  ValueImp *undefined = UndefinedImp::staticUndefined;
+
+  for (unsigned i = 0; i < storageLength; ++i) {
+    ValueImp *imp = storage[i];
+    if (imp && imp != undefined) {
+      properties.append(Reference(this, i));
+    }
+  }
+  return properties;
+}
+
 
 void ArrayInstanceImp::resizeStorage(unsigned newLength)

trunk/JavaScriptCore/kjs/object.h

@@ -573 +573 @@
     void setScope(const ScopeChain &s) { _scope = s; }
 
-    ReferenceList propList(ExecState *exec, bool recursive = true);
+    virtual ReferenceList propList(ExecState *exec, bool recursive = true);
 
     Value internalValue() const;