Changeset 31121 in webkit for trunk/JavaScriptCore/kjs

Timestamp:

Mar 18, 2008, 2:42:58 AM (17 years ago)

Author:

[email protected]

Message:

2008-03-18 Maciej Stachowiak <​[email protected]>

Reviewed by Oliver.

• a few micro-optimizations for 1.2% SunSpider speedup

• kjs/function.cpp: (KJS::FunctionImp::callAsFunction): check for Return completion before Throw, it is more likely.
• kjs/object.cpp: (KJS::JSObject::put): When walking prototype chain, instead of checking isObject (a virtual call), compare to jsNull (compare to a constant) since null is the only non-object that can be in a prototype chain.

Location:

trunk/JavaScriptCore/kjs

Files:

• function.cpp (modified) (1 diff)
• object.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/function.cpp

@@ -75 +75 @@
     FunctionExecState newExec(exec->dynamicGlobalObject(), thisObj, body.get(), exec, this, args);
     JSValue* result = body->execute(&newExec);
+    if (newExec.completionType() == ReturnValue)
+        return result;
     if (newExec.completionType() == Throw) {
         exec->setException(result);
         return result;
     }
-    if (newExec.completionType() == ReturnValue)
-        return result;
     return jsUndefined();
 }

trunk/JavaScriptCore/kjs/object.cpp

@@ -230 +230 @@
     }
       
-    if (!obj->_proto->isObject())
+    if (obj->_proto == jsNull())
       break;