Changeset 31350 in webkit for trunk/JavaScriptCore/API/testapi.js

Timestamp:

Mar 26, 2008, 8:35:40 PM (17 years ago)

Author:

Adam Roben

Message:

Fix Bug 18060: Assertion failure (JSLock not held) beneath JSCallbackObject<Base>::toString

<​http://bugs.webkit.org/show_bug.cgi?id=18060>

Reviewed by Geoff Garen.

Bug fix:

• API/JSCallbackObjectFunctions.h: (KJS::JSCallbackObject<Base>::toString): Make the DropAllLocks instance only be in scope while calling convertToType.

Test:

• API/testapi.c: (MyObject_convertToType): Implement type conversion to string.
• API/testapi.js: Add a test for type conversion to string.

File:

• trunk/JavaScriptCore/API/testapi.js (modified) (1 diff)

trunk/JavaScriptCore/API/testapi.js

@@ -101 +101 @@
 shouldBe("+MyObject", 1); // toNumber
 shouldBe("(MyObject.toString())", "[object MyObject]"); // toString
+shouldBe("String(MyObject)", "MyObjectAsString"); // type conversion to string
 shouldBe("MyObject - 0", NaN); // toPrimitive