Changeset 32877 in webkit for trunk/JavaScriptCore

Timestamp:

May 5, 2008, 9:59:05 AM (17 years ago)

Author:

Darin Adler

Message:

2008-05-05 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

• fix debug-only leak seen on buildbot

• wtf/HashTable.h: (WTF::HashTable::checkKey): After writing an empty value in, but before constructing a deleted value on top of it, call the destructor so the empty value doesn't leak.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wtf/HashTable.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-05-05  Darin Adler  <[email protected]>
+
+        Reviewed by John Sullivan.
+
+        - fix debug-only leak seen on buildbot
+
+        * wtf/HashTable.h:
+        (WTF::HashTable::checkKey): After writing an empty value in, but before constructing a
+        deleted value on top of it, call the destructor so the empty value doesn't leak.
+
 2008-05-02  Alexey Proskuryakov  <[email protected]>
 

trunk/JavaScriptCore/wtf/HashTable.h

@@ -444 +444 @@
         ASSERT(!HashTranslator::equal(KeyTraits::emptyValue(), key));
         ValueType deletedValue = Traits::emptyValue();
+        deletedValue.~ValueType();
         Traits::constructDeletedValue(&deletedValue);
         ASSERT(!HashTranslator::equal(Extractor::extract(deletedValue), key));