Changeset 34073 in webkit for trunk/JavaScriptCore

Timestamp:

May 23, 2008, 3:43:08 AM (17 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2008-05-23 Maciej Stachowiak <​[email protected]>

Reviewed by Oliver.

• fixed <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com

• VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): Delete any existing properties before creating the function (this should really be done at execution time not codegen time).

LayoutTests:

2008-05-23 Maciej Stachowiak <​[email protected]>

Reviewed by Oliver.

• test case <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com

• fast/js/function-redefinition-expected.txt: Added.
• fast/js/function-redefinition.html: Added.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• VM/CodeGenerator.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-05-23  Maciej Stachowiak  <[email protected]>
+
+        Reviewed by Oliver.
+        
+        - fixed <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com
+
+        * VM/CodeGenerator.cpp:
+        (KJS::CodeGenerator::CodeGenerator): Delete any existing
+        properties before creating the function (this should really be
+        done at execution time not codegen time).
+
 2008-05-16  Alp Toker  <[email protected]>
 

trunk/JavaScriptCore/VM/CodeGenerator.cpp

@@ -207 +207 @@
         for (size_t i = 0; i < functionStack.size(); ++i) {
             FuncDeclNode* funcDecl = functionStack[i];
+            if (globalObject->hasProperty(exec, funcDecl->m_ident) || symbolTable->contains(funcDecl->m_ident.ustring().rep())) {
+                globalObject->putWithAttributes(exec, funcDecl->m_ident, jsUndefined(), 0);
+                globalObject->deleteProperty(exec, funcDecl->m_ident);
+            }
             emitNewFunction(addVar(funcDecl->m_ident, false), funcDecl);
         }