Changeset 34174 in webkit for trunk/JavaScriptCore

Timestamp:

May 28, 2008, 10:31:22 AM (17 years ago)

Author:

Adam Roben

Message:

Make run-javascriptcore-tests work with a space in the path to testkjs

Reviewed by Alexey Proskuryakov.

• tests/mozilla/jsDriver.pl: Quote the path to the engine so that spaces will be interpreted correctly.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• tests/mozilla/jsDriver.pl (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-05-28  Adam Roben  <[email protected]>
+
+        Make run-javascriptcore-tests work with a space in the path to testkjs
+
+        Reviewed by Alexey Proskuryakov.
+
+        * tests/mozilla/jsDriver.pl: Quote the path to the engine so that
+        spaces will be interpreted correctly.
+
 2008-05-28  Alexey Proskuryakov  <[email protected]>
 

trunk/JavaScriptCore/tests/mozilla/jsDriver.pl

@@ -174 +174 @@
 # since the last time we looked.)
         if ($last_suite ne $suite || $last_test_dir ne $test_dir) {
-            $shell_command = &xp_path($engine_command) . " -s ";
+            # FIXME: Quoting the path this way won't work with paths with
+            # quotes in them. A better fix would be to use the multi-parameter
+            # version of open(), but that doesn't work on ActiveState Perl.
+            $shell_command = "\"" . &xp_path($engine_command) . "\" -s ";
             
             $path = &xp_path($opt_suite_path . $suite . "/shell.js");