Changeset 34192 in webkit for trunk/JavaScriptCore

Timestamp:

May 28, 2008, 9:15:45 PM (17 years ago)

Author:

[email protected]

Message:

Fix codegen for assignment being used as a function.

Reviewed by Anders.

FunctionCallValueNode::emitCode failed to account for the
potential of the function expression to allocate arbitrary
registers.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/nodes.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-05-28  Oliver Hunt  <[email protected]>
+
+        Reviewed by Anders.
+
+        Fix codegen for assignment being used as a function.
+
+        FunctionCallValueNode::emitCode failed to account for the
+        potential of the function expression to allocate arbitrary
+        registers.
+
+        * kjs/nodes.cpp:
+        (KJS::FunctionCallValueNode::emitCode):
+
 2008-05-27  Geoffrey Garen  <[email protected]>
 

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -1310 +1310 @@
 RegisterID* FunctionCallValueNode::emitCode(CodeGenerator& generator, RegisterID* dst)
 {
-    RegisterID* r0 = generator.emitNode(m_expr.get());
-    return generator.emitCall(generator.finalDestination(dst), r0, 0, m_args.get());
+    RefPtr<RegisterID> func = generator.emitNode(m_expr.get());
+    return generator.emitCall(generator.finalDestination(dst), func.get(), 0, m_args.get());
 }