Changeset 34773 in webkit for trunk/JavaScriptCore

Timestamp:

Jun 24, 2008, 1:00:48 PM (17 years ago)

Author:

Darin Adler

Message:

2008-06-24 Darin Adler <Darin Adler>

Reviewed by Cameron.

• fix ​https://bugs.webkit.org/show_bug.cgi?id=19739 REGRESSION: fast/js/property-getters-and-setters.html fails

• kjs/JSObject.cpp: (KJS::JSObject::put): Remove an untested optimization I checked in by accident. The two loops up the prototype chain both need to start from this; instead the second loop was starting where the first loop left off.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/JSObject.cpp (modified) (2 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-06-24  Darin Adler  <[email protected]>
+
+        Reviewed by Cameron.
+
+        - fix https://bugs.webkit.org/show_bug.cgi?id=19739
+          REGRESSION: fast/js/property-getters-and-setters.html fails
+
+        * kjs/JSObject.cpp:
+        (KJS::JSObject::put): Remove an untested optimization I checked in by accident.
+        The two loops up the prototype chain both need to start from this; instead the
+        second loop was starting where the first loop left off.
+
 2008-06-24  Steve Falkenburg  <[email protected]>
 

trunk/JavaScriptCore/kjs/JSObject.cpp

@@ -114 +114 @@
 
   // Check if there are any setters or getters in the prototype chain
-  JSObject* obj;
   JSValue* prototype;
-  for (obj = this; !obj->_prop.hasGetterSetterProperties(); obj = static_cast<JSObject*>(prototype)) {
+  for (JSObject* obj = this; !obj->_prop.hasGetterSetterProperties(); obj = static_cast<JSObject*>(prototype)) {
     prototype = obj->_proto;
     if (prototype == jsNull()) {
@@ -128 +127 @@
     return;
 
-  for (; ; obj = static_cast<JSObject*>(prototype)) {
+  for (JSObject* obj = this; ; obj = static_cast<JSObject*>(prototype)) {
     if (JSValue* gs = obj->_prop.get(propertyName, attributes)) {
       if (attributes & IsGetterSetter) {