Changeset 34961 in webkit for trunk/JavaScriptCore

Timestamp:

Jul 2, 2008, 5:04:19 PM (17 years ago)

Author:

[email protected]

Message:

2008-07-02 Cameron Zwarich <​[email protected]>

Reviewed by Darin.

Bug 19776: Number.toExponential() is incorrect for numbers between 0.1 and 1
<​https://bugs.webkit.org/show_bug.cgi?id=19776>

Perform the sign check for the exponent on the actual exponent value,
which is 1 less than the value of decimalPoint, instead of on the value
of decimalPoint itself.

JavaScriptCore:

• kjs/NumberPrototype.cpp: (KJS::exponentialPartToString):

LayoutTests:

• fast/js/number-toExponential-expected.txt:
• fast/js/resources/number-toExponential.js:

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/NumberPrototype.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-07-02  Cameron Zwarich  <[email protected]>
+
+        Reviewed by Darin.
+
+        Bug 19776: Number.toExponential() is incorrect for numbers between 0.1 and 1
+        <https://bugs.webkit.org/show_bug.cgi?id=19776>
+
+        Perform the sign check for the exponent on the actual exponent value,
+        which is 1 less than the value of decimalPoint, instead of on the value
+        of decimalPoint itself.
+
+        * kjs/NumberPrototype.cpp:
+        (KJS::exponentialPartToString):
+
 2008-07-02  Kevin McCullough  <[email protected]>
 

trunk/JavaScriptCore/kjs/NumberPrototype.cpp

@@ -290 +290 @@
 {
     buf[i++] = 'e';
-    buf[i++] = (decimalPoint >= 0) ? '+' : '-';
     // decimalPoint can't be more than 3 digits decimal given the
     // nature of float representation
     int exponential = decimalPoint - 1;
+    buf[i++] = (exponential >= 0) ? '+' : '-';
     if (exponential < 0)
         exponential *= -1;